From: Stephen Hemminger <stephen@networkplumber.org>
To: Christian Brauner <christian@brauner.io>
Cc: ueberall@themenzentrisch.de, vapier@chromium.org,
richardrose@google.com, bhthompson@google.com,
nikolay@cumulusnetworks.com, netdev@vger.kernel.org,
roopa@cumulusnetworks.com, bridge@lists.linux-foundation.org,
fw@strlen.de, linux-kernel@vger.kernel.org,
joelhockey@chromium.org, tyhicks@canonical.com,
coreteam@netfilter.org, netfilter-devel@vger.kernel.org,
kadlec@blackhole.kfki.hu, smbarber@chromium.org,
davem@davemloft.net, pablo@netfilter.org
Subject: Re: [Bridge] [PATCH RESEND net-next 1/2] br_netfilter: add struct netns_brnf
Date: Thu, 6 Jun 2019 08:14:40 -0700 [thread overview]
Message-ID: <20190606081440.61ea1c62@hermes.lan> (raw)
In-Reply-To: <20190606114142.15972-2-christian@brauner.io>
On Thu, 6 Jun 2019 13:41:41 +0200
Christian Brauner <christian@brauner.io> wrote:
> +struct netns_brnf {
> +#ifdef CONFIG_SYSCTL
> + struct ctl_table_header *ctl_hdr;
> +#endif
> +
> + /* default value is 1 */
> + int call_iptables;
> + int call_ip6tables;
> + int call_arptables;
> +
> + /* default value is 0 */
> + int filter_vlan_tagged;
> + int filter_pppoe_tagged;
> + int pass_vlan_indev;
> +};
Do you really need to waste four bytes for each
flag value. If you use a u8 that would work just as well.
Bool would also work but the kernel developers frown on bool
in structures.
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Hemminger <stephen@networkplumber.org>
To: Christian Brauner <christian@brauner.io>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
bridge@lists.linux-foundation.org, tyhicks@canonical.com,
pablo@netfilter.org, kadlec@blackhole.kfki.hu, fw@strlen.de,
roopa@cumulusnetworks.com, nikolay@cumulusnetworks.com,
linux-kernel@vger.kernel.org, richardrose@google.com,
vapier@chromium.org, bhthompson@google.com,
smbarber@chromium.org, joelhockey@chromium.org,
ueberall@themenzentrisch.de
Subject: Re: [PATCH RESEND net-next 1/2] br_netfilter: add struct netns_brnf
Date: Thu, 6 Jun 2019 08:14:40 -0700 [thread overview]
Message-ID: <20190606081440.61ea1c62@hermes.lan> (raw)
In-Reply-To: <20190606114142.15972-2-christian@brauner.io>
On Thu, 6 Jun 2019 13:41:41 +0200
Christian Brauner <christian@brauner.io> wrote:
> +struct netns_brnf {
> +#ifdef CONFIG_SYSCTL
> + struct ctl_table_header *ctl_hdr;
> +#endif
> +
> + /* default value is 1 */
> + int call_iptables;
> + int call_ip6tables;
> + int call_arptables;
> +
> + /* default value is 0 */
> + int filter_vlan_tagged;
> + int filter_pppoe_tagged;
> + int pass_vlan_indev;
> +};
Do you really need to waste four bytes for each
flag value. If you use a u8 that would work just as well.
Bool would also work but the kernel developers frown on bool
in structures.
next prev parent reply other threads:[~2019-06-06 15:14 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-06 11:41 [Bridge] [PATCH RESEND net-next 0/2] br_netfilter: enable in non-initial netns Christian Brauner
2019-06-06 11:41 ` Christian Brauner
2019-06-06 11:41 ` [Bridge] [PATCH RESEND net-next 1/2] br_netfilter: add struct netns_brnf Christian Brauner
2019-06-06 11:41 ` Christian Brauner
2019-06-06 15:14 ` Stephen Hemminger [this message]
2019-06-06 15:14 ` Stephen Hemminger
2019-06-06 15:19 ` [Bridge] " Christian Brauner
2019-06-06 15:19 ` Christian Brauner
2019-06-06 16:30 ` [Bridge] " Pablo Neira Ayuso
2019-06-06 16:30 ` Pablo Neira Ayuso
2019-06-07 13:25 ` [Bridge] " Christian Brauner
2019-06-07 13:25 ` Christian Brauner
2019-06-07 14:28 ` [Bridge] " Pablo Neira Ayuso
2019-06-07 14:28 ` Pablo Neira Ayuso
2019-06-07 14:43 ` [Bridge] " Pablo Neira Ayuso
2019-06-07 14:43 ` Pablo Neira Ayuso
2019-06-09 15:44 ` [Bridge] " Christian Brauner
2019-06-09 15:44 ` Christian Brauner
2019-06-06 11:41 ` [Bridge] [PATCH RESEND net-next 2/2] br_netfilter: namespace bridge netfilter sysctls Christian Brauner
2019-06-06 11:41 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190606081440.61ea1c62@hermes.lan \
--to=stephen@networkplumber.org \
--cc=bhthompson@google.com \
--cc=bridge@lists.linux-foundation.org \
--cc=christian@brauner.io \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=fw@strlen.de \
--cc=joelhockey@chromium.org \
--cc=kadlec@blackhole.kfki.hu \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=nikolay@cumulusnetworks.com \
--cc=pablo@netfilter.org \
--cc=richardrose@google.com \
--cc=roopa@cumulusnetworks.com \
--cc=smbarber@chromium.org \
--cc=tyhicks@canonical.com \
--cc=ueberall@themenzentrisch.de \
--cc=vapier@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.