From: Lucien Murray-Pitts <lucienmp.qemu@gmail.com>
To: Aleksandar Markovic <aleksandar.m.mail@gmail.com>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org,
Laurent Vivier <laurent@vivier.eu>
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH v2] m68k comments break patch submission due to being incorrectly formatted
Date: Fri, 7 Jun 2019 12:28:26 +0900 [thread overview]
Message-ID: <20190607032825.GA5123@localhost.localdomain> (raw)
In-Reply-To: <CAL1e-=i7WfrHq7k266grEs1xyf_FKVG_4JcvCbrrSZt66c4ftQ@mail.gmail.com>
On Fri, Jun 07, 2019 at 01:58:05AM +0200, Aleksandar Markovic wrote:
> On Jun 7, 2019 1:42 AM, "Lucien Murray-Pitts" <lucienmp.qemu@gmail.com>
> wrote:
> >
> > Altering all comments in target/m68k to match Qemu coding styles so that
> future
> > patches wont fail due to style breaches.
> >
>
> Are you saying that patches fail checkpatch checks even if the new code has
> only correct comment format? (Or, in other words, that checkpatch detects
> comment-related errors in unchanged code, and reports them as the
> errors/warnings in the patch in question?) I just want to understand what
> is the obstacle you are trying to remove.
>
> Thanks, Aleksandar
>
[SNIP of PATCH]
checkpatch is correctly identifying the wrong style in the changed code.
This changed code contains the original comments with ADDITIONAL edits
resulting in pachew/checkpatch complaining.
The m68k is, by my guess, older code and nearly all the comments are different
from the style guide. Some are "/**" or "/*commment here...." and so on.
Since I had a patch AUTO-FLAGGED by patchew for this reason I thought I would
start with a cleanup of the comments to bring them into line with the style.
Cheers,
Luc
WARNING: multiple messages have this Message-ID (diff)
From: Lucien Murray-Pitts <lucienmp.qemu@gmail.com>
To: Aleksandar Markovic <aleksandar.m.mail@gmail.com>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org,
Laurent Vivier <laurent@vivier.eu>
Subject: Re: [Qemu-devel] [PATCH v2] m68k comments break patch submission due to being incorrectly formatted
Date: Fri, 7 Jun 2019 12:28:26 +0900 [thread overview]
Message-ID: <20190607032825.GA5123@localhost.localdomain> (raw)
In-Reply-To: <CAL1e-=i7WfrHq7k266grEs1xyf_FKVG_4JcvCbrrSZt66c4ftQ@mail.gmail.com>
On Fri, Jun 07, 2019 at 01:58:05AM +0200, Aleksandar Markovic wrote:
> On Jun 7, 2019 1:42 AM, "Lucien Murray-Pitts" <lucienmp.qemu@gmail.com>
> wrote:
> >
> > Altering all comments in target/m68k to match Qemu coding styles so that
> future
> > patches wont fail due to style breaches.
> >
>
> Are you saying that patches fail checkpatch checks even if the new code has
> only correct comment format? (Or, in other words, that checkpatch detects
> comment-related errors in unchanged code, and reports them as the
> errors/warnings in the patch in question?) I just want to understand what
> is the obstacle you are trying to remove.
>
> Thanks, Aleksandar
>
[SNIP of PATCH]
checkpatch is correctly identifying the wrong style in the changed code.
This changed code contains the original comments with ADDITIONAL edits
resulting in pachew/checkpatch complaining.
The m68k is, by my guess, older code and nearly all the comments are different
from the style guide. Some are "/**" or "/*commment here...." and so on.
Since I had a patch AUTO-FLAGGED by patchew for this reason I thought I would
start with a cleanup of the comments to bring them into line with the style.
Cheers,
Luc
next prev parent reply other threads:[~2019-06-07 15:14 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-06 23:41 [Qemu-trivial] [PATCH v2] m68k comments break patch submission due to being incorrectly formatted Lucien Murray-Pitts
2019-06-06 23:41 ` [Qemu-devel] " Lucien Murray-Pitts
2019-06-06 23:58 ` [Qemu-trivial] " Aleksandar Markovic
2019-06-06 23:58 ` Aleksandar Markovic
2019-06-07 3:28 ` Lucien Murray-Pitts [this message]
2019-06-07 3:28 ` Lucien Murray-Pitts
2019-06-07 8:34 ` [Qemu-trivial] " Peter Maydell
2019-06-07 8:34 ` Peter Maydell
2019-06-07 9:04 ` [Qemu-trivial] " Laurent Vivier
2019-06-07 9:04 ` Laurent Vivier
2019-06-09 13:39 ` [Qemu-trivial] " Laurent Vivier
2019-06-09 13:39 ` Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190607032825.GA5123@localhost.localdomain \
--to=lucienmp.qemu@gmail.com \
--cc=aleksandar.m.mail@gmail.com \
--cc=laurent@vivier.eu \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.