From: Dan Carpenter <dan.carpenter@oracle.com>
To: jsarha@ti.com
Cc: dri-devel@lists.freedesktop.org
Subject: [bug report] drm/bridge: sii902x: Implement HDMI audio support
Date: Fri, 7 Jun 2019 10:27:10 +0300 [thread overview]
Message-ID: <20190607072710.GA25188@mwanda> (raw)
Hello Jyri Sarha,
The patch ff5781634c41: "drm/bridge: sii902x: Implement HDMI audio
support" from May 27, 2019, leads to the following static checker
warning:
drivers/gpu/drm/bridge/sii902x.c:753 sii902x_audio_codec_init()
warn: 'sii902x->audio.mclk' isn't an ERR_PTR
drivers/gpu/drm/bridge/sii902x.c
723
724 if (!of_property_read_bool(dev->of_node, "#sound-dai-cells")) {
725 dev_dbg(dev, "%s: No \"#sound-dai-cells\", no audio\n",
726 __func__);
727 return 0;
728 }
729
730 num_lanes = of_property_read_variable_u8_array(dev->of_node,
731 "sil,i2s-data-lanes",
732 lanes, 1,
733 ARRAY_SIZE(lanes));
734
735 if (num_lanes == -EINVAL) {
736 dev_dbg(dev,
737 "%s: No \"sil,i2s-data-lanes\", use default <0>\n",
738 __func__);
739 num_lanes = 1;
740 lanes[0] = 0;
741 } else if (num_lanes < 0) {
742 dev_err(dev,
743 "%s: Error gettin \"sil,i2s-data-lanes\": %d\n",
744 __func__, num_lanes);
745 return num_lanes;
746 }
747 codec_data.max_i2s_channels = 2 * num_lanes;
748
749 for (i = 0; i < num_lanes; i++)
750 sii902x->audio.i2s_fifo_sequence[i] |= audio_fifo_id[i] |
751 i2s_lane_id[lanes[i]] | SII902X_TPI_I2S_FIFO_ENABLE;
752
753 if (IS_ERR(sii902x->audio.mclk)) {
^^^^^^^^^^^^^^^^^^^
The "sii902x->audio.mclk" variable is never initialized.
754 dev_err(dev, "%s: No clock (audio mclk) found: %ld\n",
755 __func__, PTR_ERR(sii902x->audio.mclk));
756 return 0;
757 }
758
759 sii902x->audio.pdev = platform_device_register_data(
regards,
dan carpenter
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
reply other threads:[~2019-06-07 7:27 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190607072710.GA25188@mwanda \
--to=dan.carpenter@oracle.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jsarha@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.