[bug report] drm/bridge: sii902x: Implement HDMI audio support

[bug report] drm/bridge: sii902x: Implement HDMI audio support

[Dan Carpenter]

Hello Jyri Sarha,

The patch ff5781634c41: "drm/bridge: sii902x: Implement HDMI audio
support" from May 27, 2019, leads to the following static checker
warning:

	drivers/gpu/drm/bridge/sii902x.c:753 sii902x_audio_codec_init()
	warn: 'sii902x->audio.mclk' isn't an ERR_PTR

drivers/gpu/drm/bridge/sii902x.c
   723  
   724          if (!of_property_read_bool(dev->of_node, "#sound-dai-cells")) {
   725                  dev_dbg(dev, "%s: No \"#sound-dai-cells\", no audio\n",
   726                          __func__);
   727                  return 0;
   728          }
   729  
   730          num_lanes = of_property_read_variable_u8_array(dev->of_node,
   731                                                         "sil,i2s-data-lanes",
   732                                                         lanes, 1,
   733                                                         ARRAY_SIZE(lanes));
   734  
   735          if (num_lanes == -EINVAL) {
   736                  dev_dbg(dev,
   737                          "%s: No \"sil,i2s-data-lanes\", use default <0>\n",
   738                          __func__);
   739                  num_lanes = 1;
   740                  lanes[0] = 0;
   741          } else if (num_lanes < 0) {
   742                  dev_err(dev,
   743                          "%s: Error gettin \"sil,i2s-data-lanes\": %d\n",
   744                          __func__, num_lanes);
   745                  return num_lanes;
   746          }
   747          codec_data.max_i2s_channels = 2 * num_lanes;
   748  
   749          for (i = 0; i < num_lanes; i++)
   750                  sii902x->audio.i2s_fifo_sequence[i] |= audio_fifo_id[i] |
   751                          i2s_lane_id[lanes[i]] | SII902X_TPI_I2S_FIFO_ENABLE;
   752  
   753          if (IS_ERR(sii902x->audio.mclk)) {
                           ^^^^^^^^^^^^^^^^^^^
The "sii902x->audio.mclk" variable is never initialized.

   754                  dev_err(dev, "%s: No clock (audio mclk) found: %ld\n",
   755                          __func__, PTR_ERR(sii902x->audio.mclk));
   756                  return 0;
   757          }
   758  
   759          sii902x->audio.pdev = platform_device_register_data(

regards,
dan carpenter
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel