All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andre Przywara <andre.przywara@arm.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/5] env: allow runtime determination of FAT environment partition
Date: Sat,  8 Jun 2019 02:26:56 +0100	[thread overview]
Message-ID: <20190608012658.5369-4-andre.przywara@arm.com> (raw)
In-Reply-To: <20190608012658.5369-1-andre.przywara@arm.com>

Currently the FAT device and partition which contains the environment
must be configured at compile time. This creates problems for boards
which have multiple bootable devices (like SD card and eMMC).

Similar to what we do for raw MMC environments, introduce a weak function
to allow boards to override this static configuration. Right now we just
return the Kconfig variable.

Signed-off-by: Andre Przywara <andre.przywara@arm.com>
---
 env/fat.c             | 13 +++++++++----
 include/environment.h |  4 ++++
 2 files changed, 13 insertions(+), 4 deletions(-)

diff --git a/env/fat.c b/env/fat.c
index 7f74c64dfe..320f73b6d3 100644
--- a/env/fat.c
+++ b/env/fat.c
@@ -30,6 +30,11 @@
 # endif
 #endif
 
+__weak char *fat_get_env_dev_part(void)
+{
+	return CONFIG_ENV_FAT_DEVICE_AND_PART;
+}
+
 #ifdef CMD_SAVEENV
 static int env_fat_save(void)
 {
@@ -45,8 +50,8 @@ static int env_fat_save(void)
 		return err;
 
 	part = blk_get_device_part_str(CONFIG_ENV_FAT_INTERFACE,
-					CONFIG_ENV_FAT_DEVICE_AND_PART,
-					&dev_desc, &info, 1);
+				       fat_get_env_dev_part(),
+				       &dev_desc, &info, 1);
 	if (part < 0)
 		return 1;
 
@@ -92,8 +97,8 @@ static int env_fat_load(void)
 #endif
 
 	part = blk_get_device_part_str(CONFIG_ENV_FAT_INTERFACE,
-					CONFIG_ENV_FAT_DEVICE_AND_PART,
-					&dev_desc, &info, 1);
+				       fat_get_env_dev_part(),
+				       &dev_desc, &info, 1);
 	if (part < 0)
 		goto err_env_relocate;
 
diff --git a/include/environment.h b/include/environment.h
index cd96676141..364adc76ba 100644
--- a/include/environment.h
+++ b/include/environment.h
@@ -65,6 +65,10 @@
 # endif
 #endif
 
+#if defined(CONFIG_ENV_IS_IN_FAT)
+char *fat_get_env_dev_part(void);
+#endif
+
 #if defined(CONFIG_ENV_IS_IN_NAND)
 # if defined(CONFIG_ENV_OFFSET_OOB)
 #  ifdef CONFIG_ENV_OFFSET_REDUND
-- 
2.14.5

  parent reply	other threads:[~2019-06-08  1:26 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-08  1:26 [U-Boot] [PATCH 0/5] sunxi: env: Load environment from boot media Andre Przywara
2019-06-08  1:26 ` [U-Boot] [PATCH 1/5] env: allow undefined CONFIG_SYS_MMC_ENV_DEV Andre Przywara
2019-06-08 13:13   ` Tom Rini
2019-06-10  9:35     ` Andre Przywara
2019-06-10 21:53       ` Tom Rini
2019-06-08  1:26 ` [U-Boot] [PATCH 2/5] sunxi: autodetect SD/eMMC device for environment Andre Przywara
2019-06-08  1:26 ` Andre Przywara [this message]
2019-06-08 13:13   ` [U-Boot] [PATCH 3/5] env: allow runtime determination of FAT environment partition Tom Rini
2019-06-08  1:26 ` [U-Boot] [PATCH 4/5] sunxi: use FAT environment from boot source Andre Przywara
2019-06-08  1:26 ` [U-Boot] [PATCH 5/5] sunxi: use boot source for determining environment location Andre Przywara
2019-06-10  8:30 ` [U-Boot] [PATCH 0/5] sunxi: env: Load environment from boot media Maxime Ripard
2019-06-10  9:11   ` Andre Przywara
2019-06-11  9:37     ` Maxime Ripard
2019-06-11 14:28       ` Tom Rini
2019-06-11 14:53         ` Maxime Ripard
2019-06-11 15:20           ` Tom Rini
2019-06-11 15:34           ` Andre Przywara
2019-06-11 16:10             ` Tom Rini
2019-06-12 13:08             ` Maxime Ripard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190608012658.5369-4-andre.przywara@arm.com \
    --to=andre.przywara@arm.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.