All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 0/5] sunxi: env: Load environment from boot media
Date: Tue, 11 Jun 2019 10:28:19 -0400	[thread overview]
Message-ID: <20190611142819.GE7115@bill-the-cat> (raw)
In-Reply-To: <20190611093728.5vtgmhge5azs3vaz@flea>

On Tue, Jun 11, 2019 at 11:37:28AM +0200, Maxime Ripard wrote:
> On Mon, Jun 10, 2019 at 10:11:39AM +0100, Andre Przywara wrote:
> > On Mon, 10 Jun 2019 10:30:37 +0200
> > Maxime Ripard <maxime.ripard@bootlin.com> wrote:
> >
> > Hi Maxime,
> >
> > thanks for having a look!
> >
> > > On Sat, Jun 08, 2019 at 02:26:53AM +0100, Andre Przywara wrote:
> > > > At the moment we need to configure the place where U-Boot tries to load
> > > > its environment from at compile time. This is not only inflexible, but
> > > > also unnecessary, as we have easy access to the boot source.
> > > >
> > > > This series prepares U-Boot on Allwinner boards to load the environment
> > > > from the same media where the SPL and U-Boot proper were loaded from.
> > > > This allows to keep one firmware binary, and copy it to an SD card,
> > > > eMMC or even SPI flash, without needing to configure it differently.
> > >
> > > This does change a couple of things though. The environment used to be
> > > loaded always from the same source, no matter the boot device. This
> > > means that if you would set an SD card, you would get the environment
> > > from the eMMC. Same thing for FEL. This is no longer the case.
> > >
> > > I don't know whether it's a good or a bad thing, but it should be
> > > mentionned.
> >
> > This is true, I failed to mention that.
> >
> > To start a discussion on this:
> > I consider the current (fixed location) behaviour somewhat surprising and
> > limiting, and couldn't find a real use case where this would be required.
> > Happy to hear of one!
> > Instead I thought about those cases:
> > - There is some botched U-Boot plus environment on the eMMC. You want to
> > boot from SD card to have a clean start, possibly to fix it. But it will
> > load the possibly outdated, broken or even unrelated environment from eMMC.
> 
> This one might be a feature though. Being able to restore / fix an
> environment in the eMMC running from an SD card has save me a couple
> of times. Or booting from the SD card because the U-Boot on the eMMC
> is broken, while the environment is working.
> 
> > - You want to boot from SD card without touching the eMMC at all. Saving
> > the environment will spoil that.
> 
> But it goes against that one, which might be more important / sensible.
> 
> > - You want to have one image for all possible boot media.
> 
> That won't happen, only because NAND is a thing.

Some of this is perhaps an argument for adding a sub-command to specify
where the environment is to be read from.  Heuristics are still only a
best guess and won't get it right every time.

> And even then, I'm not really sure that it's a good thing. A U-Boot
> build these days is roughly in the same sizes than a stripped down
> Linux image. For an inferior solution in pretty much every aspect.

Hey now.  We aren't _quite_ that large.  And we are (really!) trying to
find a happy medium between "distros want X/Y/Z for everyone" and "can
we commonly get back to UNDER 512kB maybe?  Please?".

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190611/37732981/attachment.sig>

  reply	other threads:[~2019-06-11 14:28 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-08  1:26 [U-Boot] [PATCH 0/5] sunxi: env: Load environment from boot media Andre Przywara
2019-06-08  1:26 ` [U-Boot] [PATCH 1/5] env: allow undefined CONFIG_SYS_MMC_ENV_DEV Andre Przywara
2019-06-08 13:13   ` Tom Rini
2019-06-10  9:35     ` Andre Przywara
2019-06-10 21:53       ` Tom Rini
2019-06-08  1:26 ` [U-Boot] [PATCH 2/5] sunxi: autodetect SD/eMMC device for environment Andre Przywara
2019-06-08  1:26 ` [U-Boot] [PATCH 3/5] env: allow runtime determination of FAT environment partition Andre Przywara
2019-06-08 13:13   ` Tom Rini
2019-06-08  1:26 ` [U-Boot] [PATCH 4/5] sunxi: use FAT environment from boot source Andre Przywara
2019-06-08  1:26 ` [U-Boot] [PATCH 5/5] sunxi: use boot source for determining environment location Andre Przywara
2019-06-10  8:30 ` [U-Boot] [PATCH 0/5] sunxi: env: Load environment from boot media Maxime Ripard
2019-06-10  9:11   ` Andre Przywara
2019-06-11  9:37     ` Maxime Ripard
2019-06-11 14:28       ` Tom Rini [this message]
2019-06-11 14:53         ` Maxime Ripard
2019-06-11 15:20           ` Tom Rini
2019-06-11 15:34           ` Andre Przywara
2019-06-11 16:10             ` Tom Rini
2019-06-12 13:08             ` Maxime Ripard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190611142819.GE7115@bill-the-cat \
    --to=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.