From: Borislav Petkov <bp@alien8.de>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: James Morse <james.morse@arm.com>,
"Hawa, Hanna" <hhhawa@amazon.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"Woodhouse, David" <dwmw@amazon.co.uk>,
"paulmck@linux.ibm.com" <paulmck@linux.ibm.com>,
"mchehab@kernel.org" <mchehab@kernel.org>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"davem@davemloft.net" <davem@davemloft.net>,
"nicolas.ferre@microchip.com" <nicolas.ferre@microchip.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"Shenhar, Talel" <talel@amazon.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Chocron, Jonathan" <jonnyc@amazon.com>,
"Krupnik, Ronen" <ronenk@amazon.com>,
"linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
"Hanoch, Uri" <hanochu@amazon.com>
Subject: Re: [PATCH 2/2] edac: add support for Amazon's Annapurna Labs EDAC
Date: Tue, 11 Jun 2019 13:47:29 +0200 [thread overview]
Message-ID: <20190611114729.GC31772@zn.tnic> (raw)
In-Reply-To: <1ae5e7a3464f9d8e16b112cd371957ea20472864.camel@kernel.crashing.org>
On Tue, Jun 11, 2019 at 03:50:40PM +1000, Benjamin Herrenschmidt wrote:
> Should we fix that then instead ?
Sure.
> What are the big issues with adding some basic locking ? being called
> from NMIs ?
That is one possible issue. I know we don't call the error decoding
routines in NMI context on x86 but no clue about ARM.
> If the separate drivers operate on distinct counters I don't see a big
> problem there.
Yes, and they do.
> I'n not sure why <platform_name> ...
Well, however you'd call it. It will be some distinct name I hope :)
--
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
WARNING: multiple messages have this Message-ID (diff)
From: Borislav Petkov <bp@alien8.de>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: James Morse <james.morse@arm.com>,
"Hawa, Hanna" <hhhawa@amazon.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"Woodhouse, David" <dwmw@amazon.co.uk>,
"paulmck@linux.ibm.com" <paulmck@linux.ibm.com>,
"mchehab@kernel.org" <mchehab@kernel.org>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"davem@davemloft.net" <davem@davemloft.net>,
"nicolas.ferre@microchip.com" <nicolas.ferre@microchip.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"Shenhar, Talel" <talel@amazon.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Chocron, Jonathan" <jonnyc@amazon.com>,
"Krupnik, Ronen" <ronenk@amazon.com>,
"linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
Hanoch, Uri
Subject: Re: [PATCH 2/2] edac: add support for Amazon's Annapurna Labs EDAC
Date: Tue, 11 Jun 2019 13:47:29 +0200 [thread overview]
Message-ID: <20190611114729.GC31772@zn.tnic> (raw)
In-Reply-To: <1ae5e7a3464f9d8e16b112cd371957ea20472864.camel@kernel.crashing.org>
On Tue, Jun 11, 2019 at 03:50:40PM +1000, Benjamin Herrenschmidt wrote:
> Should we fix that then instead ?
Sure.
> What are the big issues with adding some basic locking ? being called
> from NMIs ?
That is one possible issue. I know we don't call the error decoding
routines in NMI context on x86 but no clue about ARM.
> If the separate drivers operate on distinct counters I don't see a big
> problem there.
Yes, and they do.
> I'n not sure why <platform_name> ...
Well, however you'd call it. It will be some distinct name I hope :)
--
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
next prev parent reply other threads:[~2019-06-11 11:47 UTC|newest]
Thread overview: 78+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-30 10:15 [PATCH 0/2] Add support for Amazon's Annapurna Labs EDAC for L1/L2 Hanna Hawa
2019-05-30 10:15 ` Hanna Hawa
2019-05-30 10:15 ` [PATCH 1/2] dt-bindings: EDAC: add Amazon Annapurna Labs EDAC binding Hanna Hawa
2019-05-30 10:15 ` Hanna Hawa
2019-05-30 11:54 ` Greg KH
2019-05-31 0:35 ` Borislav Petkov
2019-06-03 7:24 ` Woodhouse, David
2019-05-30 10:15 ` [PATCH 2/2] edac: add support for Amazon's Annapurna Labs EDAC Hanna Hawa
2019-05-30 10:15 ` Hanna Hawa
2019-05-30 11:57 ` Greg KH
2019-05-30 12:52 ` hhhawa
2019-05-30 12:52 ` hhhawa
2019-05-30 13:04 ` Joe Perches
2019-05-30 18:19 ` Boris Petkov
2019-05-30 18:19 ` Boris Petkov
2019-05-31 1:15 ` Herrenschmidt, Benjamin
2019-05-31 5:14 ` Borislav Petkov
2019-06-05 15:13 ` James Morse
2019-06-06 7:53 ` Hawa, Hanna
2019-06-06 10:03 ` Borislav Petkov
2019-06-06 10:03 ` Borislav Petkov
2019-06-06 10:33 ` James Morse
2019-06-06 11:22 ` Borislav Petkov
2019-06-06 11:22 ` Borislav Petkov
2019-06-06 11:37 ` Shenhar, Talel
2019-06-07 15:11 ` James Morse
2019-06-07 15:11 ` James Morse
2019-06-08 0:22 ` Benjamin Herrenschmidt
2019-06-08 0:16 ` Benjamin Herrenschmidt
2019-06-08 9:05 ` Borislav Petkov
2019-06-08 9:05 ` Borislav Petkov
2019-06-11 5:50 ` Benjamin Herrenschmidt
2019-06-11 5:50 ` Benjamin Herrenschmidt
2019-06-11 7:21 ` Benjamin Herrenschmidt
2019-06-11 7:21 ` Benjamin Herrenschmidt
2019-06-11 11:56 ` Borislav Petkov
2019-06-11 11:56 ` Borislav Petkov
2019-06-11 22:25 ` Benjamin Herrenschmidt
2019-06-11 22:25 ` Benjamin Herrenschmidt
2019-06-12 3:48 ` Borislav Petkov
2019-06-12 8:29 ` Benjamin Herrenschmidt
2019-06-12 10:42 ` Borislav Petkov
2019-06-12 10:42 ` Borislav Petkov
2019-06-12 23:54 ` Benjamin Herrenschmidt
2019-06-12 23:54 ` Benjamin Herrenschmidt
2019-06-13 7:44 ` Borislav Petkov
2019-06-13 7:44 ` Borislav Petkov
2019-06-14 10:53 ` Borislav Petkov
2019-06-14 10:53 ` Borislav Petkov
2019-06-12 10:42 ` Mauro Carvalho Chehab
2019-06-12 11:00 ` Borislav Petkov
2019-06-12 11:00 ` Borislav Petkov
2019-06-12 11:42 ` Mauro Carvalho Chehab
2019-06-12 11:42 ` Mauro Carvalho Chehab
2019-06-12 11:57 ` Benjamin Herrenschmidt
2019-06-12 12:25 ` Borislav Petkov
2019-06-12 12:25 ` Borislav Petkov
2019-06-12 12:35 ` Hawa, Hanna
2019-06-12 15:34 ` Borislav Petkov
2019-06-12 15:34 ` Borislav Petkov
2019-06-12 23:57 ` Benjamin Herrenschmidt
2019-06-12 23:57 ` Benjamin Herrenschmidt
2019-06-12 23:56 ` Benjamin Herrenschmidt
2019-06-11 7:29 ` Hawa, Hanna
2019-06-11 11:59 ` Borislav Petkov
2019-06-11 11:59 ` Borislav Petkov
2019-06-11 11:47 ` Borislav Petkov [this message]
2019-06-11 11:47 ` Borislav Petkov
2019-06-03 6:56 ` Hawa, Hanna
2019-06-05 15:16 ` James Morse
2019-06-11 19:56 ` Hawa, Hanna
2019-06-11 19:56 ` Hawa, Hanna
2019-06-13 17:05 ` James Morse
2019-06-14 10:49 ` James Morse
2019-06-17 13:00 ` Hawa, Hanna
2019-06-17 13:00 ` Hawa, Hanna
2019-06-19 17:22 ` James Morse
2019-06-19 17:22 ` James Morse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190611114729.GC31772@zn.tnic \
--to=bp@alien8.de \
--cc=benh@kernel.crashing.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dwmw@amazon.co.uk \
--cc=gregkh@linuxfoundation.org \
--cc=hanochu@amazon.com \
--cc=hhhawa@amazon.com \
--cc=james.morse@arm.com \
--cc=jonnyc@amazon.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mchehab@kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=paulmck@linux.ibm.com \
--cc=robh+dt@kernel.org \
--cc=ronenk@amazon.com \
--cc=talel@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.