All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: Christoph Hellwig <hch@lst.de>,
	Aaro Koskinen <aaro.koskinen@iki.fi>,
	Christian Zigotzky <chzigotzky@xenosoft.de>,
	Michael Ellerman <mpe@ellerman.id.au>,
	linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org
Subject: Re: [BISECTED REGRESSION] b43legacy broken on G4 PowerBook
Date: Wed, 12 Jun 2019 08:55:58 +0200	[thread overview]
Message-ID: <20190612065558.GA19585@lst.de> (raw)
In-Reply-To: <5aaa600b-5b59-1f68-454f-20403c318f1a@lwfinger.net>

On Tue, Jun 11, 2019 at 05:20:12PM -0500, Larry Finger wrote:
> Your first patch did not work as the configuration does not have 
> CONFIG_ZONE_DMA. As a result, the initial value of min_mask always starts 
> at 32 bits and is taken down to 31 with the maximum pfn minimization. When 
> I forced the initial value of min_mask to 30 bits, the device worked.

Ooops, yes.  But I think we could just enable ZONE_DMA on 32-bit
powerpc.  Crude enablement hack below:

diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig
index 8c1c636308c8..1dd71a98b70c 100644
--- a/arch/powerpc/Kconfig
+++ b/arch/powerpc/Kconfig
@@ -372,7 +372,7 @@ config PPC_ADV_DEBUG_DAC_RANGE
 
 config ZONE_DMA
 	bool
-	default y if PPC_BOOK3E_64
+	default y
 
 config PGTABLE_LEVELS
 	int

WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: Aaro Koskinen <aaro.koskinen@iki.fi>,
	linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
	Christian Zigotzky <chzigotzky@xenosoft.de>,
	linuxppc-dev@lists.ozlabs.org, Christoph Hellwig <hch@lst.de>
Subject: Re: [BISECTED REGRESSION] b43legacy broken on G4 PowerBook
Date: Wed, 12 Jun 2019 08:55:58 +0200	[thread overview]
Message-ID: <20190612065558.GA19585@lst.de> (raw)
In-Reply-To: <5aaa600b-5b59-1f68-454f-20403c318f1a@lwfinger.net>

On Tue, Jun 11, 2019 at 05:20:12PM -0500, Larry Finger wrote:
> Your first patch did not work as the configuration does not have 
> CONFIG_ZONE_DMA. As a result, the initial value of min_mask always starts 
> at 32 bits and is taken down to 31 with the maximum pfn minimization. When 
> I forced the initial value of min_mask to 30 bits, the device worked.

Ooops, yes.  But I think we could just enable ZONE_DMA on 32-bit
powerpc.  Crude enablement hack below:

diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig
index 8c1c636308c8..1dd71a98b70c 100644
--- a/arch/powerpc/Kconfig
+++ b/arch/powerpc/Kconfig
@@ -372,7 +372,7 @@ config PPC_ADV_DEBUG_DAC_RANGE
 
 config ZONE_DMA
 	bool
-	default y if PPC_BOOK3E_64
+	default y
 
 config PGTABLE_LEVELS
 	int

  parent reply	other threads:[~2019-06-12  6:56 UTC|newest]

Thread overview: 76+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-05 22:50 [BISECTED REGRESSION] b43legacy broken on G4 PowerBook Aaro Koskinen
2019-06-05 22:50 ` Aaro Koskinen
2019-06-06  0:54 ` Benjamin Herrenschmidt
2019-06-06  0:54   ` Benjamin Herrenschmidt
2019-06-06  9:31   ` Aaro Koskinen
2019-06-06  9:31     ` Aaro Koskinen
2019-06-06 10:56     ` Benjamin Herrenschmidt
2019-06-06 10:56       ` Benjamin Herrenschmidt
2019-06-06 10:57       ` Benjamin Herrenschmidt
2019-06-06 10:57         ` Benjamin Herrenschmidt
2019-06-06 11:43         ` Christoph Hellwig
2019-06-06 11:43           ` Christoph Hellwig
2019-06-06 19:26           ` Larry Finger
2019-06-06 19:26             ` Larry Finger
2019-06-06 20:11           ` Larry Finger
2019-06-06 20:11             ` Larry Finger
2019-06-06  3:06 ` Larry Finger
2019-06-06  3:06   ` Larry Finger
2019-06-06  6:40   ` Christoph Hellwig
2019-06-06  6:40     ` Christoph Hellwig
2019-06-07 17:25 ` Larry Finger
2019-06-07 17:25   ` Larry Finger
2019-06-07 17:29   ` Christoph Hellwig
2019-06-07 17:29     ` Christoph Hellwig
2019-06-07 18:50     ` Larry Finger
2019-06-07 18:50       ` Larry Finger
2019-06-08 21:52     ` Larry Finger
2019-06-08 21:52       ` Larry Finger
2019-06-10  8:18       ` Christoph Hellwig
2019-06-10  8:18         ` Christoph Hellwig
2019-06-10 16:09         ` Larry Finger
2019-06-10 16:09           ` Larry Finger
2019-06-11  6:05           ` Christoph Hellwig
2019-06-11  6:05             ` Christoph Hellwig
2019-06-11 22:20             ` Larry Finger
2019-06-11 22:20               ` Larry Finger
2019-06-11 22:46               ` Aaro Koskinen
2019-06-11 22:46                 ` Aaro Koskinen
2019-06-12  1:57                 ` Larry Finger
2019-06-12  1:57                   ` Larry Finger
2019-06-11 22:46               ` Benjamin Herrenschmidt
2019-06-11 22:46                 ` Benjamin Herrenschmidt
2019-06-12  1:52                 ` Larry Finger
2019-06-12  1:52                   ` Larry Finger
2019-06-12  3:32                   ` Benjamin Herrenschmidt
2019-06-12  3:32                     ` Benjamin Herrenschmidt
2019-06-12  6:55               ` Christoph Hellwig [this message]
2019-06-12  6:55                 ` Christoph Hellwig
2019-06-12 19:41                 ` Larry Finger
2019-06-12 19:41                   ` Larry Finger
2019-06-12 21:59                   ` Benjamin Herrenschmidt
2019-06-12 21:59                     ` Benjamin Herrenschmidt
2019-06-13  7:29                     ` Christoph Hellwig
2019-06-13  7:29                       ` Christoph Hellwig
2019-06-11 17:48           ` Andreas Schwab
2019-06-11 17:48             ` Andreas Schwab
2019-06-08  4:21   ` Benjamin Herrenschmidt
2019-06-08  4:21     ` Benjamin Herrenschmidt
2019-06-08  7:23     ` Christoph Hellwig
2019-06-08  7:23       ` Christoph Hellwig
2019-06-10 18:44     ` Larry Finger
2019-06-10 18:44       ` Larry Finger
2019-06-11  5:56       ` Benjamin Herrenschmidt
2019-06-11  5:56         ` Benjamin Herrenschmidt
2019-06-11  6:08         ` Christoph Hellwig
2019-06-11  6:08           ` Christoph Hellwig
2019-06-11  6:58           ` Benjamin Herrenschmidt
2019-06-11  6:58             ` Benjamin Herrenschmidt
2019-06-11  6:59             ` Benjamin Herrenschmidt
2019-06-11  6:59               ` Benjamin Herrenschmidt
2019-06-11  7:54               ` Christoph Hellwig
2019-06-11  7:54                 ` Christoph Hellwig
2019-06-11  9:04                 ` Benjamin Herrenschmidt
2019-06-11  9:04                   ` Benjamin Herrenschmidt
2019-06-11  7:53             ` Christoph Hellwig
2019-06-11  7:53               ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190612065558.GA19585@lst.de \
    --to=hch@lst.de \
    --cc=Larry.Finger@lwfinger.net \
    --cc=aaro.koskinen@iki.fi \
    --cc=chzigotzky@xenosoft.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mpe@ellerman.id.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.