From: Paul Mackerras <paulus@ozlabs.org>
To: Christophe Leroy <christophe.leroy@c-s.fr>
Cc: "Michael Neuling" <mikey@neuling.org>,
linuxppc-dev@lists.ozlabs.org, "Cédric Le Goater" <clg@kaod.org>,
kvm-ppc@vger.kernel.org
Subject: Re: [PATCH] KVM: PPC: Book3S HV: Fix r3 corruption in h_set_dabr()
Date: Wed, 12 Jun 2019 09:23:42 +0000 [thread overview]
Message-ID: <20190612092342.GA18684@blackberry> (raw)
In-Reply-To: <1ee1cc67-d342-6610-4865-8c52a85e67c1@c-s.fr>
On Wed, Jun 12, 2019 at 09:42:52AM +0200, Christophe Leroy wrote:
>
>
> Le 12/06/2019 à 09:22, Michael Neuling a écrit :
> >In commit c1fe190c0672 ("powerpc: Add force enable of DAWR on P9
> >option") I screwed up some assembler and corrupted a pointer in
> >r3. This resulted in crashes like the below from Cédric:
>
> Iaw Documentation/process/submitting-patches.rst:
>
> Describe your changes in imperative mood, e.g. "make xyzzy do frotz"
> instead of "[This patch] makes xyzzy do frotz" or "[I] changed xyzzy
> to do frotz", as if you are giving orders to the codebase to change
> its behaviour.
>
> So you could rephrase as follows for instance:
>
> Commit XXXX ("") screwed up some assembler ....
That advice in submitting-patches.rst is certainly appropriate when
talking about the actual change that the patch makes. However, it is
also appropriate to give descriptive background material that helps
the reader to understand why the change is necessary -- in this case,
where and how the bug was introduced. So I'm going to support Mikey
as regards his first few paragraphs.
I agree that the last paragraph that says "This fixes the bug by ..."
could be reworded as "Fix the bug by ...".
Paul.
WARNING: multiple messages have this Message-ID (diff)
From: Paul Mackerras <paulus@ozlabs.org>
To: Christophe Leroy <christophe.leroy@c-s.fr>
Cc: "Michael Neuling" <mikey@neuling.org>,
linuxppc-dev@lists.ozlabs.org, "Cédric Le Goater" <clg@kaod.org>,
kvm-ppc@vger.kernel.org
Subject: Re: [PATCH] KVM: PPC: Book3S HV: Fix r3 corruption in h_set_dabr()
Date: Wed, 12 Jun 2019 19:23:42 +1000 [thread overview]
Message-ID: <20190612092342.GA18684@blackberry> (raw)
In-Reply-To: <1ee1cc67-d342-6610-4865-8c52a85e67c1@c-s.fr>
On Wed, Jun 12, 2019 at 09:42:52AM +0200, Christophe Leroy wrote:
>
>
> Le 12/06/2019 à 09:22, Michael Neuling a écrit :
> >In commit c1fe190c0672 ("powerpc: Add force enable of DAWR on P9
> >option") I screwed up some assembler and corrupted a pointer in
> >r3. This resulted in crashes like the below from Cédric:
>
> Iaw Documentation/process/submitting-patches.rst:
>
> Describe your changes in imperative mood, e.g. "make xyzzy do frotz"
> instead of "[This patch] makes xyzzy do frotz" or "[I] changed xyzzy
> to do frotz", as if you are giving orders to the codebase to change
> its behaviour.
>
> So you could rephrase as follows for instance:
>
> Commit XXXX ("") screwed up some assembler ....
That advice in submitting-patches.rst is certainly appropriate when
talking about the actual change that the patch makes. However, it is
also appropriate to give descriptive background material that helps
the reader to understand why the change is necessary -- in this case,
where and how the bug was introduced. So I'm going to support Mikey
as regards his first few paragraphs.
I agree that the last paragraph that says "This fixes the bug by ..."
could be reworded as "Fix the bug by ...".
Paul.
next prev parent reply other threads:[~2019-06-12 9:23 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-12 7:22 [PATCH] KVM: PPC: Book3S HV: Fix r3 corruption in h_set_dabr() Michael Neuling
2019-06-12 7:22 ` Michael Neuling
2019-06-12 7:42 ` Christophe Leroy
2019-06-12 7:42 ` Christophe Leroy
2019-06-12 9:23 ` Paul Mackerras [this message]
2019-06-12 9:23 ` Paul Mackerras
2019-06-12 9:28 ` Christophe Leroy
2019-06-12 9:28 ` Christophe Leroy
2019-06-12 7:43 ` Cédric Le Goater
2019-06-12 7:43 ` Cédric Le Goater
2019-06-13 0:16 ` Michael Neuling
2019-06-13 0:16 ` Michael Neuling
2019-06-13 0:39 ` Suraj Jitindar Singh
2019-06-13 0:39 ` Suraj Jitindar Singh
2019-06-13 1:50 ` Michael Neuling
2019-06-13 1:50 ` Michael Neuling
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190612092342.GA18684@blackberry \
--to=paulus@ozlabs.org \
--cc=christophe.leroy@c-s.fr \
--cc=clg@kaod.org \
--cc=kvm-ppc@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mikey@neuling.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.