From: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
To: Neil Horman <nhorman@tuxdriver.com>
Cc: linux-sctp@vger.kernel.org, netdev@vger.kernel.org,
syzbot+f7e9153b037eac9b1df8@syzkaller.appspotmail.com,
Xin Long <lucien.xin@gmail.com>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH v4 net] sctp: Free cookie before we memdup a new one
Date: Wed, 12 Jun 2019 18:07:15 +0000 [thread overview]
Message-ID: <20190612180715.GC3500@localhost.localdomain> (raw)
In-Reply-To: <20190612003814.7219-1-nhorman@tuxdriver.com>
On Tue, Jun 11, 2019 at 08:38:14PM -0400, Neil Horman wrote:
> Based on comments from Xin, even after fixes for our recent syzbot
> report of cookie memory leaks, its possible to get a resend of an INIT
> chunk which would lead to us leaking cookie memory.
>
> To ensure that we don't leak cookie memory, free any previously
> allocated cookie first.
>
> ---
This marker can't be here, as it causes git to loose everything below.
> Change notes
> v1->v2
> update subsystem tag in subject (davem)
> repeat kfree check for peer_random and peer_hmacs (xin)
>
> v2->v3
> net->sctp
> also free peer_chunks
>
> v3->v4
> fix subject tags
>
> Signed-off-by: Neil Horman <nhorman@tuxdriver.com>
> Reported-by: syzbot+f7e9153b037eac9b1df8@syzkaller.appspotmail.com
> CC: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
> CC: Xin Long <lucien.xin@gmail.com>
> CC: "David S. Miller" <davem@davemloft.net>
> CC: netdev@vger.kernel.org
Anyhow, LGTM and reproducer didn't give any hits in 2 runs of 50mins.
Acked-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
WARNING: multiple messages have this Message-ID (diff)
From: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
To: Neil Horman <nhorman@tuxdriver.com>
Cc: linux-sctp@vger.kernel.org, netdev@vger.kernel.org,
syzbot+f7e9153b037eac9b1df8@syzkaller.appspotmail.com,
Xin Long <lucien.xin@gmail.com>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH v4 net] sctp: Free cookie before we memdup a new one
Date: Wed, 12 Jun 2019 15:07:15 -0300 [thread overview]
Message-ID: <20190612180715.GC3500@localhost.localdomain> (raw)
In-Reply-To: <20190612003814.7219-1-nhorman@tuxdriver.com>
On Tue, Jun 11, 2019 at 08:38:14PM -0400, Neil Horman wrote:
> Based on comments from Xin, even after fixes for our recent syzbot
> report of cookie memory leaks, its possible to get a resend of an INIT
> chunk which would lead to us leaking cookie memory.
>
> To ensure that we don't leak cookie memory, free any previously
> allocated cookie first.
>
> ---
This marker can't be here, as it causes git to loose everything below.
> Change notes
> v1->v2
> update subsystem tag in subject (davem)
> repeat kfree check for peer_random and peer_hmacs (xin)
>
> v2->v3
> net->sctp
> also free peer_chunks
>
> v3->v4
> fix subject tags
>
> Signed-off-by: Neil Horman <nhorman@tuxdriver.com>
> Reported-by: syzbot+f7e9153b037eac9b1df8@syzkaller.appspotmail.com
> CC: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
> CC: Xin Long <lucien.xin@gmail.com>
> CC: "David S. Miller" <davem@davemloft.net>
> CC: netdev@vger.kernel.org
Anyhow, LGTM and reproducer didn't give any hits in 2 runs of 50mins.
Acked-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
next prev parent reply other threads:[~2019-06-12 18:07 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-10 16:34 [PATCH] Free cookie before we memdup a new one Neil Horman
2019-06-10 16:34 ` Neil Horman
2019-06-10 16:38 ` David Miller
2019-06-10 16:38 ` David Miller
2019-06-10 16:54 ` Xin Long
2019-06-10 16:54 ` Xin Long
2019-06-11 11:21 ` [PATCH v2] [net] " Neil Horman
2019-06-11 11:21 ` Neil Horman
2019-06-11 11:44 ` Marcelo Ricardo Leitner
2019-06-11 11:44 ` Marcelo Ricardo Leitner
2019-06-11 12:17 ` Marcelo Ricardo Leitner
2019-06-11 12:17 ` Marcelo Ricardo Leitner
2019-06-11 16:06 ` David Miller
2019-06-11 16:06 ` David Miller
2019-06-11 19:22 ` [PATCH v3] [sctp] " Neil Horman
2019-06-11 19:22 ` Neil Horman
2019-06-11 20:08 ` David Miller
2019-06-11 20:08 ` David Miller
2019-06-11 20:52 ` Neil Horman
2019-06-11 20:52 ` Neil Horman
2019-06-12 0:38 ` [PATCH v4 net] sctp: " Neil Horman
2019-06-12 0:38 ` Neil Horman
2019-06-12 17:58 ` Xin Long
2019-06-12 17:58 ` Xin Long
2019-06-12 18:07 ` Marcelo Ricardo Leitner [this message]
2019-06-12 18:07 ` Marcelo Ricardo Leitner
2019-06-12 20:32 ` Neil Horman
2019-06-12 20:32 ` Neil Horman
2019-06-12 20:41 ` David Miller
2019-06-12 20:41 ` David Miller
2019-06-13 10:35 ` [PATCH v5 " Neil Horman
2019-06-13 10:35 ` Neil Horman
2019-06-13 16:51 ` Marcelo Ricardo Leitner
2019-06-13 16:51 ` Marcelo Ricardo Leitner
2019-06-15 2:27 ` David Miller
2019-06-15 2:27 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190612180715.GC3500@localhost.localdomain \
--to=marcelo.leitner@gmail.com \
--cc=davem@davemloft.net \
--cc=linux-sctp@vger.kernel.org \
--cc=lucien.xin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=syzbot+f7e9153b037eac9b1df8@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.