* [PATCH net] net: phy: sfp: clean up a condition
@ 2019-06-13 6:51 ` Dan Carpenter
0 siblings, 0 replies; 12+ messages in thread
From: Dan Carpenter @ 2019-06-13 6:51 UTC (permalink / raw)
To: Russell King, Ruslan Babayev
Cc: Andrew Lunn, Florian Fainelli, Heiner Kallweit, David S. Miller,
netdev, kernel-janitors
The acpi_node_get_property_reference() doesn't return ACPI error codes,
it just returns regular negative kernel error codes. This patch doesn't
affect run time, it's just a clean up.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/net/phy/sfp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/phy/sfp.c b/drivers/net/phy/sfp.c
index a991c80e6567..8a99307c1c39 100644
--- a/drivers/net/phy/sfp.c
+++ b/drivers/net/phy/sfp.c
@@ -1848,7 +1848,7 @@ static int sfp_probe(struct platform_device *pdev)
int ret;
ret = acpi_node_get_property_reference(fw, "i2c-bus", 0, &args);
- if (ACPI_FAILURE(ret) || !is_acpi_device_node(args.fwnode)) {
+ if (ret || !is_acpi_device_node(args.fwnode)) {
dev_err(&pdev->dev, "missing 'i2c-bus' property\n");
return -ENODEV;
}
--
2.20.1
^ permalink raw reply related [flat|nested] 12+ messages in thread* Re: [PATCH net] net: phy: sfp: clean up a condition
2019-06-13 6:51 ` Dan Carpenter
@ 2019-06-13 17:54 ` Ruslan Babayev
-1 siblings, 0 replies; 12+ messages in thread
From: Ruslan Babayev @ 2019-06-13 17:54 UTC (permalink / raw)
To: Dan Carpenter
Cc: Russell King, Ruslan Babayev, Andrew Lunn, Florian Fainelli,
Heiner Kallweit, David S. Miller, netdev, kernel-janitors
Dan Carpenter writes:
> The acpi_node_get_property_reference() doesn't return ACPI error codes,
> it just returns regular negative kernel error codes. This patch doesn't
> affect run time, it's just a clean up.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
Reviewed-by: Ruslan Babayev <ruslan@babayev.com>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH net] net: phy: sfp: clean up a condition
@ 2019-06-13 17:54 ` Ruslan Babayev
0 siblings, 0 replies; 12+ messages in thread
From: Ruslan Babayev @ 2019-06-13 17:54 UTC (permalink / raw)
To: Dan Carpenter
Cc: Russell King, Ruslan Babayev, Andrew Lunn, Florian Fainelli,
Heiner Kallweit, David S. Miller, netdev, kernel-janitors
Dan Carpenter writes:
> The acpi_node_get_property_reference() doesn't return ACPI error codes,
> it just returns regular negative kernel error codes. This patch doesn't
> affect run time, it's just a clean up.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
Reviewed-by: Ruslan Babayev <ruslan@babayev.com>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH net] net: phy: sfp: clean up a condition
2019-06-13 6:51 ` Dan Carpenter
@ 2019-06-13 18:00 ` Russell King - ARM Linux admin
-1 siblings, 0 replies; 12+ messages in thread
From: Russell King - ARM Linux admin @ 2019-06-13 18:00 UTC (permalink / raw)
To: Dan Carpenter
Cc: Ruslan Babayev, Andrew Lunn, Florian Fainelli, Heiner Kallweit,
David S. Miller, netdev, kernel-janitors
On Thu, Jun 13, 2019 at 09:51:02AM +0300, Dan Carpenter wrote:
> The acpi_node_get_property_reference() doesn't return ACPI error codes,
> it just returns regular negative kernel error codes. This patch doesn't
> affect run time, it's just a clean up.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> drivers/net/phy/sfp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/phy/sfp.c b/drivers/net/phy/sfp.c
> index a991c80e6567..8a99307c1c39 100644
> --- a/drivers/net/phy/sfp.c
> +++ b/drivers/net/phy/sfp.c
> @@ -1848,7 +1848,7 @@ static int sfp_probe(struct platform_device *pdev)
> int ret;
>
> ret = acpi_node_get_property_reference(fw, "i2c-bus", 0, &args);
> - if (ACPI_FAILURE(ret) || !is_acpi_device_node(args.fwnode)) {
> + if (ret || !is_acpi_device_node(args.fwnode)) {
> dev_err(&pdev->dev, "missing 'i2c-bus' property\n");
> return -ENODEV;
If "ret" is a Linux error code, should we print its value when reporting
the error so we know why the failure occurred, and propagate the error
code?
> }
> --
> 2.20.1
>
>
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH net] net: phy: sfp: clean up a condition
@ 2019-06-13 18:00 ` Russell King - ARM Linux admin
0 siblings, 0 replies; 12+ messages in thread
From: Russell King - ARM Linux admin @ 2019-06-13 18:00 UTC (permalink / raw)
To: Dan Carpenter
Cc: Ruslan Babayev, Andrew Lunn, Florian Fainelli, Heiner Kallweit,
David S. Miller, netdev, kernel-janitors
On Thu, Jun 13, 2019 at 09:51:02AM +0300, Dan Carpenter wrote:
> The acpi_node_get_property_reference() doesn't return ACPI error codes,
> it just returns regular negative kernel error codes. This patch doesn't
> affect run time, it's just a clean up.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> drivers/net/phy/sfp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/phy/sfp.c b/drivers/net/phy/sfp.c
> index a991c80e6567..8a99307c1c39 100644
> --- a/drivers/net/phy/sfp.c
> +++ b/drivers/net/phy/sfp.c
> @@ -1848,7 +1848,7 @@ static int sfp_probe(struct platform_device *pdev)
> int ret;
>
> ret = acpi_node_get_property_reference(fw, "i2c-bus", 0, &args);
> - if (ACPI_FAILURE(ret) || !is_acpi_device_node(args.fwnode)) {
> + if (ret || !is_acpi_device_node(args.fwnode)) {
> dev_err(&pdev->dev, "missing 'i2c-bus' property\n");
> return -ENODEV;
If "ret" is a Linux error code, should we print its value when reporting
the error so we know why the failure occurred, and propagate the error
code?
> }
> --
> 2.20.1
>
>
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH net] net: phy: sfp: clean up a condition
2019-06-13 18:00 ` Russell King - ARM Linux admin
@ 2019-06-14 4:43 ` Dan Carpenter
-1 siblings, 0 replies; 12+ messages in thread
From: Dan Carpenter @ 2019-06-14 4:43 UTC (permalink / raw)
To: Russell King - ARM Linux admin
Cc: Ruslan Babayev, Andrew Lunn, Florian Fainelli, Heiner Kallweit,
David S. Miller, netdev, kernel-janitors
On Thu, Jun 13, 2019 at 07:00:16PM +0100, Russell King - ARM Linux admin wrote:
> On Thu, Jun 13, 2019 at 09:51:02AM +0300, Dan Carpenter wrote:
> > The acpi_node_get_property_reference() doesn't return ACPI error codes,
> > it just returns regular negative kernel error codes. This patch doesn't
> > affect run time, it's just a clean up.
> >
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> > ---
> > drivers/net/phy/sfp.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/phy/sfp.c b/drivers/net/phy/sfp.c
> > index a991c80e6567..8a99307c1c39 100644
> > --- a/drivers/net/phy/sfp.c
> > +++ b/drivers/net/phy/sfp.c
> > @@ -1848,7 +1848,7 @@ static int sfp_probe(struct platform_device *pdev)
> > int ret;
> >
> > ret = acpi_node_get_property_reference(fw, "i2c-bus", 0, &args);
> > - if (ACPI_FAILURE(ret) || !is_acpi_device_node(args.fwnode)) {
> > + if (ret || !is_acpi_device_node(args.fwnode)) {
> > dev_err(&pdev->dev, "missing 'i2c-bus' property\n");
> > return -ENODEV;
>
> If "ret" is a Linux error code, should we print its value when reporting
> the error so we know why the failure occurred, and propagate the error
> code?
We can't propagate the error code because we might have failed because
acpi_node_get_property_reference() succeeded but it's not a device node.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH net] net: phy: sfp: clean up a condition
@ 2019-06-14 4:43 ` Dan Carpenter
0 siblings, 0 replies; 12+ messages in thread
From: Dan Carpenter @ 2019-06-14 4:43 UTC (permalink / raw)
To: Russell King - ARM Linux admin
Cc: Ruslan Babayev, Andrew Lunn, Florian Fainelli, Heiner Kallweit,
David S. Miller, netdev, kernel-janitors
On Thu, Jun 13, 2019 at 07:00:16PM +0100, Russell King - ARM Linux admin wrote:
> On Thu, Jun 13, 2019 at 09:51:02AM +0300, Dan Carpenter wrote:
> > The acpi_node_get_property_reference() doesn't return ACPI error codes,
> > it just returns regular negative kernel error codes. This patch doesn't
> > affect run time, it's just a clean up.
> >
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> > ---
> > drivers/net/phy/sfp.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/phy/sfp.c b/drivers/net/phy/sfp.c
> > index a991c80e6567..8a99307c1c39 100644
> > --- a/drivers/net/phy/sfp.c
> > +++ b/drivers/net/phy/sfp.c
> > @@ -1848,7 +1848,7 @@ static int sfp_probe(struct platform_device *pdev)
> > int ret;
> >
> > ret = acpi_node_get_property_reference(fw, "i2c-bus", 0, &args);
> > - if (ACPI_FAILURE(ret) || !is_acpi_device_node(args.fwnode)) {
> > + if (ret || !is_acpi_device_node(args.fwnode)) {
> > dev_err(&pdev->dev, "missing 'i2c-bus' property\n");
> > return -ENODEV;
>
> If "ret" is a Linux error code, should we print its value when reporting
> the error so we know why the failure occurred, and propagate the error
> code?
We can't propagate the error code because we might have failed because
acpi_node_get_property_reference() succeeded but it's not a device node.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH net] net: phy: sfp: clean up a condition
2019-06-13 6:51 ` Dan Carpenter
@ 2019-06-15 2:21 ` David Miller
-1 siblings, 0 replies; 12+ messages in thread
From: David Miller @ 2019-06-15 2:21 UTC (permalink / raw)
To: dan.carpenter
Cc: linux, ruslan, andrew, f.fainelli, hkallweit1, netdev,
kernel-janitors
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Thu, 13 Jun 2019 09:51:02 +0300
> The acpi_node_get_property_reference() doesn't return ACPI error codes,
> it just returns regular negative kernel error codes. This patch doesn't
> affect run time, it's just a clean up.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied to net-next.
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH net] net: phy: sfp: clean up a condition
@ 2019-06-15 2:21 ` David Miller
0 siblings, 0 replies; 12+ messages in thread
From: David Miller @ 2019-06-15 2:21 UTC (permalink / raw)
To: dan.carpenter
Cc: linux, ruslan, andrew, f.fainelli, hkallweit1, netdev,
kernel-janitors
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Thu, 13 Jun 2019 09:51:02 +0300
> The acpi_node_get_property_reference() doesn't return ACPI error codes,
> it just returns regular negative kernel error codes. This patch doesn't
> affect run time, it's just a clean up.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied to net-next.
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH net] net: phy: sfp: clean up a condition
2019-06-15 2:21 ` David Miller
@ 2019-06-15 7:09 ` Dan Carpenter
-1 siblings, 0 replies; 12+ messages in thread
From: Dan Carpenter @ 2019-06-15 7:09 UTC (permalink / raw)
To: David Miller
Cc: linux, ruslan, andrew, f.fainelli, hkallweit1, netdev,
kernel-janitors
On Fri, Jun 14, 2019 at 07:21:48PM -0700, David Miller wrote:
> From: Dan Carpenter <dan.carpenter@oracle.com>
> Date: Thu, 13 Jun 2019 09:51:02 +0300
>
> > The acpi_node_get_property_reference() doesn't return ACPI error codes,
> > it just returns regular negative kernel error codes. This patch doesn't
> > affect run time, it's just a clean up.
> >
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> Applied to net-next.
I meant to say net-next but I made a typo. :/
regards,
dan carpenter
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH net] net: phy: sfp: clean up a condition
@ 2019-06-15 7:09 ` Dan Carpenter
0 siblings, 0 replies; 12+ messages in thread
From: Dan Carpenter @ 2019-06-15 7:09 UTC (permalink / raw)
To: David Miller
Cc: linux, ruslan, andrew, f.fainelli, hkallweit1, netdev,
kernel-janitors
On Fri, Jun 14, 2019 at 07:21:48PM -0700, David Miller wrote:
> From: Dan Carpenter <dan.carpenter@oracle.com>
> Date: Thu, 13 Jun 2019 09:51:02 +0300
>
> > The acpi_node_get_property_reference() doesn't return ACPI error codes,
> > it just returns regular negative kernel error codes. This patch doesn't
> > affect run time, it's just a clean up.
> >
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> Applied to net-next.
I meant to say net-next but I made a typo. :/
regards,
dan carpenter
^ permalink raw reply [flat|nested] 12+ messages in thread