From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Darren Hart <dvhart@infradead.org>,
Andy Shevchenko <andy@infradead.org>,
"Lee, Chun-Yi" <jlee@suse.com>,
Platform Driver <platform-driver-x86@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/8] platform: x86: acer-wmi: no need to check return value of debugfs_create functions
Date: Fri, 14 Jun 2019 08:53:39 +0200 [thread overview]
Message-ID: <20190614065339.GB21447@kroah.com> (raw)
In-Reply-To: <CAHp75VeQy9o6tHtqKEE3o9ijBE4c11cWcc00+RqCj+P1FOky1w@mail.gmail.com>
On Fri, Jun 14, 2019 at 09:48:04AM +0300, Andy Shevchenko wrote:
> On Wed, Jun 12, 2019 at 3:13 PM Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
> >
> > When calling debugfs functions, there is no need to ever check the
> > return value. The function can work or not, but the code logic should
> > never do something different based on this.
> >
> > Also, because there is no need to save the file dentry, remove the
> > variable that was saving it and just recursively delete the whole
> > directory.
> >
>
> Through which tree you want to proceed this?
What ever is easier for you, I can take it through mine, as I have a lot
of other patches like this queued up already, or it can go through
yours.
thanks,
greg k-h
next prev parent reply other threads:[~2019-06-14 6:53 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-12 12:12 [PATCH 1/8] platform: x86: acer-wmi: no need to check return value of debugfs_create functions Greg Kroah-Hartman
2019-06-12 12:12 ` [PATCH 2/8] platform: x86: asus-wmi: " Greg Kroah-Hartman
2019-06-12 12:12 ` [PATCH 3/8] platform: x86: dell-laptop: " Greg Kroah-Hartman
2019-06-12 12:21 ` Pali Rohár
2019-06-12 12:36 ` Greg Kroah-Hartman
2019-06-12 12:44 ` Pali Rohár
2019-06-12 12:47 ` Greg Kroah-Hartman
2019-06-12 12:12 ` [PATCH 4/8] platform: x86: ideapad-laptop: " Greg Kroah-Hartman
2019-06-12 12:12 ` [PATCH 5/8] platform: x86: samsung-laptop: " Greg Kroah-Hartman
2019-06-12 12:12 ` [PATCH 6/8] platform: x86: pmc_atom: " Greg Kroah-Hartman
2019-06-12 12:12 ` [PATCH 7/8] platform: x86: intel_pmc: " Greg Kroah-Hartman
2019-06-12 12:12 ` [PATCH 8/8] platform: x86: intel_telemetry: " Greg Kroah-Hartman
2019-06-14 6:48 ` [PATCH 1/8] platform: x86: acer-wmi: " Andy Shevchenko
2019-06-14 6:53 ` Greg Kroah-Hartman [this message]
2019-06-17 12:32 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190614065339.GB21447@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=andy.shevchenko@gmail.com \
--cc=andy@infradead.org \
--cc=dvhart@infradead.org \
--cc=jlee@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.