From: Thierry Reding <treding@nvidia.com>
To: Nathan Huckleberry <nhuck@google.com>
Cc: mathias.nyman@intel.com, gregkh@linuxfoundation.org,
thierry.reding@gmail.com, jonathanh@nvidia.com,
linux-usb@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com
Subject: Re: Cleanup of -Wunused-const-variable in drivers/usb/host/xhci-tegra.c
Date: Fri, 14 Jun 2019 11:09:27 +0200 [thread overview]
Message-ID: <20190614090926.GB14954@ulmo> (raw)
In-Reply-To: <CAJkfWY4nKwyPDh=MuCURst2SZceceeR2v3qrT9UY=VbvLnEmFg@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 687 bytes --]
On Thu, Jun 13, 2019 at 11:38:38AM -0700, Nathan Huckleberry wrote:
> Hey all,
>
> I'm looking into cleaning up ignored warnings in the kernel so we can
> remove compiler flags to ignore warnings.
>
> There's an unused variable ('mbox_cmd_name') in xhci-tegra.c. Looks
> like it was intended for logging or debugging, but never used. Just
> wanted to reach out to ask the best steps for cleaning this up.
>
> If the variable is no longer needed I'd like to send a patch to remove it.
>
> https://github.com/ClangBuiltLinux/linux/issues/533
Feel free to send that patch. If we ever need this debug information
again we can easily add it back by reverting.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Thierry Reding <treding@nvidia.com>
To: Nathan Huckleberry <nhuck@google.com>
Cc: <mathias.nyman@intel.com>, <gregkh@linuxfoundation.org>,
<thierry.reding@gmail.com>, <jonathanh@nvidia.com>,
<linux-usb@vger.kernel.org>, <linux-tegra@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
<clang-built-linux@googlegroups.com>
Subject: Re: Cleanup of -Wunused-const-variable in drivers/usb/host/xhci-tegra.c
Date: Fri, 14 Jun 2019 11:09:27 +0200 [thread overview]
Message-ID: <20190614090926.GB14954@ulmo> (raw)
In-Reply-To: <CAJkfWY4nKwyPDh=MuCURst2SZceceeR2v3qrT9UY=VbvLnEmFg@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 687 bytes --]
On Thu, Jun 13, 2019 at 11:38:38AM -0700, Nathan Huckleberry wrote:
> Hey all,
>
> I'm looking into cleaning up ignored warnings in the kernel so we can
> remove compiler flags to ignore warnings.
>
> There's an unused variable ('mbox_cmd_name') in xhci-tegra.c. Looks
> like it was intended for logging or debugging, but never used. Just
> wanted to reach out to ask the best steps for cleaning this up.
>
> If the variable is no longer needed I'd like to send a patch to remove it.
>
> https://github.com/ClangBuiltLinux/linux/issues/533
Feel free to send that patch. If we ever need this debug information
again we can easily add it back by reverting.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2019-06-14 9:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-13 18:38 Cleanup of -Wunused-const-variable in drivers/usb/host/xhci-tegra.c Nathan Huckleberry
2019-06-13 18:44 ` Greg KH
2019-06-13 18:58 ` [PATCH] usb: host: xhci-tegra: Fix Wunused-const-variable Nathan Huckleberry
2019-06-14 9:24 ` Thierry Reding
2019-06-14 9:09 ` Thierry Reding [this message]
2019-06-14 9:09 ` Cleanup of -Wunused-const-variable in drivers/usb/host/xhci-tegra.c Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190614090926.GB14954@ulmo \
--to=treding@nvidia.com \
--cc=clang-built-linux@googlegroups.com \
--cc=gregkh@linuxfoundation.org \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=nhuck@google.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.