All of lore.kernel.org
 help / color / mirror / Atom feed
* [Virtio-fs] Adding notifications vq to the virtio-fs device
@ 2019-06-10 16:09 Stefan Hajnoczi
  2019-06-14 17:24 ` Dr. David Alan Gilbert
  0 siblings, 1 reply; 2+ messages in thread
From: Stefan Hajnoczi @ 2019-06-10 16:09 UTC (permalink / raw)
  To: vgoyal; +Cc: virtio-fs

[-- Attachment #1: Type: text/plain, Size: 802 bytes --]

Hi Vivek,
There is discussion of adding the notifications vq to the virtio-fs
device so that FUSE Notification messages are possible.  This was
previously discussed on the VIRTIO mailing lists here:
https://lists.oasis-open.org/archives/virtio-dev/201902/msg00074.html

The main issue is how to handle the case where the device wishes to
raise notifications but the driver has not supplied enough buffers.

FUSE requires reliable notification delivery.  We cannot drop
notifications.

The mechanism will have to support reliable delivery.  For example, the
device may need to pause further operation until the driver makes
buffers available again.  But this could lead to DoS or deadlocks, so
care is needed!

I hope this link is useful in restarting the discussion about the
notifications vq.

Stefan

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [Virtio-fs] Adding notifications vq to the virtio-fs device
  2019-06-10 16:09 [Virtio-fs] Adding notifications vq to the virtio-fs device Stefan Hajnoczi
@ 2019-06-14 17:24 ` Dr. David Alan Gilbert
  0 siblings, 0 replies; 2+ messages in thread
From: Dr. David Alan Gilbert @ 2019-06-14 17:24 UTC (permalink / raw)
  To: Stefan Hajnoczi; +Cc: virtio-fs, vgoyal

* Stefan Hajnoczi (stefanha@redhat.com) wrote:
> Hi Vivek,
> There is discussion of adding the notifications vq to the virtio-fs
> device so that FUSE Notification messages are possible.  This was
> previously discussed on the VIRTIO mailing lists here:
> https://lists.oasis-open.org/archives/virtio-dev/201902/msg00074.html
> 
> The main issue is how to handle the case where the device wishes to
> raise notifications but the driver has not supplied enough buffers.
> 
> FUSE requires reliable notification delivery.  We cannot drop
> notifications.
> 
> The mechanism will have to support reliable delivery.  For example, the
> device may need to pause further operation until the driver makes
> buffers available again.  But this could lead to DoS or deadlocks, so
> care is needed!
> 
> I hope this link is useful in restarting the discussion about the
> notifications vq.

In the case we were recently discussing, notification of lock
availability, that's not necessarily a problem; if there's no
space on the notification queue then we stop notifying about
locks until there is some space.

Dave

> Stefan


--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-06-14 17:24 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-06-10 16:09 [Virtio-fs] Adding notifications vq to the virtio-fs device Stefan Hajnoczi
2019-06-14 17:24 ` Dr. David Alan Gilbert

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.