From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: Liu Bo <bo.liu@linux.alibaba.com>
Cc: virtio-fs@redhat.com
Subject: Re: [Virtio-fs] [PATCH] virtiofsd: fix typo in error message in fv_queue_thread
Date: Fri, 14 Jun 2019 19:58:25 +0100 [thread overview]
Message-ID: <20190614185825.GM2785@work-vm> (raw)
In-Reply-To: <1560534980-37259-1-git-send-email-bo.liu@linux.alibaba.com>
* Liu Bo (bo.liu@linux.alibaba.com) wrote:
> It's misleading that pf[0].revents is printed when there is something
> wrong with pf[1].revents.
>
> Signed-off-by: Liu Bo <bo.liu@linux.alibaba.com>
Ah well spotted; that's a copy-paste problem on my half.
For this, I've just fixed up the original patch.
Dave
> ---
> contrib/virtiofsd/fuse_virtio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/contrib/virtiofsd/fuse_virtio.c b/contrib/virtiofsd/fuse_virtio.c
> index ed6ba57..bec4105 100644
> --- a/contrib/virtiofsd/fuse_virtio.c
> +++ b/contrib/virtiofsd/fuse_virtio.c
> @@ -472,7 +472,7 @@ static void *fv_queue_thread(void *opaque)
> }
> if (pf[1].revents & (POLLERR | POLLHUP | POLLNVAL)) {
> fprintf(stderr, "%s: Unexpected poll revents %x Queue %d killfd\n",
> - __func__, pf[0].revents, qi->qidx);
> + __func__, pf[1].revents, qi->qidx);
> break;
> }
> if (pf[1].revents) {
> --
> 1.8.3.1
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
next prev parent reply other threads:[~2019-06-14 18:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-14 17:56 [Virtio-fs] [PATCH] virtiofsd: fix typo in error message in fv_queue_thread Liu Bo
2019-06-14 18:58 ` Dr. David Alan Gilbert [this message]
2019-06-14 19:08 ` Liu Bo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190614185825.GM2785@work-vm \
--to=dgilbert@redhat.com \
--cc=bo.liu@linux.alibaba.com \
--cc=virtio-fs@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.