* [Virtio-fs] [PATCH] virtiofsd: fix typo in error message in fv_queue_thread
@ 2019-06-14 17:56 Liu Bo
2019-06-14 18:58 ` Dr. David Alan Gilbert
0 siblings, 1 reply; 3+ messages in thread
From: Liu Bo @ 2019-06-14 17:56 UTC (permalink / raw)
To: virtio-fs
It's misleading that pf[0].revents is printed when there is something
wrong with pf[1].revents.
Signed-off-by: Liu Bo <bo.liu@linux.alibaba.com>
---
contrib/virtiofsd/fuse_virtio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/contrib/virtiofsd/fuse_virtio.c b/contrib/virtiofsd/fuse_virtio.c
index ed6ba57..bec4105 100644
--- a/contrib/virtiofsd/fuse_virtio.c
+++ b/contrib/virtiofsd/fuse_virtio.c
@@ -472,7 +472,7 @@ static void *fv_queue_thread(void *opaque)
}
if (pf[1].revents & (POLLERR | POLLHUP | POLLNVAL)) {
fprintf(stderr, "%s: Unexpected poll revents %x Queue %d killfd\n",
- __func__, pf[0].revents, qi->qidx);
+ __func__, pf[1].revents, qi->qidx);
break;
}
if (pf[1].revents) {
--
1.8.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Virtio-fs] [PATCH] virtiofsd: fix typo in error message in fv_queue_thread
2019-06-14 17:56 [Virtio-fs] [PATCH] virtiofsd: fix typo in error message in fv_queue_thread Liu Bo
@ 2019-06-14 18:58 ` Dr. David Alan Gilbert
2019-06-14 19:08 ` Liu Bo
0 siblings, 1 reply; 3+ messages in thread
From: Dr. David Alan Gilbert @ 2019-06-14 18:58 UTC (permalink / raw)
To: Liu Bo; +Cc: virtio-fs
* Liu Bo (bo.liu@linux.alibaba.com) wrote:
> It's misleading that pf[0].revents is printed when there is something
> wrong with pf[1].revents.
>
> Signed-off-by: Liu Bo <bo.liu@linux.alibaba.com>
Ah well spotted; that's a copy-paste problem on my half.
For this, I've just fixed up the original patch.
Dave
> ---
> contrib/virtiofsd/fuse_virtio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/contrib/virtiofsd/fuse_virtio.c b/contrib/virtiofsd/fuse_virtio.c
> index ed6ba57..bec4105 100644
> --- a/contrib/virtiofsd/fuse_virtio.c
> +++ b/contrib/virtiofsd/fuse_virtio.c
> @@ -472,7 +472,7 @@ static void *fv_queue_thread(void *opaque)
> }
> if (pf[1].revents & (POLLERR | POLLHUP | POLLNVAL)) {
> fprintf(stderr, "%s: Unexpected poll revents %x Queue %d killfd\n",
> - __func__, pf[0].revents, qi->qidx);
> + __func__, pf[1].revents, qi->qidx);
> break;
> }
> if (pf[1].revents) {
> --
> 1.8.3.1
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Virtio-fs] [PATCH] virtiofsd: fix typo in error message in fv_queue_thread
2019-06-14 18:58 ` Dr. David Alan Gilbert
@ 2019-06-14 19:08 ` Liu Bo
0 siblings, 0 replies; 3+ messages in thread
From: Liu Bo @ 2019-06-14 19:08 UTC (permalink / raw)
To: Dr. David Alan Gilbert; +Cc: virtio-fs
On Fri, Jun 14, 2019 at 07:58:25PM +0100, Dr. David Alan Gilbert wrote:
> * Liu Bo (bo.liu@linux.alibaba.com) wrote:
> > It's misleading that pf[0].revents is printed when there is something
> > wrong with pf[1].revents.
> >
> > Signed-off-by: Liu Bo <bo.liu@linux.alibaba.com>
>
> Ah well spotted; that's a copy-paste problem on my half.
>
> For this, I've just fixed up the original patch.
Sure, that's fine.
thanks,
-liubo
>
> Dave
>
> > ---
> > contrib/virtiofsd/fuse_virtio.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/contrib/virtiofsd/fuse_virtio.c b/contrib/virtiofsd/fuse_virtio.c
> > index ed6ba57..bec4105 100644
> > --- a/contrib/virtiofsd/fuse_virtio.c
> > +++ b/contrib/virtiofsd/fuse_virtio.c
> > @@ -472,7 +472,7 @@ static void *fv_queue_thread(void *opaque)
> > }
> > if (pf[1].revents & (POLLERR | POLLHUP | POLLNVAL)) {
> > fprintf(stderr, "%s: Unexpected poll revents %x Queue %d killfd\n",
> > - __func__, pf[0].revents, qi->qidx);
> > + __func__, pf[1].revents, qi->qidx);
> > break;
> > }
> > if (pf[1].revents) {
> > --
> > 1.8.3.1
> >
> --
> Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-06-14 19:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-06-14 17:56 [Virtio-fs] [PATCH] virtiofsd: fix typo in error message in fv_queue_thread Liu Bo
2019-06-14 18:58 ` Dr. David Alan Gilbert
2019-06-14 19:08 ` Liu Bo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.