All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wolfram Sang <wsa@the-dreams.de>
To: Fabrice Gasnier <fabrice.gasnier@st.com>
Cc: pierre-yves.mordret@st.com, marc.w.gonzalez@free.fr,
	fabien.dessenne@st.com, mcoquelin.stm32@gmail.com,
	alexandre.torgue@st.com, linux-i2c@vger.kernel.org,
	linux-stm32@st-md-mailman.stormreply.com,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] i2c: i2c-stm32f7: fix the get_irq error cases
Date: Fri, 14 Jun 2019 22:53:22 +0200	[thread overview]
Message-ID: <20190614205322.GA17899@ninjato> (raw)
In-Reply-To: <1558020594-1498-1-git-send-email-fabrice.gasnier@st.com>

[-- Attachment #1: Type: text/plain, Size: 374 bytes --]

Hi Fabrice,

> +		return irq_event ? irq_event : -ENODEV;

Maybe -ENOENT instead of -ENODEV? I mean you have a dev_err there, so
the driver core should probably also complain?

You could also shorten the ternary operator to:

	return irq_event ? : -E<whatyouprefer>;

However, both are minor nits. If you prefer to keep the patch as is,
fine with me.

Regards,

   Wolfram


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Wolfram Sang <wsa@the-dreams.de>
To: Fabrice Gasnier <fabrice.gasnier@st.com>
Cc: alexandre.torgue@st.com, pierre-yves.mordret@st.com,
	marc.w.gonzalez@free.fr, linux-kernel@vger.kernel.org,
	fabien.dessenne@st.com, linux-i2c@vger.kernel.org,
	mcoquelin.stm32@gmail.com,
	linux-stm32@st-md-mailman.stormreply.com,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2] i2c: i2c-stm32f7: fix the get_irq error cases
Date: Fri, 14 Jun 2019 22:53:22 +0200	[thread overview]
Message-ID: <20190614205322.GA17899@ninjato> (raw)
In-Reply-To: <1558020594-1498-1-git-send-email-fabrice.gasnier@st.com>


[-- Attachment #1.1: Type: text/plain, Size: 374 bytes --]

Hi Fabrice,

> +		return irq_event ? irq_event : -ENODEV;

Maybe -ENOENT instead of -ENODEV? I mean you have a dev_err there, so
the driver core should probably also complain?

You could also shorten the ternary operator to:

	return irq_event ? : -E<whatyouprefer>;

However, both are minor nits. If you prefer to keep the patch as is,
fine with me.

Regards,

   Wolfram


[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2019-06-14 20:53 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-16 15:29 [PATCH v2] i2c: i2c-stm32f7: fix the get_irq error cases Fabrice Gasnier
2019-05-16 15:29 ` Fabrice Gasnier
2019-05-16 15:29 ` Fabrice Gasnier
2019-06-12 12:29 ` Fabrice Gasnier
2019-06-12 12:29   ` Fabrice Gasnier
2019-06-12 12:29   ` Fabrice Gasnier
2019-06-14 20:53 ` Wolfram Sang [this message]
2019-06-14 20:53   ` Wolfram Sang
2019-06-17  7:54   ` Fabrice Gasnier
2019-06-17  7:54     ` Fabrice Gasnier
2019-06-17  7:54     ` Fabrice Gasnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190614205322.GA17899@ninjato \
    --to=wsa@the-dreams.de \
    --cc=alexandre.torgue@st.com \
    --cc=fabien.dessenne@st.com \
    --cc=fabrice.gasnier@st.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-stm32@st-md-mailman.stormreply.com \
    --cc=marc.w.gonzalez@free.fr \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=pierre-yves.mordret@st.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.