All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yoshinori Sato <ysato@users.sourceforge.jp>
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, imammedo@redhat.com,
	Richard Henderson <richard.henderson@linaro.org>,
	Yoshinori Sato <ysato@users.sourceforge.jp>,
	philmd@redhat.com
Subject: [Qemu-devel] [PATCH v21 10/21] target/rx: Use prt_ldmi for XCHG_mr disassembly
Date: Tue, 18 Jun 2019 23:10:58 +0900	[thread overview]
Message-ID: <20190618141118.52955-20-ysato@users.sourceforge.jp> (raw)
In-Reply-To: <20190618141118.52955-1-ysato@users.sourceforge.jp>

From: Richard Henderson <richard.henderson@linaro.org>

Note that the ld == 3 case handled by prt_ldmi is decoded as
XCHG_rr and cannot appear here.

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Yoshinori Sato <ysato@users.sourceforge.jp>
Signed-off-by: Yoshinori Sato <ysato@users.sourceforge.jp>
Message-Id: <20190607091116.49044-21-ysato@users.sourceforge.jp>
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
 target/rx/disas.c | 8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)

diff --git a/target/rx/disas.c b/target/rx/disas.c
index 515b365528..db10385fd0 100644
--- a/target/rx/disas.c
+++ b/target/rx/disas.c
@@ -366,13 +366,7 @@ static bool trans_XCHG_rr(DisasContext *ctx, arg_XCHG_rr *a)
 /* xchg dsp[rs].<mi>,rd */
 static bool trans_XCHG_mr(DisasContext *ctx, arg_XCHG_mr *a)
 {
-    static const char msize[][4] = {
-        "b", "w", "l", "ub", "uw",
-    };
-    char dsp[8];
-
-    rx_index_addr(ctx, dsp, a->ld, a->mi);
-    prt("xchg\t%s[r%d].%s, r%d", dsp, a->rs, msize[a->mi], a->rd);
+    prt_ldmi(ctx, "xchg", a->ld, a->mi, a->rs, a->rd);
     return true;
 }
 
-- 
2.11.0



  parent reply	other threads:[~2019-06-18 14:30 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-18 14:10 [Qemu-devel] [PATCH v21 00/21] Add RX archtecture support Yoshinori Sato
2019-06-18 14:10 ` [Qemu-devel] [PATCH v21 01/21] MAINTAINERS: Add RX Yoshinori Sato
2019-06-18 14:10 ` [Qemu-devel] [PATCH v21 02/21] qemu/bitops.h: Add extract8 and extract16 Yoshinori Sato
2019-06-18 14:10 ` [Qemu-devel] [PATCH v21 02/21] target/rx: TCG translation Yoshinori Sato
2019-06-18 14:10 ` [Qemu-devel] [PATCH v21 03/21] hw/registerfields.h: Add 8bit and 16bit register macros Yoshinori Sato
2019-06-18 14:10 ` [Qemu-devel] [PATCH v21 03/21] target/rx: TCG helper Yoshinori Sato
2019-06-18 14:10 ` [Qemu-devel] [PATCH v21 04/21] target/rx: CPU definition Yoshinori Sato
2019-06-18 14:10 ` [Qemu-devel] [PATCH v21 04/21] target/rx: TCG translation Yoshinori Sato
2019-06-18 14:10 ` [Qemu-devel] [PATCH v21 05/21] target/rx: RX disassembler Yoshinori Sato
2019-06-18 14:10 ` [Qemu-devel] [PATCH v21 05/21] target/rx: TCG helper Yoshinori Sato
2019-06-18 14:10 ` [Qemu-devel] [PATCH v21 06/21] target/rx: CPU definition Yoshinori Sato
2019-06-18 14:10 ` [Qemu-devel] [PATCH v21 06/21] target/rx: Disassemble rx_index_addr into a string Yoshinori Sato
2019-06-18 14:10 ` [Qemu-devel] [PATCH v21 07/21] target/rx: RX disassembler Yoshinori Sato
2019-06-18 14:10 ` [Qemu-devel] [PATCH v21 07/21] target/rx: Replace operand with prt_ldmi in disassembler Yoshinori Sato
2019-06-18 14:10 ` [Qemu-devel] [PATCH v21 08/21] target/rx: Disassemble rx_index_addr into a string Yoshinori Sato
2019-06-18 14:10 ` [Qemu-devel] [PATCH v21 08/21] target/rx: Use prt_ldmi for XCHG_mr disassembly Yoshinori Sato
2019-06-18 14:10 ` [Qemu-devel] [PATCH v21 09/21] target/rx: Emit all disassembly in one prt() Yoshinori Sato
2019-06-18 14:10 ` [Qemu-devel] [PATCH v21 09/21] target/rx: Replace operand with prt_ldmi in disassembler Yoshinori Sato
2019-06-18 14:10 ` [Qemu-devel] [PATCH v21 10/21] target/rx: Collect all bytes during disassembly Yoshinori Sato
2019-06-18 14:10 ` Yoshinori Sato [this message]
2019-06-18 14:10 ` [Qemu-devel] [PATCH v21 11/21] target/rx: Dump bytes for each insn " Yoshinori Sato
2019-06-18 14:11 ` [Qemu-devel] [PATCH v21 11/21] target/rx: Emit all disassembly in one prt() Yoshinori Sato
2019-06-18 14:11 ` [Qemu-devel] [PATCH v21 12/21] hw/intc: RX62N interrupt controller (ICUa) Yoshinori Sato
2019-06-18 14:11 ` [Qemu-devel] [PATCH v21 12/21] target/rx: Collect all bytes during disassembly Yoshinori Sato
2019-06-18 14:11 ` [Qemu-devel] [PATCH v21 13/21] hw/timer: RX62N internal timer modules Yoshinori Sato
2019-06-18 14:11 ` [Qemu-devel] [PATCH v21 13/21] target/rx: Dump bytes for each insn during disassembly Yoshinori Sato
2019-06-18 14:11 ` [Qemu-devel] [PATCH v21 14/21] hw/char: RX62N serial communication interface (SCI) Yoshinori Sato
2019-06-18 14:11 ` [Qemu-devel] [PATCH v21 14/21] hw/intc: RX62N interrupt controller (ICUa) Yoshinori Sato
2019-06-18 14:11 ` [Qemu-devel] [PATCH v21 15/21] hw/rx: RX Target hardware definition Yoshinori Sato
2019-06-18 14:11 ` [Qemu-devel] [PATCH v21 15/21] hw/timer: RX62N internal timer modules Yoshinori Sato
2019-06-18 14:11 ` [Qemu-devel] [PATCH v21 16/21] hw/char: RX62N serial communication interface (SCI) Yoshinori Sato
2019-06-18 14:11 ` [Qemu-devel] [PATCH v21 16/21] hw/rx: Honor -accel qtest Yoshinori Sato
2019-06-18 14:11 ` [Qemu-devel] [PATCH v21 17/21] hw/rx: RX Target hardware definition Yoshinori Sato
2019-06-18 14:11 ` [Qemu-devel] [PATCH v21 17/21] hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core Yoshinori Sato
2019-06-18 14:11 ` [Qemu-devel] [PATCH v21 18/21] hw/rx: Honor -accel qtest Yoshinori Sato
2019-06-18 14:11 ` [Qemu-devel] [PATCH v21 18/21] qemu/bitops.h: Add extract8 and extract16 Yoshinori Sato
2019-06-18 14:11 ` [Qemu-devel] [PATCH v21 19/21] hw/registerfields.h: Add 8bit and 16bit register macros Yoshinori Sato
2019-06-18 14:11 ` [Qemu-devel] [PATCH v21 19/21] hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core Yoshinori Sato
2019-06-18 14:11 ` [Qemu-devel] [PATCH v21 20/21] Add rx-softmmu Yoshinori Sato
2019-06-18 14:11 ` [Qemu-devel] [PATCH v21 21/21] BootLinuxConsoleTest: Test the RX-Virt machine Yoshinori Sato
2019-06-18 14:38 ` [Qemu-devel] [PATCH v21 00/21] Add RX archtecture support Yoshinori Sato

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190618141118.52955-20-ysato@users.sourceforge.jp \
    --to=ysato@users.sourceforge.jp \
    --cc=imammedo@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=philmd@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.