From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Marc Gonzalez <marc.w.gonzalez@free.fr>
Cc: Andy Gross <agross@kernel.org>, Rob Herring <robh+dt@kernel.org>,
MSM <linux-arm-msm@vger.kernel.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] arm64: dts: qcom: msm8996: Rename smmu nodes
Date: Tue, 18 Jun 2019 13:04:24 -0700 [thread overview]
Message-ID: <20190618200424.GH4814@minitux> (raw)
In-Reply-To: <fbe71878-a129-1b11-d978-48a99b292086@free.fr>
On Tue 18 Jun 00:39 PDT 2019, Marc Gonzalez wrote:
> On 18/06/2019 07:24, Bjorn Andersson wrote:
>
> > Node names shouldn't include "qcom," and should whenever possible use
> > a generic identifier. Resolve this by renaming the smmu nodes "iommu".
>
> You mention "qcom" here, but the prefix you changed is "arm"
> /me confused ^_^
>
Thanks for proof reading my patches Marc
I'll respin this.
Regards,
Bjorn
>
> > arch/arm64/boot/dts/qcom/msm8996.dtsi | 8 ++++----
> > 1 file changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi
> > index 2ecd9d775d61..c934e00434c7 100644
> > --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi
> > @@ -1163,7 +1163,7 @@
> > };
> > };
> >
> > - vfe_smmu: arm,smmu@da0000 {
> > + vfe_smmu: iommu@da0000 {
> > compatible = "qcom,msm8996-smmu-v2", "qcom,smmu-v2";
> > reg = <0xda0000 0x10000>;
> >
> > @@ -1314,7 +1314,7 @@
> > };
> > };
> >
> > - adreno_smmu: arm,smmu@b40000 {
> > + adreno_smmu: iommu@b40000 {
> > compatible = "qcom,msm8996-smmu-v2", "qcom,smmu-v2";
> > reg = <0xb40000 0x10000>;
> >
> > @@ -1331,7 +1331,7 @@
> > power-domains = <&mmcc GPU_GDSC>;
> > };
> >
> > - mdp_smmu: arm,smmu@d00000 {
> > + mdp_smmu: iommu@d00000 {
> > compatible = "qcom,msm8996-smmu-v2", "qcom,smmu-v2";
> > reg = <0xd00000 0x10000>;
> >
> > @@ -1347,7 +1347,7 @@
> > power-domains = <&mmcc MDSS_GDSC>;
> > };
> >
> > - lpass_q6_smmu: arm,smmu-lpass_q6@1600000 {
> > + lpass_q6_smmu: iommu@1600000 {
> > compatible = "qcom,msm8996-smmu-v2", "qcom,smmu-v2";
> > reg = <0x1600000 0x20000>;
> > #iommu-cells = <1>;
> >
WARNING: multiple messages have this Message-ID (diff)
From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Marc Gonzalez <marc.w.gonzalez@free.fr>
Cc: MSM <linux-arm-msm@vger.kernel.org>,
Andy Gross <agross@kernel.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
Rob Herring <robh+dt@kernel.org>
Subject: Re: [PATCH] arm64: dts: qcom: msm8996: Rename smmu nodes
Date: Tue, 18 Jun 2019 13:04:24 -0700 [thread overview]
Message-ID: <20190618200424.GH4814@minitux> (raw)
In-Reply-To: <fbe71878-a129-1b11-d978-48a99b292086@free.fr>
On Tue 18 Jun 00:39 PDT 2019, Marc Gonzalez wrote:
> On 18/06/2019 07:24, Bjorn Andersson wrote:
>
> > Node names shouldn't include "qcom," and should whenever possible use
> > a generic identifier. Resolve this by renaming the smmu nodes "iommu".
>
> You mention "qcom" here, but the prefix you changed is "arm"
> /me confused ^_^
>
Thanks for proof reading my patches Marc
I'll respin this.
Regards,
Bjorn
>
> > arch/arm64/boot/dts/qcom/msm8996.dtsi | 8 ++++----
> > 1 file changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi
> > index 2ecd9d775d61..c934e00434c7 100644
> > --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi
> > @@ -1163,7 +1163,7 @@
> > };
> > };
> >
> > - vfe_smmu: arm,smmu@da0000 {
> > + vfe_smmu: iommu@da0000 {
> > compatible = "qcom,msm8996-smmu-v2", "qcom,smmu-v2";
> > reg = <0xda0000 0x10000>;
> >
> > @@ -1314,7 +1314,7 @@
> > };
> > };
> >
> > - adreno_smmu: arm,smmu@b40000 {
> > + adreno_smmu: iommu@b40000 {
> > compatible = "qcom,msm8996-smmu-v2", "qcom,smmu-v2";
> > reg = <0xb40000 0x10000>;
> >
> > @@ -1331,7 +1331,7 @@
> > power-domains = <&mmcc GPU_GDSC>;
> > };
> >
> > - mdp_smmu: arm,smmu@d00000 {
> > + mdp_smmu: iommu@d00000 {
> > compatible = "qcom,msm8996-smmu-v2", "qcom,smmu-v2";
> > reg = <0xd00000 0x10000>;
> >
> > @@ -1347,7 +1347,7 @@
> > power-domains = <&mmcc MDSS_GDSC>;
> > };
> >
> > - lpass_q6_smmu: arm,smmu-lpass_q6@1600000 {
> > + lpass_q6_smmu: iommu@1600000 {
> > compatible = "qcom,msm8996-smmu-v2", "qcom,smmu-v2";
> > reg = <0x1600000 0x20000>;
> > #iommu-cells = <1>;
> >
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-06-18 20:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-18 5:24 [PATCH] arm64: dts: qcom: msm8996: Rename smmu nodes Bjorn Andersson
2019-06-18 7:39 ` Marc Gonzalez
2019-06-18 7:39 ` Marc Gonzalez
2019-06-18 20:04 ` Bjorn Andersson [this message]
2019-06-18 20:04 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190618200424.GH4814@minitux \
--to=bjorn.andersson@linaro.org \
--cc=agross@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=marc.w.gonzalez@free.fr \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.