From: Andrew Lunn <andrew@lunn.ch>
To: Maxime Ripard <maxime.ripard@bootlin.com>
Cc: "Mark Rutland" <mark.rutland@arm.com>,
devicetree@vger.kernel.org,
"Florian Fainelli" <f.fainelli@gmail.com>,
"Alexandre Torgue" <alexandre.torgue@st.com>,
"Antoine Ténart" <antoine.tenart@bootlin.com>,
netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com,
"Chen-Yu Tsai" <wens@csie.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
"Maxime Chevallier" <maxime.chevallier@bootlin.com>,
"Frank Rowand" <frowand.list@gmail.com>,
"David S . Miller" <davem@davemloft.net>,
linux-arm-kernel@lists.infradead.org,
"Heiner Kallweit" <hkallweit1@gmail.com>
Subject: Re: [PATCH v3 14/16] ARM: dts: sunxi: Switch from phy-mode to phy-connection-type
Date: Wed, 19 Jun 2019 16:11:20 +0200 [thread overview]
Message-ID: <20190619141120.GD18352@lunn.ch> (raw)
In-Reply-To: <50f869f466acb110c5924d7e8a67087fd97106fd.1560937626.git-series.maxime.ripard@bootlin.com>
On Wed, Jun 19, 2019 at 11:47:23AM +0200, Maxime Ripard wrote:
> The phy-mode device tree property has been deprecated in favor of
> phy-connection-type, let's replace it.
Hi Maxime
net/ethernet/stmicro/stmmac/dwmac-mediatek.c: dev_err(plat->dev, "not find phy-mode\n");
net/ethernet/stmicro/stmmac/dwmac-anarion.c: dev_err(&pdev->dev, "Unsupported phy-mode (%d)\n",
net/ethernet/stmicro/stmmac/dwmac-meson8b.c: dev_err(dwmac->dev, "fail to set phy-mode %s\n",
net/ethernet/stmicro/stmmac/dwmac-meson8b.c: dev_err(dwmac->dev, "fail to set phy-mode %s\n",
net/ethernet/stmicro/stmmac/dwmac-meson8b.c: dev_err(dwmac->dev, "unsupported phy-mode %s\n",
net/ethernet/stmicro/stmmac/dwmac-meson8b.c: dev_err(&pdev->dev, "missing phy-mode property\n");
As a follow up patch, you might want to change these error messages.
Andrew
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew@lunn.ch>
To: Maxime Ripard <maxime.ripard@bootlin.com>
Cc: "Mark Rutland" <mark.rutland@arm.com>,
devicetree@vger.kernel.org,
"Florian Fainelli" <f.fainelli@gmail.com>,
"Alexandre Torgue" <alexandre.torgue@st.com>,
"Antoine Ténart" <antoine.tenart@bootlin.com>,
netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com,
"Chen-Yu Tsai" <wens@csie.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
"Maxime Chevallier" <maxime.chevallier@bootlin.com>,
"Frank Rowand" <frowand.list@gmail.com>,
"David S . Miller" <davem@davemloft.net>,
linux-arm-kernel@lists.infradead.org,
"Heiner Kallweit" <hkallweit1@gmail.com>
Subject: Re: [PATCH v3 14/16] ARM: dts: sunxi: Switch from phy-mode to phy-connection-type
Date: Wed, 19 Jun 2019 16:11:20 +0200 [thread overview]
Message-ID: <20190619141120.GD18352@lunn.ch> (raw)
In-Reply-To: <50f869f466acb110c5924d7e8a67087fd97106fd.1560937626.git-series.maxime.ripard@bootlin.com>
On Wed, Jun 19, 2019 at 11:47:23AM +0200, Maxime Ripard wrote:
> The phy-mode device tree property has been deprecated in favor of
> phy-connection-type, let's replace it.
Hi Maxime
net/ethernet/stmicro/stmmac/dwmac-mediatek.c: dev_err(plat->dev, "not find phy-mode\n");
net/ethernet/stmicro/stmmac/dwmac-anarion.c: dev_err(&pdev->dev, "Unsupported phy-mode (%d)\n",
net/ethernet/stmicro/stmmac/dwmac-meson8b.c: dev_err(dwmac->dev, "fail to set phy-mode %s\n",
net/ethernet/stmicro/stmmac/dwmac-meson8b.c: dev_err(dwmac->dev, "fail to set phy-mode %s\n",
net/ethernet/stmicro/stmmac/dwmac-meson8b.c: dev_err(dwmac->dev, "unsupported phy-mode %s\n",
net/ethernet/stmicro/stmmac/dwmac-meson8b.c: dev_err(&pdev->dev, "missing phy-mode property\n");
As a follow up patch, you might want to change these error messages.
Andrew
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew@lunn.ch>
To: Maxime Ripard <maxime.ripard@bootlin.com>
Cc: "Mark Rutland" <mark.rutland@arm.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Frank Rowand" <frowand.list@gmail.com>,
"David S . Miller" <davem@davemloft.net>,
"Chen-Yu Tsai" <wens@csie.org>,
"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
"Alexandre Torgue" <alexandre.torgue@st.com>,
netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
devicetree@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
"Maxime Chevallier" <maxime.chevallier@bootlin.com>,
"Antoine Ténart" <antoine.tenart@bootlin.com>,
"Florian Fainelli" <f.fainelli@gmail.com>,
"Heiner Kallweit" <hkallweit1@gmail.com>
Subject: Re: [PATCH v3 14/16] ARM: dts: sunxi: Switch from phy-mode to phy-connection-type
Date: Wed, 19 Jun 2019 16:11:20 +0200 [thread overview]
Message-ID: <20190619141120.GD18352@lunn.ch> (raw)
In-Reply-To: <50f869f466acb110c5924d7e8a67087fd97106fd.1560937626.git-series.maxime.ripard@bootlin.com>
On Wed, Jun 19, 2019 at 11:47:23AM +0200, Maxime Ripard wrote:
> The phy-mode device tree property has been deprecated in favor of
> phy-connection-type, let's replace it.
Hi Maxime
net/ethernet/stmicro/stmmac/dwmac-mediatek.c: dev_err(plat->dev, "not find phy-mode\n");
net/ethernet/stmicro/stmmac/dwmac-anarion.c: dev_err(&pdev->dev, "Unsupported phy-mode (%d)\n",
net/ethernet/stmicro/stmmac/dwmac-meson8b.c: dev_err(dwmac->dev, "fail to set phy-mode %s\n",
net/ethernet/stmicro/stmmac/dwmac-meson8b.c: dev_err(dwmac->dev, "fail to set phy-mode %s\n",
net/ethernet/stmicro/stmmac/dwmac-meson8b.c: dev_err(dwmac->dev, "unsupported phy-mode %s\n",
net/ethernet/stmicro/stmmac/dwmac-meson8b.c: dev_err(&pdev->dev, "missing phy-mode property\n");
As a follow up patch, you might want to change these error messages.
Andrew
next prev parent reply other threads:[~2019-06-19 14:11 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-19 9:47 [PATCH v3 01/16] dt-bindings: net: Add YAML schemas for the generic Ethernet options Maxime Ripard
2019-06-19 9:47 ` Maxime Ripard
2019-06-19 9:47 ` [PATCH v3 02/16] dt-bindings: net: Add a YAML schemas for the generic PHY options Maxime Ripard
2019-06-19 9:47 ` Maxime Ripard
2019-06-19 9:47 ` [PATCH v3 03/16] dt-bindings: net: Add a YAML schemas for the generic MDIO options Maxime Ripard
2019-06-19 9:47 ` Maxime Ripard
2019-06-19 14:17 ` Rob Herring
2019-06-19 14:17 ` Rob Herring
2019-06-20 9:56 ` Maxime Ripard
2019-06-20 9:56 ` Maxime Ripard
2019-06-20 9:56 ` Maxime Ripard
2019-06-19 9:47 ` [PATCH v3 04/16] MAINTAINERS: Add Ethernet PHY YAML file Maxime Ripard
2019-06-19 9:47 ` Maxime Ripard
2019-06-19 9:47 ` [PATCH v3 05/16] dt-bindings: net: phy: The interrupt property is not mandatory Maxime Ripard
2019-06-19 9:47 ` Maxime Ripard
2019-06-19 9:47 ` [PATCH v3 06/16] dt-bindings: net: sun4i-emac: Convert the binding to a schemas Maxime Ripard
2019-06-19 9:47 ` Maxime Ripard
2019-06-19 14:46 ` Rob Herring
2019-06-19 14:46 ` Rob Herring
2019-06-19 14:46 ` Rob Herring
2019-06-19 20:44 ` Rob Herring
2019-06-19 20:44 ` Rob Herring
2019-06-19 9:47 ` [PATCH v3 07/16] dt-bindings: net: sun4i-mdio: " Maxime Ripard
2019-06-19 9:47 ` Maxime Ripard
2019-06-19 14:19 ` Rob Herring
2019-06-19 14:19 ` Rob Herring
2019-06-19 9:47 ` [PATCH v3 08/16] dt-bindings: net: stmmac: " Maxime Ripard
2019-06-19 9:47 ` Maxime Ripard
2019-06-19 14:12 ` Rob Herring
2019-06-19 14:12 ` Rob Herring
2019-06-19 14:12 ` Rob Herring
2019-06-19 9:47 ` [PATCH v3 09/16] dt-bindings: net: sun7i-gmac: " Maxime Ripard
2019-06-19 9:47 ` Maxime Ripard
2019-06-19 9:47 ` [PATCH v3 10/16] dt-bindings: net: sun8i-emac: " Maxime Ripard
2019-06-19 9:47 ` Maxime Ripard
2019-06-19 14:10 ` Rob Herring
2019-06-19 14:10 ` Rob Herring
2019-06-19 9:47 ` [PATCH v3 11/16] dt-bindings: net: dwmac: Deprecate the PHY reset properties Maxime Ripard
2019-06-19 9:47 ` Maxime Ripard
2019-06-19 14:47 ` Rob Herring
2019-06-19 14:47 ` Rob Herring
2019-06-19 9:47 ` [PATCH v3 12/16] ARM: dts: sunxi: Switch to the generic PHY properties Maxime Ripard
2019-06-19 9:47 ` Maxime Ripard
2019-06-19 9:47 ` [PATCH v3 13/16] ARM: dts: sunxi: Switch from phy to phy-handle Maxime Ripard
2019-06-19 9:47 ` Maxime Ripard
2019-06-19 9:47 ` [PATCH v3 14/16] ARM: dts: sunxi: Switch from phy-mode to phy-connection-type Maxime Ripard
2019-06-19 9:47 ` Maxime Ripard
2019-06-19 14:11 ` Andrew Lunn [this message]
2019-06-19 14:11 ` Andrew Lunn
2019-06-19 14:11 ` Andrew Lunn
2019-06-19 9:47 ` [PATCH v3 15/16] ARM: dts: sunxi: h3/h5: " Maxime Ripard
2019-06-19 9:47 ` Maxime Ripard
2019-06-19 9:47 ` [PATCH v3 16/16] arm64: dts: allwinner: " Maxime Ripard
2019-06-19 9:47 ` Maxime Ripard
2019-06-19 14:03 ` [PATCH v3 01/16] dt-bindings: net: Add YAML schemas for the generic Ethernet options Andrew Lunn
2019-06-19 14:03 ` Andrew Lunn
2019-06-20 9:08 ` Maxime Ripard
2019-06-20 9:08 ` Maxime Ripard
2019-06-20 9:08 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190619141120.GD18352@lunn.ch \
--to=andrew@lunn.ch \
--cc=alexandre.torgue@st.com \
--cc=antoine.tenart@bootlin.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=frowand.list@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mark.rutland@arm.com \
--cc=maxime.chevallier@bootlin.com \
--cc=maxime.ripard@bootlin.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.