* [PATCH][bpf-next] bpf: verifier: add a break statement in switch
@ 2019-06-19 16:07 Gustavo A. R. Silva
2019-06-19 17:44 ` Andrii Nakryiko
0 siblings, 1 reply; 3+ messages in thread
From: Gustavo A. R. Silva @ 2019-06-19 16:07 UTC (permalink / raw)
To: Alexei Starovoitov, Daniel Borkmann, Martin KaFai Lau, Song Liu,
Yonghong Song, Lawrence Brakmo, Andrii Nakryiko
Cc: netdev, bpf, linux-kernel, Gustavo A. R. Silva, Kees Cook
Notice that in this case, it's much clearer to explicitly add a break
rather than letting the code to fall through. It also avoid potential
future fall-through warnings[1].
This patch is part of the ongoing efforts to enable
-Wimplicit-fallthrough.
[1] https://lore.kernel.org/patchwork/patch/1087056/
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
kernel/bpf/verifier.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/kernel/bpf/verifier.c b/kernel/bpf/verifier.c
index 709ce4cef8ba..0b38cc917d21 100644
--- a/kernel/bpf/verifier.c
+++ b/kernel/bpf/verifier.c
@@ -6066,6 +6066,7 @@ static int check_return_code(struct bpf_verifier_env *env)
range = tnum_range(0, 3);
enforce_attach_type_range = tnum_range(2, 3);
}
+ break;
case BPF_PROG_TYPE_CGROUP_SOCK:
case BPF_PROG_TYPE_CGROUP_SOCK_ADDR:
case BPF_PROG_TYPE_SOCK_OPS:
--
2.21.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH][bpf-next] bpf: verifier: add a break statement in switch
2019-06-19 16:07 [PATCH][bpf-next] bpf: verifier: add a break statement in switch Gustavo A. R. Silva
@ 2019-06-19 17:44 ` Andrii Nakryiko
2019-06-19 18:46 ` Gustavo A. R. Silva
0 siblings, 1 reply; 3+ messages in thread
From: Andrii Nakryiko @ 2019-06-19 17:44 UTC (permalink / raw)
To: Gustavo A. R. Silva
Cc: Alexei Starovoitov, Daniel Borkmann, Martin KaFai Lau, Song Liu,
Yonghong Song, Lawrence Brakmo, Networking, bpf, open list,
Kees Cook
On Wed, Jun 19, 2019 at 9:07 AM Gustavo A. R. Silva
<gustavo@embeddedor.com> wrote:
>
> Notice that in this case, it's much clearer to explicitly add a break
> rather than letting the code to fall through. It also avoid potential
> future fall-through warnings[1].
>
> This patch is part of the ongoing efforts to enable
> -Wimplicit-fallthrough.
>
> [1] https://lore.kernel.org/patchwork/patch/1087056/
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> ---
Acked-by: Andrii Nakryiko <andriin@fb.com>
> kernel/bpf/verifier.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/kernel/bpf/verifier.c b/kernel/bpf/verifier.c
> index 709ce4cef8ba..0b38cc917d21 100644
> --- a/kernel/bpf/verifier.c
> +++ b/kernel/bpf/verifier.c
> @@ -6066,6 +6066,7 @@ static int check_return_code(struct bpf_verifier_env *env)
> range = tnum_range(0, 3);
> enforce_attach_type_range = tnum_range(2, 3);
> }
> + break;
> case BPF_PROG_TYPE_CGROUP_SOCK:
> case BPF_PROG_TYPE_CGROUP_SOCK_ADDR:
> case BPF_PROG_TYPE_SOCK_OPS:
> --
> 2.21.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH][bpf-next] bpf: verifier: add a break statement in switch
2019-06-19 17:44 ` Andrii Nakryiko
@ 2019-06-19 18:46 ` Gustavo A. R. Silva
0 siblings, 0 replies; 3+ messages in thread
From: Gustavo A. R. Silva @ 2019-06-19 18:46 UTC (permalink / raw)
To: Andrii Nakryiko
Cc: Alexei Starovoitov, Daniel Borkmann, Martin KaFai Lau, Song Liu,
Yonghong Song, Lawrence Brakmo, Networking, bpf, open list,
Kees Cook
On 6/19/19 12:44 PM, Andrii Nakryiko wrote:
> On Wed, Jun 19, 2019 at 9:07 AM Gustavo A. R. Silva
> <gustavo@embeddedor.com> wrote:
>>
>> Notice that in this case, it's much clearer to explicitly add a break
>> rather than letting the code to fall through. It also avoid potential
>> future fall-through warnings[1].
>>
>> This patch is part of the ongoing efforts to enable
>> -Wimplicit-fallthrough.
>>
>> [1] https://lore.kernel.org/patchwork/patch/1087056/
>>
>> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
>> ---
>
> Acked-by: Andrii Nakryiko <andriin@fb.com>
>
Thanks, Andrii.
--
Gustavo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-06-19 19:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-06-19 16:07 [PATCH][bpf-next] bpf: verifier: add a break statement in switch Gustavo A. R. Silva
2019-06-19 17:44 ` Andrii Nakryiko
2019-06-19 18:46 ` Gustavo A. R. Silva
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.