From: helgaas at kernel.org (Bjorn Helgaas)
Subject: [Linux-kernel-mentees] [PATCH v4 0/3] lspci: Update verbose help and show_range()
Date: Wed, 19 Jun 2019 14:44:40 -0500 [thread overview]
Message-ID: <20190619194440.GA189077@google.com> (raw)
In-Reply-To: <20190619164858.84746-1-skunberg.kelsey@gmail.com>
On Wed, Jun 19, 2019 at 10:48:55AM -0600, Kelsey Skunberg wrote:
> Changes since v1:
> - Expand changes into more patches for easier review.
> - Combine three patches for lspci.c into patchset.
>
> * Patch 1: lspci: Include -vvv option in help
> No changes made. Added to series for review.
>
> * Patch 2: lspci: Remove unnecessary !verbose check in show_range()
> Move into it's own patch since v1. Dead code which checks for
> verbosity to be true.
>
> * Patch 3: lspci: Replace output for bridge with empty range from
> "None" to "[empty]"
> Patch builds off Patch 2 to change show_range() output to be more
> consistent between each level of verbosity.
>
> Changes since v2:
> * Patch 1: Update commit log to imperative mood
>
> * Patch 2: Fix logical error
> Previous:
> (base > limit || verbose < 3)
> New:
> (base > limit && verbose < 3)
>
> * Patch 3: Fix logical error
> Previous:
> base > limit
> New:
> base <= limit
>
> Changes since v3:
> * Patch 1 and 2: No change
> * Patch 3: Change output from "[empty]" to "[disabled]"
>
> Kelsey Skunberg (3):
> lspci: Include -vvv option in help
> lspci: Remove unnecessary !verbose check in show_range()
> lspci: Change output for bridge with empty range to "[disabled]"
>
> lspci.c | 24 ++++++++----------------
> 1 file changed, 8 insertions(+), 16 deletions(-)
These look great to me, thanks for doing this. FWIW:
Reviewed-by: Bjorn Helgaas <bhelgaas at google.com>
WARNING: multiple messages have this Message-ID (diff)
From: helgaas@kernel.org (Bjorn Helgaas)
Subject: [Linux-kernel-mentees] [PATCH v4 0/3] lspci: Update verbose help and show_range()
Date: Wed, 19 Jun 2019 14:44:40 -0500 [thread overview]
Message-ID: <20190619194440.GA189077@google.com> (raw)
Message-ID: <20190619194440.pEtiWLf7JSKWkteAe3bxlDAHjaaGv4ePEFvuJ-a6mjs@z> (raw)
In-Reply-To: <20190619164858.84746-1-skunberg.kelsey@gmail.com>
On Wed, Jun 19, 2019 at 10:48:55AM -0600, Kelsey Skunberg wrote:
> Changes since v1:
> - Expand changes into more patches for easier review.
> - Combine three patches for lspci.c into patchset.
>
> * Patch 1: lspci: Include -vvv option in help
> No changes made. Added to series for review.
>
> * Patch 2: lspci: Remove unnecessary !verbose check in show_range()
> Move into it's own patch since v1. Dead code which checks for
> verbosity to be true.
>
> * Patch 3: lspci: Replace output for bridge with empty range from
> "None" to "[empty]"
> Patch builds off Patch 2 to change show_range() output to be more
> consistent between each level of verbosity.
>
> Changes since v2:
> * Patch 1: Update commit log to imperative mood
>
> * Patch 2: Fix logical error
> Previous:
> (base > limit || verbose < 3)
> New:
> (base > limit && verbose < 3)
>
> * Patch 3: Fix logical error
> Previous:
> base > limit
> New:
> base <= limit
>
> Changes since v3:
> * Patch 1 and 2: No change
> * Patch 3: Change output from "[empty]" to "[disabled]"
>
> Kelsey Skunberg (3):
> lspci: Include -vvv option in help
> lspci: Remove unnecessary !verbose check in show_range()
> lspci: Change output for bridge with empty range to "[disabled]"
>
> lspci.c | 24 ++++++++----------------
> 1 file changed, 8 insertions(+), 16 deletions(-)
These look great to me, thanks for doing this. FWIW:
Reviewed-by: Bjorn Helgaas <bhelgaas at google.com>
WARNING: multiple messages have this Message-ID (diff)
From: Bjorn Helgaas <helgaas@kernel.org>
To: Kelsey Skunberg <skunberg.kelsey@gmail.com>
Cc: linux-pci@vger.kernel.org, skhan@linuxfoundation.org,
linux-kernel-mentees@lists.linuxfoundation.org, mj@ucw.cz,
bjorn@helgaas.com
Subject: Re: [PATCH v4 0/3] lspci: Update verbose help and show_range()
Date: Wed, 19 Jun 2019 14:44:40 -0500 [thread overview]
Message-ID: <20190619194440.GA189077@google.com> (raw)
In-Reply-To: <20190619164858.84746-1-skunberg.kelsey@gmail.com>
On Wed, Jun 19, 2019 at 10:48:55AM -0600, Kelsey Skunberg wrote:
> Changes since v1:
> - Expand changes into more patches for easier review.
> - Combine three patches for lspci.c into patchset.
>
> * Patch 1: lspci: Include -vvv option in help
> No changes made. Added to series for review.
>
> * Patch 2: lspci: Remove unnecessary !verbose check in show_range()
> Move into it's own patch since v1. Dead code which checks for
> verbosity to be true.
>
> * Patch 3: lspci: Replace output for bridge with empty range from
> "None" to "[empty]"
> Patch builds off Patch 2 to change show_range() output to be more
> consistent between each level of verbosity.
>
> Changes since v2:
> * Patch 1: Update commit log to imperative mood
>
> * Patch 2: Fix logical error
> Previous:
> (base > limit || verbose < 3)
> New:
> (base > limit && verbose < 3)
>
> * Patch 3: Fix logical error
> Previous:
> base > limit
> New:
> base <= limit
>
> Changes since v3:
> * Patch 1 and 2: No change
> * Patch 3: Change output from "[empty]" to "[disabled]"
>
> Kelsey Skunberg (3):
> lspci: Include -vvv option in help
> lspci: Remove unnecessary !verbose check in show_range()
> lspci: Change output for bridge with empty range to "[disabled]"
>
> lspci.c | 24 ++++++++----------------
> 1 file changed, 8 insertions(+), 16 deletions(-)
These look great to me, thanks for doing this. FWIW:
Reviewed-by: Bjorn Helgaas <bhelgaas@google.com>
next prev parent reply other threads:[~2019-06-19 19:44 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-19 16:48 [Linux-kernel-mentees] [PATCH v4 0/3] lspci: Update verbose help and show_range() skunberg.kelsey
2019-06-19 16:48 ` Kelsey Skunberg
2019-06-19 16:48 ` [Linux-kernel-mentees] " Kelsey Skunberg
2019-06-19 16:48 ` [Linux-kernel-mentees] [PATCH v4 1/3] lspci: Include -vvv option in help skunberg.kelsey
2019-06-19 16:48 ` Kelsey Skunberg
2019-06-19 16:48 ` [Linux-kernel-mentees] " Kelsey Skunberg
2019-06-19 16:48 ` [Linux-kernel-mentees] [PATCH v4 2/3] lspci: Remove unnecessary !verbose check in show_range() skunberg.kelsey
2019-06-19 16:48 ` Kelsey Skunberg
2019-06-19 16:48 ` [Linux-kernel-mentees] " Kelsey Skunberg
2019-06-19 16:48 ` [Linux-kernel-mentees] [PATCH v4 3/3] lspci: Change output for bridge with empty range to "[disabled]" skunberg.kelsey
2019-06-19 16:48 ` Kelsey Skunberg
2019-06-19 16:48 ` [Linux-kernel-mentees] " Kelsey Skunberg
2019-06-19 19:44 ` helgaas [this message]
2019-06-19 19:44 ` [PATCH v4 0/3] lspci: Update verbose help and show_range() Bjorn Helgaas
2019-06-19 19:44 ` [Linux-kernel-mentees] " Bjorn Helgaas
2020-01-21 20:52 ` Martin Mareš
2020-01-21 20:52 ` Martin Mareš
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190619194440.GA189077@google.com \
--to=unknown@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.