From: stephen at networkplumber.org (Stephen Hemminger)
Subject: [Linux-kernel-mentees] [PATCH v2 0/3] net: fddi: skfp: Use PCI generic definitions instead of private duplicates
Date: Thu, 20 Jun 2019 11:37:12 -0700 [thread overview]
Message-ID: <20190620113712.4630f60f@hermes.lan> (raw)
In-Reply-To: <20190620180754.15413-1-puranjay12@gmail.com>
On Thu, 20 Jun 2019 23:37:51 +0530
Puranjay Mohan <puranjay12 at gmail.com> wrote:
> This patch series removes the private duplicates of PCI definitions in
> favour of generic definitions defined in pci_regs.h.
>
> This driver only uses one of the generic PCI definitons, i.e.
> PCI_REVISION_ID, which is included from pci_regs.h and its private
> version is removed from skfbi.h with all other private defines.
>
> The skfbi.h defines PCI_REV_ID which is renamed to PCI_REVISION_ID in
> drvfbi.c to make it compatible with the generic define in pci_regs.h.
>
> Puranjay Mohan (3):
> net: fddi: skfp: Rename PCI_REV_ID to PCI_REVISION_ID
> net: fddi: skfp: Include generic PCI definitions
> net: fddi: skfp: Remove unused private PCI definitions
>
> drivers/net/fddi/skfp/drvfbi.c | 4 +-
> drivers/net/fddi/skfp/h/skfbi.h | 207 +-------------------------------
> 2 files changed, 3 insertions(+), 208 deletions(-)
>
Does anyone still have the hardware to test this?
Maybe FDDI should be put out to pasture.
WARNING: multiple messages have this Message-ID (diff)
From: stephen@networkplumber.org (Stephen Hemminger)
Subject: [Linux-kernel-mentees] [PATCH v2 0/3] net: fddi: skfp: Use PCI generic definitions instead of private duplicates
Date: Thu, 20 Jun 2019 11:37:12 -0700 [thread overview]
Message-ID: <20190620113712.4630f60f@hermes.lan> (raw)
Message-ID: <20190620183712.8hzhdAyDCz8ASd6goGQczINGEXM7PmaIQSCQRbaHxjM@z> (raw)
In-Reply-To: <20190620180754.15413-1-puranjay12@gmail.com>
On Thu, 20 Jun 2019 23:37:51 +0530
Puranjay Mohan <puranjay12 at gmail.com> wrote:
> This patch series removes the private duplicates of PCI definitions in
> favour of generic definitions defined in pci_regs.h.
>
> This driver only uses one of the generic PCI definitons, i.e.
> PCI_REVISION_ID, which is included from pci_regs.h and its private
> version is removed from skfbi.h with all other private defines.
>
> The skfbi.h defines PCI_REV_ID which is renamed to PCI_REVISION_ID in
> drvfbi.c to make it compatible with the generic define in pci_regs.h.
>
> Puranjay Mohan (3):
> net: fddi: skfp: Rename PCI_REV_ID to PCI_REVISION_ID
> net: fddi: skfp: Include generic PCI definitions
> net: fddi: skfp: Remove unused private PCI definitions
>
> drivers/net/fddi/skfp/drvfbi.c | 4 +-
> drivers/net/fddi/skfp/h/skfbi.h | 207 +-------------------------------
> 2 files changed, 3 insertions(+), 208 deletions(-)
>
Does anyone still have the hardware to test this?
Maybe FDDI should be put out to pasture.
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Hemminger <stephen@networkplumber.org>
To: Puranjay Mohan <puranjay12@gmail.com>
Cc: Shuah Khan <skhan@linuxfoundation.org>,
Bjorn Helgaas <bjorn@helgaas.com>,
netdev <netdev@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-kernel-mentees@lists.linuxfoundation.org,
linux-pci@vger.kernel.org
Subject: Re: [PATCH v2 0/3] net: fddi: skfp: Use PCI generic definitions instead of private duplicates
Date: Thu, 20 Jun 2019 11:37:12 -0700 [thread overview]
Message-ID: <20190620113712.4630f60f@hermes.lan> (raw)
In-Reply-To: <20190620180754.15413-1-puranjay12@gmail.com>
On Thu, 20 Jun 2019 23:37:51 +0530
Puranjay Mohan <puranjay12@gmail.com> wrote:
> This patch series removes the private duplicates of PCI definitions in
> favour of generic definitions defined in pci_regs.h.
>
> This driver only uses one of the generic PCI definitons, i.e.
> PCI_REVISION_ID, which is included from pci_regs.h and its private
> version is removed from skfbi.h with all other private defines.
>
> The skfbi.h defines PCI_REV_ID which is renamed to PCI_REVISION_ID in
> drvfbi.c to make it compatible with the generic define in pci_regs.h.
>
> Puranjay Mohan (3):
> net: fddi: skfp: Rename PCI_REV_ID to PCI_REVISION_ID
> net: fddi: skfp: Include generic PCI definitions
> net: fddi: skfp: Remove unused private PCI definitions
>
> drivers/net/fddi/skfp/drvfbi.c | 4 +-
> drivers/net/fddi/skfp/h/skfbi.h | 207 +-------------------------------
> 2 files changed, 3 insertions(+), 208 deletions(-)
>
Does anyone still have the hardware to test this?
Maybe FDDI should be put out to pasture.
next prev parent reply other threads:[~2019-06-20 18:37 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-20 18:07 [Linux-kernel-mentees] [PATCH v2 0/3] net: fddi: skfp: Use PCI generic definitions instead of private duplicates puranjay12
2019-06-20 18:07 ` Puranjay Mohan
2019-06-20 18:07 ` [Linux-kernel-mentees] " Puranjay Mohan
2019-06-20 18:07 ` [Linux-kernel-mentees] [PATCH v2 1/3] net: fddi: skfp: Rename PCI_REV_ID to PCI_REVISION_ID puranjay12
2019-06-20 18:07 ` Puranjay Mohan
2019-06-20 18:07 ` [Linux-kernel-mentees] " Puranjay Mohan
2019-06-24 6:45 ` hch
2019-06-24 6:45 ` Christoph Hellwig
2019-06-24 6:45 ` [Linux-kernel-mentees] " Christoph Hellwig
2019-06-20 18:07 ` [Linux-kernel-mentees] [PATCH v2 2/3] net: fddi: skfp: Include generic PCI definitions puranjay12
2019-06-20 18:07 ` Puranjay Mohan
2019-06-20 18:07 ` [Linux-kernel-mentees] " Puranjay Mohan
2019-06-20 21:37 ` helgaas
2019-06-20 21:37 ` Bjorn Helgaas
2019-06-20 21:37 ` [Linux-kernel-mentees] " Bjorn Helgaas
2019-06-20 18:07 ` [Linux-kernel-mentees] [PATCH v2 3/3] net: fddi: skfp: Remove unused private " puranjay12
2019-06-20 18:07 ` Puranjay Mohan
2019-06-20 18:07 ` [Linux-kernel-mentees] " Puranjay Mohan
2019-06-20 21:37 ` helgaas
2019-06-20 21:37 ` Bjorn Helgaas
2019-06-20 21:37 ` [Linux-kernel-mentees] " Bjorn Helgaas
2019-06-20 18:37 ` stephen [this message]
2019-06-20 18:37 ` [PATCH v2 0/3] net: fddi: skfp: Use PCI generic definitions instead of private duplicates Stephen Hemminger
2019-06-20 18:37 ` [Linux-kernel-mentees] " Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190620113712.4630f60f@hermes.lan \
--to=unknown@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.