* [PATCH] staging: rtl8723bs: HalBtc8723b1Ant: fix Using comparison to true is error prone
@ 2019-06-19 18:04 Hariprasad Kelam
2019-06-20 12:44 ` Greg Kroah-Hartman
0 siblings, 1 reply; 2+ messages in thread
From: Hariprasad Kelam @ 2019-06-19 18:04 UTC (permalink / raw)
To: Greg Kroah-Hartman, Hariprasad Kelam, devel, linux-kernel
This patch fixes below issue reported by checkpatch
CHECK: Using comparison to true is error prone
CHECK: Using comparison to false is error prone
Signed-off-by: Hariprasad Kelam <hariprasad.kelam@gmail.com>
---
drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.c b/drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.c
index eb6e07e..768ad53 100644
--- a/drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.c
+++ b/drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.c
@@ -1421,7 +1421,7 @@ static void halbtc8723b1ant_PsTdma(
if (bTurnOn) {
- if (pBtLinkInfo->bSlaveRole == true)
+ if (pBtLinkInfo->bSlaveRole)
psTdmaByte4Val = psTdmaByte4Val | 0x1; /* 0x778 = 0x1 at wifi slot (no blocking BT Low-Pri pkts) */
@@ -2337,9 +2337,9 @@ static void halbtc8723b1ant_ActionWifiConnected(PBTC_COEXIST pBtCoexist)
);
}
} else if (
- (pCoexSta->bPanExist == false) &&
- (pCoexSta->bA2dpExist == false) &&
- (pCoexSta->bHidExist == false)
+ !pCoexSta->bPanExist &&
+ !pCoexSta->bA2dpExist &&
+ !pCoexSta->bHidExist
)
halbtc8723b1ant_PowerSaveState(pBtCoexist, BTC_PS_WIFI_NATIVE, 0x0, 0x0);
else
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: rtl8723bs: HalBtc8723b1Ant: fix Using comparison to true is error prone
2019-06-19 18:04 [PATCH] staging: rtl8723bs: HalBtc8723b1Ant: fix Using comparison to true is error prone Hariprasad Kelam
@ 2019-06-20 12:44 ` Greg Kroah-Hartman
0 siblings, 0 replies; 2+ messages in thread
From: Greg Kroah-Hartman @ 2019-06-20 12:44 UTC (permalink / raw)
To: Hariprasad Kelam; +Cc: devel, linux-kernel
On Wed, Jun 19, 2019 at 11:34:39PM +0530, Hariprasad Kelam wrote:
> This patch fixes below issue reported by checkpatch
>
> CHECK: Using comparison to true is error prone
> CHECK: Using comparison to false is error prone
>
> Signed-off-by: Hariprasad Kelam <hariprasad.kelam@gmail.com>
> ---
> drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
Does not apply to my tree :(
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-06-20 12:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-06-19 18:04 [PATCH] staging: rtl8723bs: HalBtc8723b1Ant: fix Using comparison to true is error prone Hariprasad Kelam
2019-06-20 12:44 ` Greg Kroah-Hartman
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.