From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Daniel Thompson <daniel.thompson@linaro.org>
Cc: Jingoo Han <jingoohan1@gmail.com>,
Lee Jones <lee.jones@linaro.org>,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v1] backlight: gpio_backlight: Enable ACPI enumeration
Date: Thu, 20 Jun 2019 18:12:56 +0300 [thread overview]
Message-ID: <20190620151256.GH9224@smile.fi.intel.com> (raw)
In-Reply-To: <8919f52e-c745-503d-806d-aa605ddc8325@linaro.org>
On Thu, Jun 20, 2019 at 03:12:05PM +0100, Daniel Thompson wrote:
> On 19/06/2019 16:21, Andy Shevchenko wrote:
> > ACPI allows to enumerate specific devices by using compatible strings.
> > Enable that enumeration for GPIO based backlight devices.
> > + dev_err(&pdev->dev,
> > + "failed to find platform data or device tree node.\n");
>
> Should the string also be updated?
I don't think it's necessary. The device tree compatible mode is for DT
drivers, so, it is assumed that person knows much enough and this message would
be useful as is.
> If what is updated to acknoledge option to use ACPI then:
> Acked-by: Daniel Thompson <daniel.thompson@linaro.org>
Thanks!
--
With Best Regards,
Andy Shevchenko
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-06-20 15:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-19 15:21 [PATCH v1] backlight: gpio_backlight: Enable ACPI enumeration Andy Shevchenko
2019-06-20 14:12 ` Daniel Thompson
2019-06-20 15:12 ` Andy Shevchenko [this message]
2019-06-26 10:57 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190620151256.GH9224@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=daniel.thompson@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jingoohan1@gmail.com \
--cc=lee.jones@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.