* [PATCH] mtd: mtd-abi: Don't use C++ comments
@ 2019-06-20 15:55 ` Nathan Chancellor
0 siblings, 0 replies; 10+ messages in thread
From: Nathan Chancellor @ 2019-06-20 15:55 UTC (permalink / raw)
To: David Woodhouse, Brian Norris, Marek Vasut, Miquel Raynal,
Richard Weinberger, Vignesh Raghavendra
Cc: clang-built-linux, Nathan Chancellor, linux-mtd, linux-kernel
When compiled standalone after commit b91976b7c0e3 ("kbuild:
compile-test UAPI headers to ensure they are self-contained"),
a warning about the C++ comments appears:
In file included from usr/include/mtd/mtd-user.hdrtest.c:1:
In file included from ./usr/include/mtd/mtd-user.h:25:
./usr/include/mtd/mtd-abi.h:116:28: warning: // comments are not
allowed in this language [-Wcomment]
#define MTD_NANDECC_OFF 0 // Switch off ECC (Not recommended)
^
1 warning generated.
Replace them with standard C comments so this warning no longer occurs.
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
---
include/uapi/mtd/mtd-abi.h | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/include/uapi/mtd/mtd-abi.h b/include/uapi/mtd/mtd-abi.h
index aff5b5e59845..3fe9237f723a 100644
--- a/include/uapi/mtd/mtd-abi.h
+++ b/include/uapi/mtd/mtd-abi.h
@@ -113,11 +113,11 @@ struct mtd_write_req {
#define MTD_CAP_NVRAM (MTD_WRITEABLE | MTD_BIT_WRITEABLE | MTD_NO_ERASE)
/* Obsolete ECC byte placement modes (used with obsolete MEMGETOOBSEL) */
-#define MTD_NANDECC_OFF 0 // Switch off ECC (Not recommended)
-#define MTD_NANDECC_PLACE 1 // Use the given placement in the structure (YAFFS1 legacy mode)
-#define MTD_NANDECC_AUTOPLACE 2 // Use the default placement scheme
-#define MTD_NANDECC_PLACEONLY 3 // Use the given placement in the structure (Do not store ecc result on read)
-#define MTD_NANDECC_AUTOPL_USR 4 // Use the given autoplacement scheme rather than using the default
+#define MTD_NANDECC_OFF 0 /* Switch off ECC (Not recommended) */
+#define MTD_NANDECC_PLACE 1 /* Use the given placement in the structure (YAFFS1 legacy mode) */
+#define MTD_NANDECC_AUTOPLACE 2 /* Use the default placement scheme */
+#define MTD_NANDECC_PLACEONLY 3 /* Use the given placement in the structure (Do not store ecc result on read) */
+#define MTD_NANDECC_AUTOPL_USR 4 /* Use the given autoplacement scheme rather than using the default */
/* OTP mode selection */
#define MTD_OTP_OFF 0
--
2.22.0
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH] mtd: mtd-abi: Don't use C++ comments
@ 2019-06-20 15:55 ` Nathan Chancellor
0 siblings, 0 replies; 10+ messages in thread
From: Nathan Chancellor @ 2019-06-20 15:55 UTC (permalink / raw)
To: David Woodhouse, Brian Norris, Marek Vasut, Miquel Raynal,
Richard Weinberger, Vignesh Raghavendra
Cc: linux-mtd, linux-kernel, clang-built-linux, Nathan Chancellor
When compiled standalone after commit b91976b7c0e3 ("kbuild:
compile-test UAPI headers to ensure they are self-contained"),
a warning about the C++ comments appears:
In file included from usr/include/mtd/mtd-user.hdrtest.c:1:
In file included from ./usr/include/mtd/mtd-user.h:25:
./usr/include/mtd/mtd-abi.h:116:28: warning: // comments are not
allowed in this language [-Wcomment]
#define MTD_NANDECC_OFF 0 // Switch off ECC (Not recommended)
^
1 warning generated.
Replace them with standard C comments so this warning no longer occurs.
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
---
include/uapi/mtd/mtd-abi.h | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/include/uapi/mtd/mtd-abi.h b/include/uapi/mtd/mtd-abi.h
index aff5b5e59845..3fe9237f723a 100644
--- a/include/uapi/mtd/mtd-abi.h
+++ b/include/uapi/mtd/mtd-abi.h
@@ -113,11 +113,11 @@ struct mtd_write_req {
#define MTD_CAP_NVRAM (MTD_WRITEABLE | MTD_BIT_WRITEABLE | MTD_NO_ERASE)
/* Obsolete ECC byte placement modes (used with obsolete MEMGETOOBSEL) */
-#define MTD_NANDECC_OFF 0 // Switch off ECC (Not recommended)
-#define MTD_NANDECC_PLACE 1 // Use the given placement in the structure (YAFFS1 legacy mode)
-#define MTD_NANDECC_AUTOPLACE 2 // Use the default placement scheme
-#define MTD_NANDECC_PLACEONLY 3 // Use the given placement in the structure (Do not store ecc result on read)
-#define MTD_NANDECC_AUTOPL_USR 4 // Use the given autoplacement scheme rather than using the default
+#define MTD_NANDECC_OFF 0 /* Switch off ECC (Not recommended) */
+#define MTD_NANDECC_PLACE 1 /* Use the given placement in the structure (YAFFS1 legacy mode) */
+#define MTD_NANDECC_AUTOPLACE 2 /* Use the default placement scheme */
+#define MTD_NANDECC_PLACEONLY 3 /* Use the given placement in the structure (Do not store ecc result on read) */
+#define MTD_NANDECC_AUTOPL_USR 4 /* Use the given autoplacement scheme rather than using the default */
/* OTP mode selection */
#define MTD_OTP_OFF 0
--
2.22.0
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH] mtd: mtd-abi: Don't use C++ comments
2019-06-20 15:55 ` Nathan Chancellor
@ 2019-06-20 19:56 ` Nick Desaulniers
-1 siblings, 0 replies; 10+ messages in thread
From: Nick Desaulniers @ 2019-06-20 19:56 UTC (permalink / raw)
To: Nathan Chancellor
Cc: Vignesh Raghavendra, clang-built-linux, Richard Weinberger, LKML,
Marek Vasut, linux-mtd, Miquel Raynal, Brian Norris,
David Woodhouse
On Thu, Jun 20, 2019 at 8:55 AM Nathan Chancellor
<natechancellor@gmail.com> wrote:
>
> When compiled standalone after commit b91976b7c0e3 ("kbuild:
> compile-test UAPI headers to ensure they are self-contained"),
> a warning about the C++ comments appears:
>
> In file included from usr/include/mtd/mtd-user.hdrtest.c:1:
> In file included from ./usr/include/mtd/mtd-user.h:25:
> ./usr/include/mtd/mtd-abi.h:116:28: warning: // comments are not
> allowed in this language [-Wcomment]
> #define MTD_NANDECC_OFF 0 // Switch off ECC (Not recommended)
> ^
> 1 warning generated.
>
> Replace them with standard C comments so this warning no longer occurs.
Should there be a fixes by tag?
--
Thanks,
~Nick Desaulniers
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH] mtd: mtd-abi: Don't use C++ comments
@ 2019-06-20 19:56 ` Nick Desaulniers
0 siblings, 0 replies; 10+ messages in thread
From: Nick Desaulniers @ 2019-06-20 19:56 UTC (permalink / raw)
To: Nathan Chancellor
Cc: David Woodhouse, Brian Norris, Marek Vasut, Miquel Raynal,
Richard Weinberger, Vignesh Raghavendra, linux-mtd, LKML,
clang-built-linux
On Thu, Jun 20, 2019 at 8:55 AM Nathan Chancellor
<natechancellor@gmail.com> wrote:
>
> When compiled standalone after commit b91976b7c0e3 ("kbuild:
> compile-test UAPI headers to ensure they are self-contained"),
> a warning about the C++ comments appears:
>
> In file included from usr/include/mtd/mtd-user.hdrtest.c:1:
> In file included from ./usr/include/mtd/mtd-user.h:25:
> ./usr/include/mtd/mtd-abi.h:116:28: warning: // comments are not
> allowed in this language [-Wcomment]
> #define MTD_NANDECC_OFF 0 // Switch off ECC (Not recommended)
> ^
> 1 warning generated.
>
> Replace them with standard C comments so this warning no longer occurs.
Should there be a fixes by tag?
--
Thanks,
~Nick Desaulniers
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH] mtd: mtd-abi: Don't use C++ comments
2019-06-20 19:56 ` Nick Desaulniers
@ 2019-06-20 20:15 ` Nathan Chancellor
-1 siblings, 0 replies; 10+ messages in thread
From: Nathan Chancellor @ 2019-06-20 20:15 UTC (permalink / raw)
To: Nick Desaulniers
Cc: Vignesh Raghavendra, clang-built-linux, Richard Weinberger, LKML,
Marek Vasut, linux-mtd, Miquel Raynal, Brian Norris,
David Woodhouse
On Thu, Jun 20, 2019 at 12:56:58PM -0700, Nick Desaulniers wrote:
> On Thu, Jun 20, 2019 at 8:55 AM Nathan Chancellor
> <natechancellor@gmail.com> wrote:
> >
> > When compiled standalone after commit b91976b7c0e3 ("kbuild:
> > compile-test UAPI headers to ensure they are self-contained"),
> > a warning about the C++ comments appears:
> >
> > In file included from usr/include/mtd/mtd-user.hdrtest.c:1:
> > In file included from ./usr/include/mtd/mtd-user.h:25:
> > ./usr/include/mtd/mtd-abi.h:116:28: warning: // comments are not
> > allowed in this language [-Wcomment]
> > #define MTD_NANDECC_OFF 0 // Switch off ECC (Not recommended)
> > ^
> > 1 warning generated.
> >
> > Replace them with standard C comments so this warning no longer occurs.
>
> Should there be a fixes by tag?
> --
> Thanks,
> ~Nick Desaulniers
Normally, I would have added one but this issue has been present since
the beginning of git history. According to Thomas Gleixner's pre-git
history tree, it would be:
Fixes: 7df80b4c8964 ("MTD core include and device code cleanup")
but since that hash doesn't exist in the normal git history, I don't
think it is worth adding. Of course, if the maintainers want to add it,
I won't object.
[1]: https://git.kernel.org/pub/scm/linux/kernel/git/tglx/history.git
Cheers,
NAthan
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH] mtd: mtd-abi: Don't use C++ comments
@ 2019-06-20 20:15 ` Nathan Chancellor
0 siblings, 0 replies; 10+ messages in thread
From: Nathan Chancellor @ 2019-06-20 20:15 UTC (permalink / raw)
To: Nick Desaulniers
Cc: David Woodhouse, Brian Norris, Marek Vasut, Miquel Raynal,
Richard Weinberger, Vignesh Raghavendra, linux-mtd, LKML,
clang-built-linux
On Thu, Jun 20, 2019 at 12:56:58PM -0700, Nick Desaulniers wrote:
> On Thu, Jun 20, 2019 at 8:55 AM Nathan Chancellor
> <natechancellor@gmail.com> wrote:
> >
> > When compiled standalone after commit b91976b7c0e3 ("kbuild:
> > compile-test UAPI headers to ensure they are self-contained"),
> > a warning about the C++ comments appears:
> >
> > In file included from usr/include/mtd/mtd-user.hdrtest.c:1:
> > In file included from ./usr/include/mtd/mtd-user.h:25:
> > ./usr/include/mtd/mtd-abi.h:116:28: warning: // comments are not
> > allowed in this language [-Wcomment]
> > #define MTD_NANDECC_OFF 0 // Switch off ECC (Not recommended)
> > ^
> > 1 warning generated.
> >
> > Replace them with standard C comments so this warning no longer occurs.
>
> Should there be a fixes by tag?
> --
> Thanks,
> ~Nick Desaulniers
Normally, I would have added one but this issue has been present since
the beginning of git history. According to Thomas Gleixner's pre-git
history tree, it would be:
Fixes: 7df80b4c8964 ("MTD core include and device code cleanup")
but since that hash doesn't exist in the normal git history, I don't
think it is worth adding. Of course, if the maintainers want to add it,
I won't object.
[1]: https://git.kernel.org/pub/scm/linux/kernel/git/tglx/history.git
Cheers,
NAthan
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH] mtd: mtd-abi: Don't use C++ comments
2019-06-20 20:15 ` Nathan Chancellor
@ 2019-06-20 20:29 ` Nick Desaulniers
-1 siblings, 0 replies; 10+ messages in thread
From: Nick Desaulniers @ 2019-06-20 20:29 UTC (permalink / raw)
To: Nathan Chancellor
Cc: Sasha Levin, Vignesh Raghavendra, clang-built-linux,
Richard Weinberger, LKML, Marek Vasut, Greg KH, linux-mtd,
Miquel Raynal, Brian Norris, David Woodhouse
On Thu, Jun 20, 2019 at 1:15 PM Nathan Chancellor
<natechancellor@gmail.com> wrote:
>
> On Thu, Jun 20, 2019 at 12:56:58PM -0700, Nick Desaulniers wrote:
> > Should there be a fixes by tag?
>
> Normally, I would have added one but this issue has been present since
> the beginning of git history. According to Thomas Gleixner's pre-git
> history tree, it would be:
>
> Fixes: 7df80b4c8964 ("MTD core include and device code cleanup")
>
> but since that hash doesn't exist in the normal git history, I don't
> think it is worth adding. Of course, if the maintainers want to add it,
> I won't object.
>
> [1]: https://git.kernel.org/pub/scm/linux/kernel/git/tglx/history.git
LOL good point; I wonder if the stable maintainers have thoughts on
that or how they expect us to signal that case if we even need to do
anything at all.
Either way, thanks for the patch and
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
--
Thanks,
~Nick Desaulniers
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH] mtd: mtd-abi: Don't use C++ comments
@ 2019-06-20 20:29 ` Nick Desaulniers
0 siblings, 0 replies; 10+ messages in thread
From: Nick Desaulniers @ 2019-06-20 20:29 UTC (permalink / raw)
To: Nathan Chancellor
Cc: David Woodhouse, Brian Norris, Marek Vasut, Miquel Raynal,
Richard Weinberger, Vignesh Raghavendra, linux-mtd, LKML,
clang-built-linux, Greg KH, Sasha Levin
On Thu, Jun 20, 2019 at 1:15 PM Nathan Chancellor
<natechancellor@gmail.com> wrote:
>
> On Thu, Jun 20, 2019 at 12:56:58PM -0700, Nick Desaulniers wrote:
> > Should there be a fixes by tag?
>
> Normally, I would have added one but this issue has been present since
> the beginning of git history. According to Thomas Gleixner's pre-git
> history tree, it would be:
>
> Fixes: 7df80b4c8964 ("MTD core include and device code cleanup")
>
> but since that hash doesn't exist in the normal git history, I don't
> think it is worth adding. Of course, if the maintainers want to add it,
> I won't object.
>
> [1]: https://git.kernel.org/pub/scm/linux/kernel/git/tglx/history.git
LOL good point; I wonder if the stable maintainers have thoughts on
that or how they expect us to signal that case if we even need to do
anything at all.
Either way, thanks for the patch and
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
--
Thanks,
~Nick Desaulniers
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH] mtd: mtd-abi: Don't use C++ comments
2019-06-20 20:29 ` Nick Desaulniers
@ 2019-06-21 6:26 ` Greg KH
-1 siblings, 0 replies; 10+ messages in thread
From: Greg KH @ 2019-06-21 6:26 UTC (permalink / raw)
To: Nick Desaulniers
Cc: Sasha Levin, Vignesh Raghavendra, clang-built-linux,
Richard Weinberger, LKML, Marek Vasut, linux-mtd, Miquel Raynal,
Nathan Chancellor, Brian Norris, David Woodhouse
On Thu, Jun 20, 2019 at 01:29:47PM -0700, Nick Desaulniers wrote:
> On Thu, Jun 20, 2019 at 1:15 PM Nathan Chancellor
> <natechancellor@gmail.com> wrote:
> >
> > On Thu, Jun 20, 2019 at 12:56:58PM -0700, Nick Desaulniers wrote:
> > > Should there be a fixes by tag?
> >
> > Normally, I would have added one but this issue has been present since
> > the beginning of git history. According to Thomas Gleixner's pre-git
> > history tree, it would be:
> >
> > Fixes: 7df80b4c8964 ("MTD core include and device code cleanup")
> >
> > but since that hash doesn't exist in the normal git history, I don't
> > think it is worth adding. Of course, if the maintainers want to add it,
> > I won't object.
> >
> > [1]: https://git.kernel.org/pub/scm/linux/kernel/git/tglx/history.git
>
> LOL good point; I wonder if the stable maintainers have thoughts on
> that or how they expect us to signal that case if we even need to do
> anything at all.
If you want it applied "since the beginning of time", then just do:
Cc: <stable@vger.kernel.org> # 2.6.0+
or some such marking.
thanks,
greg k-h
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH] mtd: mtd-abi: Don't use C++ comments
@ 2019-06-21 6:26 ` Greg KH
0 siblings, 0 replies; 10+ messages in thread
From: Greg KH @ 2019-06-21 6:26 UTC (permalink / raw)
To: Nick Desaulniers
Cc: Nathan Chancellor, David Woodhouse, Brian Norris, Marek Vasut,
Miquel Raynal, Richard Weinberger, Vignesh Raghavendra, linux-mtd,
LKML, clang-built-linux, Sasha Levin
On Thu, Jun 20, 2019 at 01:29:47PM -0700, Nick Desaulniers wrote:
> On Thu, Jun 20, 2019 at 1:15 PM Nathan Chancellor
> <natechancellor@gmail.com> wrote:
> >
> > On Thu, Jun 20, 2019 at 12:56:58PM -0700, Nick Desaulniers wrote:
> > > Should there be a fixes by tag?
> >
> > Normally, I would have added one but this issue has been present since
> > the beginning of git history. According to Thomas Gleixner's pre-git
> > history tree, it would be:
> >
> > Fixes: 7df80b4c8964 ("MTD core include and device code cleanup")
> >
> > but since that hash doesn't exist in the normal git history, I don't
> > think it is worth adding. Of course, if the maintainers want to add it,
> > I won't object.
> >
> > [1]: https://git.kernel.org/pub/scm/linux/kernel/git/tglx/history.git
>
> LOL good point; I wonder if the stable maintainers have thoughts on
> that or how they expect us to signal that case if we even need to do
> anything at all.
If you want it applied "since the beginning of time", then just do:
Cc: <stable@vger.kernel.org> # 2.6.0+
or some such marking.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2019-06-21 6:26 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-06-20 15:55 [PATCH] mtd: mtd-abi: Don't use C++ comments Nathan Chancellor
2019-06-20 15:55 ` Nathan Chancellor
2019-06-20 19:56 ` Nick Desaulniers
2019-06-20 19:56 ` Nick Desaulniers
2019-06-20 20:15 ` Nathan Chancellor
2019-06-20 20:15 ` Nathan Chancellor
2019-06-20 20:29 ` Nick Desaulniers
2019-06-20 20:29 ` Nick Desaulniers
2019-06-21 6:26 ` Greg KH
2019-06-21 6:26 ` Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.