From: puranjay12 at gmail.com (Puranjay Mohan)
Subject: [Linux-kernel-mentees] [PATCH v4 0/3] net: fddi: skfp: Use PCI generic definitions instead of private duplicates
Date: Fri, 21 Jun 2019 20:49:28 +0530 [thread overview]
Message-ID: <20190621151927.GA12091@arch> (raw)
In-Reply-To: <20190621151415.10795-1-puranjay12@gmail.com>
On Fri, Jun 21, 2019 at 08:44:12PM +0530, Puranjay Mohan wrote:
> This patch series removes the private duplicates of PCI definitions in
> favour of generic definitions defined in pci_regs.h.
>
> This driver only uses some of the generic PCI definitons,
> which are included from pci_regs.h and thier private versions
> are removed from skfbi.h with all other private defines.
>
> The skfbi.h defines PCI_REV_ID and other private defines with different
> names, these are renamed to Generic PCI names to make them
> compatible with defines in pci_regs.h.
>
> All unused defines are removed from skfbi.h.
>
I left some of the definitions in v4 too!
will remove them all and send v5
sorry for the inconvenience
> Changes in v4:
> Removed unused PCI definitions which were left in v3
>
> Changes in v3:
> Renamed all local PCI definitions to Generic names.
> Corrected coding style mistakes.
>
> Changes in v2:
> Converted individual patches to a series.
> Made sure that individual patches build correctly
>
> Puranjay Mohan (3):
> net: fddi: skfp: Rename local PCI defines to match generic PCI defines
> net: fddi: skfp: Include generic PCI definitions
> net: fddi: skfp: Remove unused private PCI definitions
>
> drivers/net/fddi/skfp/drvfbi.c | 3 +-
> drivers/net/fddi/skfp/h/skfbi.h | 217 +-------------------------------
> 2 files changed, 6 insertions(+), 214 deletions(-)
>
> --
> 2.21.0
>
WARNING: multiple messages have this Message-ID (diff)
From: puranjay12@gmail.com (Puranjay Mohan)
Subject: [Linux-kernel-mentees] [PATCH v4 0/3] net: fddi: skfp: Use PCI generic definitions instead of private duplicates
Date: Fri, 21 Jun 2019 20:49:28 +0530 [thread overview]
Message-ID: <20190621151927.GA12091@arch> (raw)
Message-ID: <20190621151928.dcIKuG1ugDNVI0BbjvJO5uOkf2D4vQlekwN0ss7cMvE@z> (raw)
In-Reply-To: <20190621151415.10795-1-puranjay12@gmail.com>
On Fri, Jun 21, 2019 at 08:44:12PM +0530, Puranjay Mohan wrote:
> This patch series removes the private duplicates of PCI definitions in
> favour of generic definitions defined in pci_regs.h.
>
> This driver only uses some of the generic PCI definitons,
> which are included from pci_regs.h and thier private versions
> are removed from skfbi.h with all other private defines.
>
> The skfbi.h defines PCI_REV_ID and other private defines with different
> names, these are renamed to Generic PCI names to make them
> compatible with defines in pci_regs.h.
>
> All unused defines are removed from skfbi.h.
>
I left some of the definitions in v4 too!
will remove them all and send v5
sorry for the inconvenience
> Changes in v4:
> Removed unused PCI definitions which were left in v3
>
> Changes in v3:
> Renamed all local PCI definitions to Generic names.
> Corrected coding style mistakes.
>
> Changes in v2:
> Converted individual patches to a series.
> Made sure that individual patches build correctly
>
> Puranjay Mohan (3):
> net: fddi: skfp: Rename local PCI defines to match generic PCI defines
> net: fddi: skfp: Include generic PCI definitions
> net: fddi: skfp: Remove unused private PCI definitions
>
> drivers/net/fddi/skfp/drvfbi.c | 3 +-
> drivers/net/fddi/skfp/h/skfbi.h | 217 +-------------------------------
> 2 files changed, 6 insertions(+), 214 deletions(-)
>
> --
> 2.21.0
>
WARNING: multiple messages have this Message-ID (diff)
From: Puranjay Mohan <puranjay12@gmail.com>
To: Shuah Khan <skhan@linuxfoundation.org>
Cc: Puranjay Mohan <puranjay12@gmail.com>,
Bjorn Helgaas <bjorn@helgaas.com>,
netdev <netdev@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-kernel-mentees@lists.linuxfoundation.org,
linux-pci@vger.kernel.org,
Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH v4 0/3] net: fddi: skfp: Use PCI generic definitions instead of private duplicates
Date: Fri, 21 Jun 2019 20:49:28 +0530 [thread overview]
Message-ID: <20190621151927.GA12091@arch> (raw)
In-Reply-To: <20190621151415.10795-1-puranjay12@gmail.com>
On Fri, Jun 21, 2019 at 08:44:12PM +0530, Puranjay Mohan wrote:
> This patch series removes the private duplicates of PCI definitions in
> favour of generic definitions defined in pci_regs.h.
>
> This driver only uses some of the generic PCI definitons,
> which are included from pci_regs.h and thier private versions
> are removed from skfbi.h with all other private defines.
>
> The skfbi.h defines PCI_REV_ID and other private defines with different
> names, these are renamed to Generic PCI names to make them
> compatible with defines in pci_regs.h.
>
> All unused defines are removed from skfbi.h.
>
I left some of the definitions in v4 too!
will remove them all and send v5
sorry for the inconvenience
> Changes in v4:
> Removed unused PCI definitions which were left in v3
>
> Changes in v3:
> Renamed all local PCI definitions to Generic names.
> Corrected coding style mistakes.
>
> Changes in v2:
> Converted individual patches to a series.
> Made sure that individual patches build correctly
>
> Puranjay Mohan (3):
> net: fddi: skfp: Rename local PCI defines to match generic PCI defines
> net: fddi: skfp: Include generic PCI definitions
> net: fddi: skfp: Remove unused private PCI definitions
>
> drivers/net/fddi/skfp/drvfbi.c | 3 +-
> drivers/net/fddi/skfp/h/skfbi.h | 217 +-------------------------------
> 2 files changed, 6 insertions(+), 214 deletions(-)
>
> --
> 2.21.0
>
next prev parent reply other threads:[~2019-06-21 15:19 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-21 15:14 [Linux-kernel-mentees] [PATCH v4 0/3] net: fddi: skfp: Use PCI generic definitions instead of private duplicates puranjay12
2019-06-21 15:14 ` Puranjay Mohan
2019-06-21 15:14 ` [Linux-kernel-mentees] " Puranjay Mohan
2019-06-21 15:14 ` [Linux-kernel-mentees] [PATCH v4 1/3] net: fddi: skfp: Rename local PCI defines to match generic PCI defines puranjay12
2019-06-21 15:14 ` Puranjay Mohan
2019-06-21 15:14 ` [Linux-kernel-mentees] " Puranjay Mohan
2019-06-21 15:14 ` [Linux-kernel-mentees] [PATCH v4 2/3] net: fddi: skfp: Include generic PCI definitions puranjay12
2019-06-21 15:14 ` Puranjay Mohan
2019-06-21 15:14 ` [Linux-kernel-mentees] " Puranjay Mohan
2019-06-21 15:14 ` [Linux-kernel-mentees] [PATCH v4 3/3] net: fddi: skfp: Remove unused private " puranjay12
2019-06-21 15:14 ` Puranjay Mohan
2019-06-21 15:14 ` [Linux-kernel-mentees] " Puranjay Mohan
2019-06-21 15:19 ` puranjay12 [this message]
2019-06-21 15:19 ` [PATCH v4 0/3] net: fddi: skfp: Use PCI generic definitions instead of private duplicates Puranjay Mohan
2019-06-21 15:19 ` [Linux-kernel-mentees] " Puranjay Mohan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190621151927.GA12091@arch \
--to=unknown@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.