From: Segher Boessenkool <segher@kernel.crashing.org>
To: Nicholas Piggin <npiggin@gmail.com>
Cc: linuxppc-dev@lists.ozlabs.org, kvm-ppc@vger.kernel.org
Subject: Re: [PATCH 1/2] powerpc/64s: Rename PPC_INVALIDATE_ERAT to PPC_ARCH_300_INVALIDATE_ERAT
Date: Sun, 23 Jun 2019 12:03:32 +0000 [thread overview]
Message-ID: <20190623120332.GA7313@gate.crashing.org> (raw)
In-Reply-To: <20190623104152.13173-1-npiggin@gmail.com>
On Sun, Jun 23, 2019 at 08:41:51PM +1000, Nicholas Piggin wrote:
> This makes it clear to the caller that it can only be used on POWER9
> and later CPUs.
> -#define PPC_INVALIDATE_ERAT PPC_SLBIA(7)
> +#define PPC_ARCH_300_INVALIDATE_ERAT PPC_SLBIA(7)
The architecture version is 3.0 (or 3.0B), not "300". This will work on
implementations of later architecture versions as well, so maybe the name
isn't so great anyway?
Segher
WARNING: multiple messages have this Message-ID (diff)
From: Segher Boessenkool <segher@kernel.crashing.org>
To: Nicholas Piggin <npiggin@gmail.com>
Cc: linuxppc-dev@lists.ozlabs.org, kvm-ppc@vger.kernel.org
Subject: Re: [PATCH 1/2] powerpc/64s: Rename PPC_INVALIDATE_ERAT to PPC_ARCH_300_INVALIDATE_ERAT
Date: Sun, 23 Jun 2019 07:03:32 -0500 [thread overview]
Message-ID: <20190623120332.GA7313@gate.crashing.org> (raw)
In-Reply-To: <20190623104152.13173-1-npiggin@gmail.com>
On Sun, Jun 23, 2019 at 08:41:51PM +1000, Nicholas Piggin wrote:
> This makes it clear to the caller that it can only be used on POWER9
> and later CPUs.
> -#define PPC_INVALIDATE_ERAT PPC_SLBIA(7)
> +#define PPC_ARCH_300_INVALIDATE_ERAT PPC_SLBIA(7)
The architecture version is 3.0 (or 3.0B), not "300". This will work on
implementations of later architecture versions as well, so maybe the name
isn't so great anyway?
Segher
next prev parent reply other threads:[~2019-06-23 12:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-23 10:41 [PATCH 1/2] powerpc/64s: Rename PPC_INVALIDATE_ERAT to PPC_ARCH_300_INVALIDATE_ERAT Nicholas Piggin
2019-06-23 10:41 ` Nicholas Piggin
2019-06-23 10:41 ` [PATCH 2/2] powerpc/64s/radix: keep kernel ERAT over local process/guest invalidates Nicholas Piggin
2019-06-23 10:41 ` Nicholas Piggin
2019-06-23 12:03 ` Segher Boessenkool [this message]
2019-06-23 12:03 ` [PATCH 1/2] powerpc/64s: Rename PPC_INVALIDATE_ERAT to PPC_ARCH_300_INVALIDATE_ERAT Segher Boessenkool
2019-06-23 13:42 ` Nicholas Piggin
2019-06-23 13:42 ` Nicholas Piggin
2019-06-24 11:39 ` Michael Ellerman
2019-06-24 11:39 ` Michael Ellerman
2019-07-04 15:52 ` Michael Ellerman
2019-07-04 15:52 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190623120332.GA7313@gate.crashing.org \
--to=segher@kernel.crashing.org \
--cc=kvm-ppc@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=npiggin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.