All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shawn Guo <shawnguo@kernel.org>
To: "Sébastien Szymanski" <sebastien.szymanski@armadeus.com>
Cc: "Mark Rutland" <mark.rutland@arm.com>,
	devicetree@vger.kernel.org,
	"Sascha Hauer" <s.hauer@pengutronix.de>,
	"Rob Herring" <robh+dt@kernel.org>,
	"NXP Linux Team" <linux-imx@nxp.com>,
	"Pengutronix Kernel Team" <kernel@pengutronix.de>,
	"Fabio Estevam" <festevam@gmail.com>,
	linux-arm-kernel@lists.infradead.org,
	"Lothar Waßmann" <LW@KARO-electronics.de>
Subject: Re: [PATCH 1/1] ARM: dts: imx6ul: fix PWM[1-4] interrupts
Date: Mon, 24 Jun 2019 21:14:18 +0800	[thread overview]
Message-ID: <20190624131417.GB16146@dragon> (raw)
In-Reply-To: <670f98af-2c55-de1f-d36c-37d1f33086c7@armadeus.com>

On Mon, Jun 24, 2019 at 09:36:37AM +0200, Sébastien Szymanski wrote:
> Hello,
> 
> On 6/24/19 2:47 AM, Shawn Guo wrote:
> > +Lothar
> > 
> > On Tue, Jun 18, 2019 at 05:58:34PM +0200, Sébastien Szymanski wrote:
> >> According to the i.MX6UL/L RM, table 3.1 "ARM Cortex A7 domain interrupt
> >> summary", the interrupts for the PWM[1-4] go from 83 to 86.
> >>
> >> Fixes: b9901fe84f02 ("ARM: dts: imx6ul: add pwm[1-4] nodes")
> >> Signed-off-by: Sébastien Szymanski <sebastien.szymanski@armadeus.com>
> > 
> > Just curious - did you spot the error by testing PWM or merely by
> > looking at the code and document?
> 
> I spotted the error when trying to play sound with PWM [1].
> The PWM driver (drivers/pwm/pwm-imx27.c) don't use interrupt that's
> probably why nobody notice this error.

Thanks for the info.  Patch applied, thanks.

Shawn

> 
> [1] https://github.com/sasamy/imx-snd-pwm

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo@kernel.org>
To: "Sébastien Szymanski" <sebastien.szymanski@armadeus.com>
Cc: "Mark Rutland" <mark.rutland@arm.com>,
	devicetree@vger.kernel.org,
	"Sascha Hauer" <s.hauer@pengutronix.de>,
	"Rob Herring" <robh+dt@kernel.org>,
	"NXP Linux Team" <linux-imx@nxp.com>,
	"Pengutronix Kernel Team" <kernel@pengutronix.de>,
	"Fabio Estevam" <festevam@gmail.com>,
	linux-arm-kernel@lists.infradead.org,
	"Lothar Waßmann" <LW@KARO-electronics.de>
Subject: Re: [PATCH 1/1] ARM: dts: imx6ul: fix PWM[1-4] interrupts
Date: Mon, 24 Jun 2019 21:14:18 +0800	[thread overview]
Message-ID: <20190624131417.GB16146@dragon> (raw)
In-Reply-To: <670f98af-2c55-de1f-d36c-37d1f33086c7@armadeus.com>

On Mon, Jun 24, 2019 at 09:36:37AM +0200, Sébastien Szymanski wrote:
> Hello,
> 
> On 6/24/19 2:47 AM, Shawn Guo wrote:
> > +Lothar
> > 
> > On Tue, Jun 18, 2019 at 05:58:34PM +0200, Sébastien Szymanski wrote:
> >> According to the i.MX6UL/L RM, table 3.1 "ARM Cortex A7 domain interrupt
> >> summary", the interrupts for the PWM[1-4] go from 83 to 86.
> >>
> >> Fixes: b9901fe84f02 ("ARM: dts: imx6ul: add pwm[1-4] nodes")
> >> Signed-off-by: Sébastien Szymanski <sebastien.szymanski@armadeus.com>
> > 
> > Just curious - did you spot the error by testing PWM or merely by
> > looking at the code and document?
> 
> I spotted the error when trying to play sound with PWM [1].
> The PWM driver (drivers/pwm/pwm-imx27.c) don't use interrupt that's
> probably why nobody notice this error.

Thanks for the info.  Patch applied, thanks.

Shawn

> 
> [1] https://github.com/sasamy/imx-snd-pwm

  reply	other threads:[~2019-06-24 13:20 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-18 15:58 [PATCH 1/1] ARM: dts: imx6ul: fix PWM[1-4] interrupts Sébastien Szymanski
2019-06-18 16:43 ` Fabio Estevam
2019-06-24  0:47 ` Shawn Guo
2019-06-24  0:47   ` Shawn Guo
2019-06-24  7:36   ` Sébastien Szymanski
2019-06-24 13:14     ` Shawn Guo [this message]
2019-06-24 13:14       ` Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190624131417.GB16146@dragon \
    --to=shawnguo@kernel.org \
    --cc=LW@KARO-electronics.de \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=sebastien.szymanski@armadeus.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.