* [PATCH 1/5] drm: Do not use bitwise OR to set picure_aspect_ratio
2019-06-20 14:26 [PATCH 0/5] drm: Aspect ratio fixes Ville Syrjala
@ 2019-06-20 14:26 ` Ville Syrjala
2019-06-20 14:26 ` [PATCH 2/5] drm: Do not accept garbage mode aspect ratio flags Ville Syrjala
` (6 subsequent siblings)
7 siblings, 0 replies; 15+ messages in thread
From: Ville Syrjala @ 2019-06-20 14:26 UTC (permalink / raw)
To: dri-devel; +Cc: intel-gfx
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
enum hdmi_picture_aspect is not a bitmask, so don't use bitwise OR
to populate it.
Cc: Ilia Mirkin <imirkin@alum.mit.edu>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/drm_modes.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/drm_modes.c b/drivers/gpu/drm/drm_modes.c
index 57e6408288c8..53acc6756ee0 100644
--- a/drivers/gpu/drm/drm_modes.c
+++ b/drivers/gpu/drm/drm_modes.c
@@ -1966,16 +1966,16 @@ int drm_mode_convert_umode(struct drm_device *dev,
switch (in->flags & DRM_MODE_FLAG_PIC_AR_MASK) {
case DRM_MODE_FLAG_PIC_AR_4_3:
- out->picture_aspect_ratio |= HDMI_PICTURE_ASPECT_4_3;
+ out->picture_aspect_ratio = HDMI_PICTURE_ASPECT_4_3;
break;
case DRM_MODE_FLAG_PIC_AR_16_9:
- out->picture_aspect_ratio |= HDMI_PICTURE_ASPECT_16_9;
+ out->picture_aspect_ratio = HDMI_PICTURE_ASPECT_16_9;
break;
case DRM_MODE_FLAG_PIC_AR_64_27:
- out->picture_aspect_ratio |= HDMI_PICTURE_ASPECT_64_27;
+ out->picture_aspect_ratio = HDMI_PICTURE_ASPECT_64_27;
break;
case DRM_MODE_FLAG_PIC_AR_256_135:
- out->picture_aspect_ratio |= HDMI_PICTURE_ASPECT_256_135;
+ out->picture_aspect_ratio = HDMI_PICTURE_ASPECT_256_135;
break;
default:
out->picture_aspect_ratio = HDMI_PICTURE_ASPECT_NONE;
--
2.21.0
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 15+ messages in thread* [PATCH 2/5] drm: Do not accept garbage mode aspect ratio flags
2019-06-20 14:26 [PATCH 0/5] drm: Aspect ratio fixes Ville Syrjala
2019-06-20 14:26 ` [PATCH 1/5] drm: Do not use bitwise OR to set picure_aspect_ratio Ville Syrjala
@ 2019-06-20 14:26 ` Ville Syrjala
2019-06-20 14:26 ` [PATCH 3/5] drm: WARN on illegal aspect ratio when converting a mode to umode Ville Syrjala
` (5 subsequent siblings)
7 siblings, 0 replies; 15+ messages in thread
From: Ville Syrjala @ 2019-06-20 14:26 UTC (permalink / raw)
To: dri-devel; +Cc: intel-gfx, Ilia Mirkin
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
Don't let userspace feed us any old garbage in the mode aspect ratio
flags.
Cc: Ilia Mirkin <imirkin@alum.mit.edu>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/drm_modes.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/drm_modes.c b/drivers/gpu/drm/drm_modes.c
index 53acc6756ee0..847048dee048 100644
--- a/drivers/gpu/drm/drm_modes.c
+++ b/drivers/gpu/drm/drm_modes.c
@@ -1977,9 +1977,11 @@ int drm_mode_convert_umode(struct drm_device *dev,
case DRM_MODE_FLAG_PIC_AR_256_135:
out->picture_aspect_ratio = HDMI_PICTURE_ASPECT_256_135;
break;
- default:
+ case DRM_MODE_FLAG_PIC_AR_NONE:
out->picture_aspect_ratio = HDMI_PICTURE_ASPECT_NONE;
break;
+ default:
+ return -EINVAL;
}
out->status = drm_mode_validate_driver(dev, out);
--
2.21.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 15+ messages in thread* [PATCH 3/5] drm: WARN on illegal aspect ratio when converting a mode to umode
2019-06-20 14:26 [PATCH 0/5] drm: Aspect ratio fixes Ville Syrjala
2019-06-20 14:26 ` [PATCH 1/5] drm: Do not use bitwise OR to set picure_aspect_ratio Ville Syrjala
2019-06-20 14:26 ` [PATCH 2/5] drm: Do not accept garbage mode aspect ratio flags Ville Syrjala
@ 2019-06-20 14:26 ` Ville Syrjala
2019-06-20 14:26 ` [PATCH 4/5] drm/i915: Do not override mode's aspect ratio with the prop value NONE Ville Syrjala
` (4 subsequent siblings)
7 siblings, 0 replies; 15+ messages in thread
From: Ville Syrjala @ 2019-06-20 14:26 UTC (permalink / raw)
To: dri-devel; +Cc: intel-gfx, Ilia Mirkin
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
WARN if the incoming drm_display_mode has an illegal aspect ratio
when converting it to a user mode. This should never happen unless
the driver made a mistake and put an invalid value into the aspect
ratio.
Cc: Ilia Mirkin <imirkin@alum.mit.edu>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/drm_modes.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/drm_modes.c b/drivers/gpu/drm/drm_modes.c
index 847048dee048..be2ccd8eccfd 100644
--- a/drivers/gpu/drm/drm_modes.c
+++ b/drivers/gpu/drm/drm_modes.c
@@ -1906,8 +1906,11 @@ void drm_mode_convert_to_umode(struct drm_mode_modeinfo *out,
case HDMI_PICTURE_ASPECT_256_135:
out->flags |= DRM_MODE_FLAG_PIC_AR_256_135;
break;
- case HDMI_PICTURE_ASPECT_RESERVED:
default:
+ WARN(1, "Invalid aspect ratio (0%x) on mode\n",
+ in->picture_aspect_ratio);
+ /* fall through */
+ case HDMI_PICTURE_ASPECT_NONE:
out->flags |= DRM_MODE_FLAG_PIC_AR_NONE;
break;
}
--
2.21.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 15+ messages in thread* [PATCH 4/5] drm/i915: Do not override mode's aspect ratio with the prop value NONE
2019-06-20 14:26 [PATCH 0/5] drm: Aspect ratio fixes Ville Syrjala
` (2 preceding siblings ...)
2019-06-20 14:26 ` [PATCH 3/5] drm: WARN on illegal aspect ratio when converting a mode to umode Ville Syrjala
@ 2019-06-20 14:26 ` Ville Syrjala
2019-11-14 14:19 ` Shankar, Uma
2019-06-20 14:26 ` [PATCH 5/5] drm/i915: Drop redundant aspec ratio prop value initialization Ville Syrjala
` (3 subsequent siblings)
7 siblings, 1 reply; 15+ messages in thread
From: Ville Syrjala @ 2019-06-20 14:26 UTC (permalink / raw)
To: dri-devel; +Cc: intel-gfx
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
HDMI_PICTURE_ASPECT_NONE means "Automatic" so when the user has that
selected we should keep whatever aspect ratio the mode already has.
Also no point in checking for connector->is_hdmi in the SDVO code
since we only attach the property to HDMI connectors.
Cc: Ilia Mirkin <imirkin@alum.mit.edu>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/i915/display/intel_hdmi.c | 5 +++--
drivers/gpu/drm/i915/display/intel_sdvo.c | 6 +++---
2 files changed, 6 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_hdmi.c b/drivers/gpu/drm/i915/display/intel_hdmi.c
index 0ebec69bbbfc..6a4650b44ac6 100644
--- a/drivers/gpu/drm/i915/display/intel_hdmi.c
+++ b/drivers/gpu/drm/i915/display/intel_hdmi.c
@@ -2394,8 +2394,9 @@ int intel_hdmi_compute_config(struct intel_encoder *encoder,
return -EINVAL;
}
- /* Set user selected PAR to incoming mode's member */
- adjusted_mode->picture_aspect_ratio = conn_state->picture_aspect_ratio;
+ if (conn_state->picture_aspect_ratio)
+ adjusted_mode->picture_aspect_ratio =
+ conn_state->picture_aspect_ratio;
pipe_config->lane_count = 4;
diff --git a/drivers/gpu/drm/i915/display/intel_sdvo.c b/drivers/gpu/drm/i915/display/intel_sdvo.c
index ceda03e5a3d4..5cb619613157 100644
--- a/drivers/gpu/drm/i915/display/intel_sdvo.c
+++ b/drivers/gpu/drm/i915/display/intel_sdvo.c
@@ -1321,9 +1321,9 @@ static int intel_sdvo_compute_config(struct intel_encoder *encoder,
if (IS_TV(intel_sdvo_connector))
i9xx_adjust_sdvo_tv_clock(pipe_config);
- /* Set user selected PAR to incoming mode's member */
- if (intel_sdvo_connector->is_hdmi)
- adjusted_mode->picture_aspect_ratio = conn_state->picture_aspect_ratio;
+ if (conn_state->picture_aspect_ratio)
+ adjusted_mode->picture_aspect_ratio =
+ conn_state->picture_aspect_ratio;
if (!intel_sdvo_compute_avi_infoframe(intel_sdvo,
pipe_config, conn_state)) {
--
2.21.0
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 15+ messages in thread* Re: [PATCH 4/5] drm/i915: Do not override mode's aspect ratio with the prop value NONE
@ 2019-11-14 14:19 ` Shankar, Uma
0 siblings, 0 replies; 15+ messages in thread
From: Shankar, Uma @ 2019-11-14 14:19 UTC (permalink / raw)
To: Ville Syrjala, dri-devel@lists.freedesktop.org
Cc: intel-gfx@lists.freedesktop.org
>-----Original Message-----
>From: dri-devel <dri-devel-bounces@lists.freedesktop.org> On Behalf Of Ville Syrjala
>Sent: Thursday, June 20, 2019 7:57 PM
>To: dri-devel@lists.freedesktop.org
>Cc: intel-gfx@lists.freedesktop.org
>Subject: [PATCH 4/5] drm/i915: Do not override mode's aspect ratio with the prop
>value NONE
>
>From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
>HDMI_PICTURE_ASPECT_NONE means "Automatic" so when the user has that
>selected we should keep whatever aspect ratio the mode already has.
>
>Also no point in checking for connector->is_hdmi in the SDVO code since we only
>attach the property to HDMI connectors.
Looks good to me.
Reviewed-by: Uma Shankar <uma.shankar@intel.com>
>Cc: Ilia Mirkin <imirkin@alum.mit.edu>
>Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>---
> drivers/gpu/drm/i915/display/intel_hdmi.c | 5 +++--
>drivers/gpu/drm/i915/display/intel_sdvo.c | 6 +++---
> 2 files changed, 6 insertions(+), 5 deletions(-)
>
>diff --git a/drivers/gpu/drm/i915/display/intel_hdmi.c
>b/drivers/gpu/drm/i915/display/intel_hdmi.c
>index 0ebec69bbbfc..6a4650b44ac6 100644
>--- a/drivers/gpu/drm/i915/display/intel_hdmi.c
>+++ b/drivers/gpu/drm/i915/display/intel_hdmi.c
>@@ -2394,8 +2394,9 @@ int intel_hdmi_compute_config(struct intel_encoder
>*encoder,
> return -EINVAL;
> }
>
>- /* Set user selected PAR to incoming mode's member */
>- adjusted_mode->picture_aspect_ratio = conn_state->picture_aspect_ratio;
>+ if (conn_state->picture_aspect_ratio)
>+ adjusted_mode->picture_aspect_ratio =
>+ conn_state->picture_aspect_ratio;
>
> pipe_config->lane_count = 4;
>
>diff --git a/drivers/gpu/drm/i915/display/intel_sdvo.c
>b/drivers/gpu/drm/i915/display/intel_sdvo.c
>index ceda03e5a3d4..5cb619613157 100644
>--- a/drivers/gpu/drm/i915/display/intel_sdvo.c
>+++ b/drivers/gpu/drm/i915/display/intel_sdvo.c
>@@ -1321,9 +1321,9 @@ static int intel_sdvo_compute_config(struct intel_encoder
>*encoder,
> if (IS_TV(intel_sdvo_connector))
> i9xx_adjust_sdvo_tv_clock(pipe_config);
>
>- /* Set user selected PAR to incoming mode's member */
>- if (intel_sdvo_connector->is_hdmi)
>- adjusted_mode->picture_aspect_ratio = conn_state-
>>picture_aspect_ratio;
>+ if (conn_state->picture_aspect_ratio)
>+ adjusted_mode->picture_aspect_ratio =
>+ conn_state->picture_aspect_ratio;
>
> if (!intel_sdvo_compute_avi_infoframe(intel_sdvo,
> pipe_config, conn_state)) {
>--
>2.21.0
>
>_______________________________________________
>dri-devel mailing list
>dri-devel@lists.freedesktop.org
>https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 15+ messages in thread* Re: [Intel-gfx] [PATCH 4/5] drm/i915: Do not override mode's aspect ratio with the prop value NONE
@ 2019-11-14 14:19 ` Shankar, Uma
0 siblings, 0 replies; 15+ messages in thread
From: Shankar, Uma @ 2019-11-14 14:19 UTC (permalink / raw)
To: Ville Syrjala, dri-devel@lists.freedesktop.org
Cc: intel-gfx@lists.freedesktop.org
>-----Original Message-----
>From: dri-devel <dri-devel-bounces@lists.freedesktop.org> On Behalf Of Ville Syrjala
>Sent: Thursday, June 20, 2019 7:57 PM
>To: dri-devel@lists.freedesktop.org
>Cc: intel-gfx@lists.freedesktop.org
>Subject: [PATCH 4/5] drm/i915: Do not override mode's aspect ratio with the prop
>value NONE
>
>From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
>HDMI_PICTURE_ASPECT_NONE means "Automatic" so when the user has that
>selected we should keep whatever aspect ratio the mode already has.
>
>Also no point in checking for connector->is_hdmi in the SDVO code since we only
>attach the property to HDMI connectors.
Looks good to me.
Reviewed-by: Uma Shankar <uma.shankar@intel.com>
>Cc: Ilia Mirkin <imirkin@alum.mit.edu>
>Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>---
> drivers/gpu/drm/i915/display/intel_hdmi.c | 5 +++--
>drivers/gpu/drm/i915/display/intel_sdvo.c | 6 +++---
> 2 files changed, 6 insertions(+), 5 deletions(-)
>
>diff --git a/drivers/gpu/drm/i915/display/intel_hdmi.c
>b/drivers/gpu/drm/i915/display/intel_hdmi.c
>index 0ebec69bbbfc..6a4650b44ac6 100644
>--- a/drivers/gpu/drm/i915/display/intel_hdmi.c
>+++ b/drivers/gpu/drm/i915/display/intel_hdmi.c
>@@ -2394,8 +2394,9 @@ int intel_hdmi_compute_config(struct intel_encoder
>*encoder,
> return -EINVAL;
> }
>
>- /* Set user selected PAR to incoming mode's member */
>- adjusted_mode->picture_aspect_ratio = conn_state->picture_aspect_ratio;
>+ if (conn_state->picture_aspect_ratio)
>+ adjusted_mode->picture_aspect_ratio =
>+ conn_state->picture_aspect_ratio;
>
> pipe_config->lane_count = 4;
>
>diff --git a/drivers/gpu/drm/i915/display/intel_sdvo.c
>b/drivers/gpu/drm/i915/display/intel_sdvo.c
>index ceda03e5a3d4..5cb619613157 100644
>--- a/drivers/gpu/drm/i915/display/intel_sdvo.c
>+++ b/drivers/gpu/drm/i915/display/intel_sdvo.c
>@@ -1321,9 +1321,9 @@ static int intel_sdvo_compute_config(struct intel_encoder
>*encoder,
> if (IS_TV(intel_sdvo_connector))
> i9xx_adjust_sdvo_tv_clock(pipe_config);
>
>- /* Set user selected PAR to incoming mode's member */
>- if (intel_sdvo_connector->is_hdmi)
>- adjusted_mode->picture_aspect_ratio = conn_state-
>>picture_aspect_ratio;
>+ if (conn_state->picture_aspect_ratio)
>+ adjusted_mode->picture_aspect_ratio =
>+ conn_state->picture_aspect_ratio;
>
> if (!intel_sdvo_compute_avi_infoframe(intel_sdvo,
> pipe_config, conn_state)) {
>--
>2.21.0
>
>_______________________________________________
>dri-devel mailing list
>dri-devel@lists.freedesktop.org
>https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 15+ messages in thread* RE: [PATCH 4/5] drm/i915: Do not override mode's aspect ratio with the prop value NONE
@ 2019-11-14 14:19 ` Shankar, Uma
0 siblings, 0 replies; 15+ messages in thread
From: Shankar, Uma @ 2019-11-14 14:19 UTC (permalink / raw)
To: Ville Syrjala, dri-devel@lists.freedesktop.org
Cc: intel-gfx@lists.freedesktop.org
>-----Original Message-----
>From: dri-devel <dri-devel-bounces@lists.freedesktop.org> On Behalf Of Ville Syrjala
>Sent: Thursday, June 20, 2019 7:57 PM
>To: dri-devel@lists.freedesktop.org
>Cc: intel-gfx@lists.freedesktop.org
>Subject: [PATCH 4/5] drm/i915: Do not override mode's aspect ratio with the prop
>value NONE
>
>From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
>HDMI_PICTURE_ASPECT_NONE means "Automatic" so when the user has that
>selected we should keep whatever aspect ratio the mode already has.
>
>Also no point in checking for connector->is_hdmi in the SDVO code since we only
>attach the property to HDMI connectors.
Looks good to me.
Reviewed-by: Uma Shankar <uma.shankar@intel.com>
>Cc: Ilia Mirkin <imirkin@alum.mit.edu>
>Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>---
> drivers/gpu/drm/i915/display/intel_hdmi.c | 5 +++--
>drivers/gpu/drm/i915/display/intel_sdvo.c | 6 +++---
> 2 files changed, 6 insertions(+), 5 deletions(-)
>
>diff --git a/drivers/gpu/drm/i915/display/intel_hdmi.c
>b/drivers/gpu/drm/i915/display/intel_hdmi.c
>index 0ebec69bbbfc..6a4650b44ac6 100644
>--- a/drivers/gpu/drm/i915/display/intel_hdmi.c
>+++ b/drivers/gpu/drm/i915/display/intel_hdmi.c
>@@ -2394,8 +2394,9 @@ int intel_hdmi_compute_config(struct intel_encoder
>*encoder,
> return -EINVAL;
> }
>
>- /* Set user selected PAR to incoming mode's member */
>- adjusted_mode->picture_aspect_ratio = conn_state->picture_aspect_ratio;
>+ if (conn_state->picture_aspect_ratio)
>+ adjusted_mode->picture_aspect_ratio =
>+ conn_state->picture_aspect_ratio;
>
> pipe_config->lane_count = 4;
>
>diff --git a/drivers/gpu/drm/i915/display/intel_sdvo.c
>b/drivers/gpu/drm/i915/display/intel_sdvo.c
>index ceda03e5a3d4..5cb619613157 100644
>--- a/drivers/gpu/drm/i915/display/intel_sdvo.c
>+++ b/drivers/gpu/drm/i915/display/intel_sdvo.c
>@@ -1321,9 +1321,9 @@ static int intel_sdvo_compute_config(struct intel_encoder
>*encoder,
> if (IS_TV(intel_sdvo_connector))
> i9xx_adjust_sdvo_tv_clock(pipe_config);
>
>- /* Set user selected PAR to incoming mode's member */
>- if (intel_sdvo_connector->is_hdmi)
>- adjusted_mode->picture_aspect_ratio = conn_state-
>>picture_aspect_ratio;
>+ if (conn_state->picture_aspect_ratio)
>+ adjusted_mode->picture_aspect_ratio =
>+ conn_state->picture_aspect_ratio;
>
> if (!intel_sdvo_compute_avi_infoframe(intel_sdvo,
> pipe_config, conn_state)) {
>--
>2.21.0
>
>_______________________________________________
>dri-devel mailing list
>dri-devel@lists.freedesktop.org
>https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH 5/5] drm/i915: Drop redundant aspec ratio prop value initialization
2019-06-20 14:26 [PATCH 0/5] drm: Aspect ratio fixes Ville Syrjala
` (3 preceding siblings ...)
2019-06-20 14:26 ` [PATCH 4/5] drm/i915: Do not override mode's aspect ratio with the prop value NONE Ville Syrjala
@ 2019-06-20 14:26 ` Ville Syrjala
2019-11-14 14:21 ` Shankar, Uma
2019-06-20 18:54 ` ✓ Fi.CI.BAT: success for drm: Aspect ratio fixes Patchwork
` (2 subsequent siblings)
7 siblings, 1 reply; 15+ messages in thread
From: Ville Syrjala @ 2019-06-20 14:26 UTC (permalink / raw)
To: dri-devel; +Cc: intel-gfx, Ilia Mirkin
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
HDMI_PICTURE_ASPECT_NONE is zero and the connector state is kzalloc()'d
so no need to initialize conn_state->picture_aspect_ratio with it.
Cc: Ilia Mirkin <imirkin@alum.mit.edu>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/i915/display/intel_hdmi.c | 1 -
drivers/gpu/drm/i915/display/intel_sdvo.c | 1 -
2 files changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_hdmi.c b/drivers/gpu/drm/i915/display/intel_hdmi.c
index 6a4650b44ac6..f95f3db5ecb8 100644
--- a/drivers/gpu/drm/i915/display/intel_hdmi.c
+++ b/drivers/gpu/drm/i915/display/intel_hdmi.c
@@ -2809,7 +2809,6 @@ intel_hdmi_add_properties(struct intel_hdmi *intel_hdmi, struct drm_connector *c
intel_attach_colorspace_property(connector);
drm_connector_attach_content_type_property(connector);
- connector->state->picture_aspect_ratio = HDMI_PICTURE_ASPECT_NONE;
if (INTEL_GEN(dev_priv) >= 10 || IS_GEMINILAKE(dev_priv))
drm_object_attach_property(&connector->base,
diff --git a/drivers/gpu/drm/i915/display/intel_sdvo.c b/drivers/gpu/drm/i915/display/intel_sdvo.c
index 5cb619613157..c471fcce59f8 100644
--- a/drivers/gpu/drm/i915/display/intel_sdvo.c
+++ b/drivers/gpu/drm/i915/display/intel_sdvo.c
@@ -2624,7 +2624,6 @@ intel_sdvo_add_hdmi_properties(struct intel_sdvo *intel_sdvo,
intel_attach_broadcast_rgb_property(&connector->base.base);
}
intel_attach_aspect_ratio_property(&connector->base.base);
- connector->base.base.state->picture_aspect_ratio = HDMI_PICTURE_ASPECT_NONE;
}
static struct intel_sdvo_connector *intel_sdvo_connector_alloc(void)
--
2.21.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 15+ messages in thread* RE: [Intel-gfx] [PATCH 5/5] drm/i915: Drop redundant aspec ratio prop value initialization
@ 2019-11-14 14:21 ` Shankar, Uma
0 siblings, 0 replies; 15+ messages in thread
From: Shankar, Uma @ 2019-11-14 14:21 UTC (permalink / raw)
To: Ville Syrjala, dri-devel@lists.freedesktop.org
Cc: intel-gfx@lists.freedesktop.org
>-----Original Message-----
>From: Intel-gfx <intel-gfx-bounces@lists.freedesktop.org> On Behalf Of Ville Syrjala
>Sent: Thursday, June 20, 2019 7:57 PM
>To: dri-devel@lists.freedesktop.org
>Cc: intel-gfx@lists.freedesktop.org; Ilia Mirkin <imirkin@alum.mit.edu>
>Subject: [Intel-gfx] [PATCH 5/5] drm/i915: Drop redundant aspec ratio prop value
>initialization
>
>From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
>HDMI_PICTURE_ASPECT_NONE is zero and the connector state is kzalloc()'d so no
>need to initialize conn_state->picture_aspect_ratio with it.
Looks good to me.
Reviewed-by: Uma Shankar <uma.shankar@intel.com>
>Cc: Ilia Mirkin <imirkin@alum.mit.edu>
>Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>---
> drivers/gpu/drm/i915/display/intel_hdmi.c | 1 -
>drivers/gpu/drm/i915/display/intel_sdvo.c | 1 -
> 2 files changed, 2 deletions(-)
>
>diff --git a/drivers/gpu/drm/i915/display/intel_hdmi.c
>b/drivers/gpu/drm/i915/display/intel_hdmi.c
>index 6a4650b44ac6..f95f3db5ecb8 100644
>--- a/drivers/gpu/drm/i915/display/intel_hdmi.c
>+++ b/drivers/gpu/drm/i915/display/intel_hdmi.c
>@@ -2809,7 +2809,6 @@ intel_hdmi_add_properties(struct intel_hdmi *intel_hdmi,
>struct drm_connector *c
> intel_attach_colorspace_property(connector);
>
> drm_connector_attach_content_type_property(connector);
>- connector->state->picture_aspect_ratio = HDMI_PICTURE_ASPECT_NONE;
>
> if (INTEL_GEN(dev_priv) >= 10 || IS_GEMINILAKE(dev_priv))
> drm_object_attach_property(&connector->base,
>diff --git a/drivers/gpu/drm/i915/display/intel_sdvo.c
>b/drivers/gpu/drm/i915/display/intel_sdvo.c
>index 5cb619613157..c471fcce59f8 100644
>--- a/drivers/gpu/drm/i915/display/intel_sdvo.c
>+++ b/drivers/gpu/drm/i915/display/intel_sdvo.c
>@@ -2624,7 +2624,6 @@ intel_sdvo_add_hdmi_properties(struct intel_sdvo
>*intel_sdvo,
> intel_attach_broadcast_rgb_property(&connector->base.base);
> }
> intel_attach_aspect_ratio_property(&connector->base.base);
>- connector->base.base.state->picture_aspect_ratio =
>HDMI_PICTURE_ASPECT_NONE;
> }
>
> static struct intel_sdvo_connector *intel_sdvo_connector_alloc(void)
>--
>2.21.0
>
>_______________________________________________
>Intel-gfx mailing list
>Intel-gfx@lists.freedesktop.org
>https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [Intel-gfx] [PATCH 5/5] drm/i915: Drop redundant aspec ratio prop value initialization
@ 2019-11-14 14:21 ` Shankar, Uma
0 siblings, 0 replies; 15+ messages in thread
From: Shankar, Uma @ 2019-11-14 14:21 UTC (permalink / raw)
To: Ville Syrjala, dri-devel@lists.freedesktop.org
Cc: intel-gfx@lists.freedesktop.org, Ilia Mirkin
>-----Original Message-----
>From: Intel-gfx <intel-gfx-bounces@lists.freedesktop.org> On Behalf Of Ville Syrjala
>Sent: Thursday, June 20, 2019 7:57 PM
>To: dri-devel@lists.freedesktop.org
>Cc: intel-gfx@lists.freedesktop.org; Ilia Mirkin <imirkin@alum.mit.edu>
>Subject: [Intel-gfx] [PATCH 5/5] drm/i915: Drop redundant aspec ratio prop value
>initialization
>
>From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
>HDMI_PICTURE_ASPECT_NONE is zero and the connector state is kzalloc()'d so no
>need to initialize conn_state->picture_aspect_ratio with it.
Looks good to me.
Reviewed-by: Uma Shankar <uma.shankar@intel.com>
>Cc: Ilia Mirkin <imirkin@alum.mit.edu>
>Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>---
> drivers/gpu/drm/i915/display/intel_hdmi.c | 1 -
>drivers/gpu/drm/i915/display/intel_sdvo.c | 1 -
> 2 files changed, 2 deletions(-)
>
>diff --git a/drivers/gpu/drm/i915/display/intel_hdmi.c
>b/drivers/gpu/drm/i915/display/intel_hdmi.c
>index 6a4650b44ac6..f95f3db5ecb8 100644
>--- a/drivers/gpu/drm/i915/display/intel_hdmi.c
>+++ b/drivers/gpu/drm/i915/display/intel_hdmi.c
>@@ -2809,7 +2809,6 @@ intel_hdmi_add_properties(struct intel_hdmi *intel_hdmi,
>struct drm_connector *c
> intel_attach_colorspace_property(connector);
>
> drm_connector_attach_content_type_property(connector);
>- connector->state->picture_aspect_ratio = HDMI_PICTURE_ASPECT_NONE;
>
> if (INTEL_GEN(dev_priv) >= 10 || IS_GEMINILAKE(dev_priv))
> drm_object_attach_property(&connector->base,
>diff --git a/drivers/gpu/drm/i915/display/intel_sdvo.c
>b/drivers/gpu/drm/i915/display/intel_sdvo.c
>index 5cb619613157..c471fcce59f8 100644
>--- a/drivers/gpu/drm/i915/display/intel_sdvo.c
>+++ b/drivers/gpu/drm/i915/display/intel_sdvo.c
>@@ -2624,7 +2624,6 @@ intel_sdvo_add_hdmi_properties(struct intel_sdvo
>*intel_sdvo,
> intel_attach_broadcast_rgb_property(&connector->base.base);
> }
> intel_attach_aspect_ratio_property(&connector->base.base);
>- connector->base.base.state->picture_aspect_ratio =
>HDMI_PICTURE_ASPECT_NONE;
> }
>
> static struct intel_sdvo_connector *intel_sdvo_connector_alloc(void)
>--
>2.21.0
>
>_______________________________________________
>Intel-gfx mailing list
>Intel-gfx@lists.freedesktop.org
>https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 15+ messages in thread
* ✓ Fi.CI.BAT: success for drm: Aspect ratio fixes
2019-06-20 14:26 [PATCH 0/5] drm: Aspect ratio fixes Ville Syrjala
` (4 preceding siblings ...)
2019-06-20 14:26 ` [PATCH 5/5] drm/i915: Drop redundant aspec ratio prop value initialization Ville Syrjala
@ 2019-06-20 18:54 ` Patchwork
2019-06-21 0:28 ` ✓ Fi.CI.IGT: " Patchwork
2019-06-21 23:28 ` [PATCH 0/5] " Alex Deucher
7 siblings, 0 replies; 15+ messages in thread
From: Patchwork @ 2019-06-20 18:54 UTC (permalink / raw)
To: Ville Syrjala; +Cc: intel-gfx
== Series Details ==
Series: drm: Aspect ratio fixes
URL : https://patchwork.freedesktop.org/series/62462/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_6314 -> Patchwork_13368
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13368/
Known issues
------------
Here are the changes found in Patchwork_13368 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_tiled_fence_blits@basic:
- fi-icl-dsi: [PASS][1] -> [INCOMPLETE][2] ([fdo#107713])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6314/fi-icl-dsi/igt@gem_tiled_fence_blits@basic.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13368/fi-icl-dsi/igt@gem_tiled_fence_blits@basic.html
* igt@i915_module_load@reload:
- fi-blb-e6850: [PASS][3] -> [INCOMPLETE][4] ([fdo#107718])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6314/fi-blb-e6850/igt@i915_module_load@reload.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13368/fi-blb-e6850/igt@i915_module_load@reload.html
* igt@i915_selftest@live_reset:
- fi-bsw-n3050: [PASS][5] -> [DMESG-WARN][6] ([fdo#107709])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6314/fi-bsw-n3050/igt@i915_selftest@live_reset.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13368/fi-bsw-n3050/igt@i915_selftest@live_reset.html
#### Possible fixes ####
* igt@i915_selftest@live_contexts:
- fi-bdw-gvtdvm: [DMESG-FAIL][7] ([fdo#110235]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6314/fi-bdw-gvtdvm/igt@i915_selftest@live_contexts.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13368/fi-bdw-gvtdvm/igt@i915_selftest@live_contexts.html
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-kbl-7500u: [FAIL][9] ([fdo#109485]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6314/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13368/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
* igt@kms_frontbuffer_tracking@basic:
- fi-hsw-peppy: [DMESG-WARN][11] ([fdo#102614]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6314/fi-hsw-peppy/igt@kms_frontbuffer_tracking@basic.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13368/fi-hsw-peppy/igt@kms_frontbuffer_tracking@basic.html
[fdo#102614]: https://bugs.freedesktop.org/show_bug.cgi?id=102614
[fdo#107709]: https://bugs.freedesktop.org/show_bug.cgi?id=107709
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
[fdo#109485]: https://bugs.freedesktop.org/show_bug.cgi?id=109485
[fdo#110235]: https://bugs.freedesktop.org/show_bug.cgi?id=110235
Participating hosts (51 -> 45)
------------------------------
Additional (1): fi-icl-u3
Missing (7): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-icl-y fi-byt-clapper fi-bdw-samus
Build changes
-------------
* Linux: CI_DRM_6314 -> Patchwork_13368
CI_DRM_6314: 1180972dbd2a00f60a4d707772bd7e7ae6732ed5 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5064: 22850c1906550fb97b405c019275dcfb34be8cf7 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_13368: bbd0fb782007481a7821ad08dbad728543f68e38 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
bbd0fb782007 drm/i915: Drop redundant aspec ratio prop value initialization
474343aa07bb drm/i915: Do not override mode's aspect ratio with the prop value NONE
7fa82047cce3 drm: WARN on illegal aspect ratio when converting a mode to umode
13826b9da126 drm: Do not accept garbage mode aspect ratio flags
5aa545cc4d79 drm: Do not use bitwise OR to set picure_aspect_ratio
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13368/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 15+ messages in thread* ✓ Fi.CI.IGT: success for drm: Aspect ratio fixes
2019-06-20 14:26 [PATCH 0/5] drm: Aspect ratio fixes Ville Syrjala
` (5 preceding siblings ...)
2019-06-20 18:54 ` ✓ Fi.CI.BAT: success for drm: Aspect ratio fixes Patchwork
@ 2019-06-21 0:28 ` Patchwork
2019-06-21 23:28 ` [PATCH 0/5] " Alex Deucher
7 siblings, 0 replies; 15+ messages in thread
From: Patchwork @ 2019-06-21 0:28 UTC (permalink / raw)
To: Ville Syrjala; +Cc: intel-gfx
== Series Details ==
Series: drm: Aspect ratio fixes
URL : https://patchwork.freedesktop.org/series/62462/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_6314_full -> Patchwork_13368_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Known issues
------------
Here are the changes found in Patchwork_13368_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_persistent_relocs@forked-thrashing:
- shard-apl: [PASS][1] -> [DMESG-WARN][2] ([fdo#110913 ]) +2 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6314/shard-apl5/igt@gem_persistent_relocs@forked-thrashing.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13368/shard-apl8/igt@gem_persistent_relocs@forked-thrashing.html
- shard-snb: [PASS][3] -> [DMESG-WARN][4] ([fdo#110789] / [fdo#110913 ])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6314/shard-snb5/igt@gem_persistent_relocs@forked-thrashing.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13368/shard-snb1/igt@gem_persistent_relocs@forked-thrashing.html
* igt@gem_userptr_blits@sync-unmap-cycles:
- shard-snb: [PASS][5] -> [DMESG-WARN][6] ([fdo#110913 ])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6314/shard-snb7/igt@gem_userptr_blits@sync-unmap-cycles.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13368/shard-snb2/igt@gem_userptr_blits@sync-unmap-cycles.html
* igt@i915_pm_rc6_residency@rc6-accuracy:
- shard-kbl: [PASS][7] -> [SKIP][8] ([fdo#109271])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6314/shard-kbl6/igt@i915_pm_rc6_residency@rc6-accuracy.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13368/shard-kbl7/igt@i915_pm_rc6_residency@rc6-accuracy.html
* igt@i915_selftest@live_hangcheck:
- shard-iclb: [PASS][9] -> [INCOMPLETE][10] ([fdo#107713] / [fdo#108569])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6314/shard-iclb6/igt@i915_selftest@live_hangcheck.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13368/shard-iclb2/igt@i915_selftest@live_hangcheck.html
* igt@kms_flip@2x-dpms-vs-vblank-race-interruptible:
- shard-glk: [PASS][11] -> [FAIL][12] ([fdo#103060])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6314/shard-glk6/igt@kms_flip@2x-dpms-vs-vblank-race-interruptible.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13368/shard-glk1/igt@kms_flip@2x-dpms-vs-vblank-race-interruptible.html
* igt@kms_flip@2x-flip-vs-suspend-interruptible:
- shard-hsw: [PASS][13] -> [INCOMPLETE][14] ([fdo#103540])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6314/shard-hsw6/igt@kms_flip@2x-flip-vs-suspend-interruptible.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13368/shard-hsw5/igt@kms_flip@2x-flip-vs-suspend-interruptible.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible:
- shard-kbl: [PASS][15] -> [FAIL][16] ([fdo#102887] / [fdo#105363])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6314/shard-kbl3/igt@kms_flip@flip-vs-expired-vblank-interruptible.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13368/shard-kbl1/igt@kms_flip@flip-vs-expired-vblank-interruptible.html
* igt@kms_frontbuffer_tracking@basic:
- shard-snb: [PASS][17] -> [SKIP][18] ([fdo#109271])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6314/shard-snb2/igt@kms_frontbuffer_tracking@basic.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13368/shard-snb5/igt@kms_frontbuffer_tracking@basic.html
* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-cur-indfb-draw-pwrite:
- shard-hsw: [PASS][19] -> [SKIP][20] ([fdo#109271]) +6 similar issues
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6314/shard-hsw2/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-cur-indfb-draw-pwrite.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13368/shard-hsw1/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-cur-indfb-draw-pwrite.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-pwrite:
- shard-iclb: [PASS][21] -> [FAIL][22] ([fdo#103167]) +4 similar issues
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6314/shard-iclb1/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-pwrite.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13368/shard-iclb6/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-pwrite.html
* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes:
- shard-apl: [PASS][23] -> [DMESG-WARN][24] ([fdo#108566]) +1 similar issue
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6314/shard-apl6/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13368/shard-apl6/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes.html
* igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min:
- shard-skl: [PASS][25] -> [FAIL][26] ([fdo#108145])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6314/shard-skl8/igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13368/shard-skl8/igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min.html
* igt@kms_plane_lowres@pipe-a-tiling-x:
- shard-iclb: [PASS][27] -> [FAIL][28] ([fdo#103166])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6314/shard-iclb3/igt@kms_plane_lowres@pipe-a-tiling-x.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13368/shard-iclb4/igt@kms_plane_lowres@pipe-a-tiling-x.html
* igt@kms_psr@psr2_primary_mmap_cpu:
- shard-iclb: [PASS][29] -> [SKIP][30] ([fdo#109441]) +3 similar issues
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6314/shard-iclb2/igt@kms_psr@psr2_primary_mmap_cpu.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13368/shard-iclb8/igt@kms_psr@psr2_primary_mmap_cpu.html
* igt@kms_sysfs_edid_timing:
- shard-iclb: [PASS][31] -> [FAIL][32] ([fdo#100047])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6314/shard-iclb8/igt@kms_sysfs_edid_timing.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13368/shard-iclb2/igt@kms_sysfs_edid_timing.html
#### Possible fixes ####
* igt@gem_exec_balancer@smoke:
- shard-iclb: [SKIP][33] ([fdo#110854]) -> [PASS][34]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6314/shard-iclb3/igt@gem_exec_balancer@smoke.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13368/shard-iclb4/igt@gem_exec_balancer@smoke.html
* igt@gem_persistent_relocs@forked-faulting-reloc-thrashing:
- shard-snb: [DMESG-WARN][35] ([fdo#110789] / [fdo#110913 ]) -> [PASS][36]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6314/shard-snb2/igt@gem_persistent_relocs@forked-faulting-reloc-thrashing.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13368/shard-snb7/igt@gem_persistent_relocs@forked-faulting-reloc-thrashing.html
* igt@gem_userptr_blits@map-fixed-invalidate-busy-gup:
- shard-apl: [DMESG-WARN][37] ([fdo#110913 ]) -> [PASS][38] +2 similar issues
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6314/shard-apl1/igt@gem_userptr_blits@map-fixed-invalidate-busy-gup.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13368/shard-apl4/igt@gem_userptr_blits@map-fixed-invalidate-busy-gup.html
* igt@i915_pm_rpm@system-suspend:
- shard-kbl: [INCOMPLETE][39] ([fdo#103665] / [fdo#107807]) -> [PASS][40]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6314/shard-kbl3/igt@i915_pm_rpm@system-suspend.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13368/shard-kbl7/igt@i915_pm_rpm@system-suspend.html
* igt@i915_pm_rps@min-max-config-loaded:
- shard-iclb: [INCOMPLETE][41] ([fdo#107713]) -> [PASS][42]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6314/shard-iclb7/igt@i915_pm_rps@min-max-config-loaded.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13368/shard-iclb4/igt@i915_pm_rps@min-max-config-loaded.html
* igt@kms_atomic_transition@plane-primary-toggle-with-vblank-wait:
- shard-snb: [SKIP][43] ([fdo#109271]) -> [PASS][44] +1 similar issue
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6314/shard-snb2/igt@kms_atomic_transition@plane-primary-toggle-with-vblank-wait.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13368/shard-snb7/igt@kms_atomic_transition@plane-primary-toggle-with-vblank-wait.html
* igt@kms_busy@extended-modeset-hang-newfb-render-a:
- shard-snb: [SKIP][45] ([fdo#109271] / [fdo#109278]) -> [PASS][46]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6314/shard-snb2/igt@kms_busy@extended-modeset-hang-newfb-render-a.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13368/shard-snb7/igt@kms_busy@extended-modeset-hang-newfb-render-a.html
* igt@kms_cursor_legacy@cursor-vs-flip-varying-size:
- shard-hsw: [FAIL][47] ([fdo#103355]) -> [PASS][48]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6314/shard-hsw5/igt@kms_cursor_legacy@cursor-vs-flip-varying-size.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13368/shard-hsw4/igt@kms_cursor_legacy@cursor-vs-flip-varying-size.html
* igt@kms_flip@flip-vs-suspend:
- shard-glk: [INCOMPLETE][49] ([fdo#103359] / [k.org#198133]) -> [PASS][50]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6314/shard-glk7/igt@kms_flip@flip-vs-suspend.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13368/shard-glk4/igt@kms_flip@flip-vs-suspend.html
* igt@kms_flip@flip-vs-suspend-interruptible:
- shard-apl: [DMESG-WARN][51] ([fdo#108566]) -> [PASS][52]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6314/shard-apl3/igt@kms_flip@flip-vs-suspend-interruptible.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13368/shard-apl2/igt@kms_flip@flip-vs-suspend-interruptible.html
* igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-pwrite:
- shard-iclb: [FAIL][53] ([fdo#103167]) -> [PASS][54] +1 similar issue
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6314/shard-iclb4/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-pwrite.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13368/shard-iclb6/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-pwrite.html
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-pri-shrfb-draw-pwrite:
- shard-hsw: [SKIP][55] ([fdo#109271]) -> [PASS][56] +10 similar issues
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6314/shard-hsw1/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-pri-shrfb-draw-pwrite.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13368/shard-hsw7/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-pri-shrfb-draw-pwrite.html
* igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
- shard-skl: [FAIL][57] ([fdo#108145] / [fdo#110403]) -> [PASS][58]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6314/shard-skl7/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13368/shard-skl8/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
* igt@kms_psr2_su@page_flip:
- shard-iclb: [SKIP][59] ([fdo#109642]) -> [PASS][60]
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6314/shard-iclb3/igt@kms_psr2_su@page_flip.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13368/shard-iclb2/igt@kms_psr2_su@page_flip.html
* igt@kms_psr@psr2_sprite_plane_onoff:
- shard-iclb: [SKIP][61] ([fdo#109441]) -> [PASS][62]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6314/shard-iclb6/igt@kms_psr@psr2_sprite_plane_onoff.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13368/shard-iclb2/igt@kms_psr@psr2_sprite_plane_onoff.html
* igt@kms_setmode@basic:
- shard-apl: [FAIL][63] ([fdo#99912]) -> [PASS][64]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6314/shard-apl2/igt@kms_setmode@basic.html
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13368/shard-apl1/igt@kms_setmode@basic.html
- shard-kbl: [FAIL][65] ([fdo#99912]) -> [PASS][66]
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6314/shard-kbl2/igt@kms_setmode@basic.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13368/shard-kbl3/igt@kms_setmode@basic.html
#### Warnings ####
* igt@kms_vblank@pipe-c-wait-idle:
- shard-snb: [SKIP][67] ([fdo#109271] / [fdo#109278]) -> [SKIP][68] ([fdo#109271])
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6314/shard-snb2/igt@kms_vblank@pipe-c-wait-idle.html
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13368/shard-snb5/igt@kms_vblank@pipe-c-wait-idle.html
[fdo#100047]: https://bugs.freedesktop.org/show_bug.cgi?id=100047
[fdo#102887]: https://bugs.freedesktop.org/show_bug.cgi?id=102887
[fdo#103060]: https://bugs.freedesktop.org/show_bug.cgi?id=103060
[fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103355]: https://bugs.freedesktop.org/show_bug.cgi?id=103355
[fdo#103359]: https://bugs.freedesktop.org/show_bug.cgi?id=103359
[fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540
[fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
[fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#107807]: https://bugs.freedesktop.org/show_bug.cgi?id=107807
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
[fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#110403]: https://bugs.freedesktop.org/show_bug.cgi?id=110403
[fdo#110789]: https://bugs.freedesktop.org/show_bug.cgi?id=110789
[fdo#110854]: https://bugs.freedesktop.org/show_bug.cgi?id=110854
[fdo#110913 ]: https://bugs.freedesktop.org/show_bug.cgi?id=110913
[fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
[k.org#198133]: https://bugzilla.kernel.org/show_bug.cgi?id=198133
Participating hosts (10 -> 10)
------------------------------
No changes in participating hosts
Build changes
-------------
* Linux: CI_DRM_6314 -> Patchwork_13368
CI_DRM_6314: 1180972dbd2a00f60a4d707772bd7e7ae6732ed5 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5064: 22850c1906550fb97b405c019275dcfb34be8cf7 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_13368: bbd0fb782007481a7821ad08dbad728543f68e38 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13368/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 15+ messages in thread* Re: [PATCH 0/5] drm: Aspect ratio fixes
2019-06-20 14:26 [PATCH 0/5] drm: Aspect ratio fixes Ville Syrjala
` (6 preceding siblings ...)
2019-06-21 0:28 ` ✓ Fi.CI.IGT: " Patchwork
@ 2019-06-21 23:28 ` Alex Deucher
2019-06-24 15:12 ` Ville Syrjälä
7 siblings, 1 reply; 15+ messages in thread
From: Alex Deucher @ 2019-06-21 23:28 UTC (permalink / raw)
To: Ville Syrjala; +Cc: Intel Graphics Development, Maling list - DRI developers
On Thu, Jun 20, 2019 at 10:26 AM Ville Syrjala
<ville.syrjala@linux.intel.com> wrote:
>
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Ilia pointed out some oddball crap in the i915 aspect ratio handling.
> While looking at that I noticed a bunch of fail in the core as well.
> This series aims to fix it all.
>
> Cc: Ilia Mirkin <imirkin@alum.mit.edu>
>
> Ville Syrjälä (5):
> drm: Do not use bitwise OR to set picure_aspect_ratio
> drm: Do not accept garbage mode aspect ratio flags
> drm: WARN on illegal aspect ratio when converting a mode to umode
Patches 1-3:
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
> drm/i915: Do not override mode's aspect ratio with the prop value NONE
> drm/i915: Drop redundant aspec ratio prop value initialization
>
> drivers/gpu/drm/drm_modes.c | 17 +++++++++++------
> drivers/gpu/drm/i915/display/intel_hdmi.c | 5 ++---
> drivers/gpu/drm/i915/display/intel_sdvo.c | 4 +---
> 3 files changed, 14 insertions(+), 12 deletions(-)
>
> --
> 2.21.0
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 15+ messages in thread* Re: [PATCH 0/5] drm: Aspect ratio fixes
2019-06-21 23:28 ` [PATCH 0/5] " Alex Deucher
@ 2019-06-24 15:12 ` Ville Syrjälä
0 siblings, 0 replies; 15+ messages in thread
From: Ville Syrjälä @ 2019-06-24 15:12 UTC (permalink / raw)
To: Alex Deucher; +Cc: Intel Graphics Development, Maling list - DRI developers
On Fri, Jun 21, 2019 at 07:28:30PM -0400, Alex Deucher wrote:
> On Thu, Jun 20, 2019 at 10:26 AM Ville Syrjala
> <ville.syrjala@linux.intel.com> wrote:
> >
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > Ilia pointed out some oddball crap in the i915 aspect ratio handling.
> > While looking at that I noticed a bunch of fail in the core as well.
> > This series aims to fix it all.
> >
> > Cc: Ilia Mirkin <imirkin@alum.mit.edu>
> >
> > Ville Syrjälä (5):
> > drm: Do not use bitwise OR to set picure_aspect_ratio
> > drm: Do not accept garbage mode aspect ratio flags
> > drm: WARN on illegal aspect ratio when converting a mode to umode
>
> Patches 1-3:
> Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
Thanks. 1-3 pushed to drm-misc-next.
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 15+ messages in thread