All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: linux-ia64@vger.kernel.org
Subject: Re: Regression in 543cea9a - was: Re: Kernel problem on rx2800 i2
Date: Tue, 25 Jun 2019 06:59:05 +0000	[thread overview]
Message-ID: <20190625065905.GA30073@lst.de> (raw)
In-Reply-To: <1d62aadd-67b6-da13-53cc-4b5213de8937@physik.fu-berlin.de>

On Tue, Jun 25, 2019 at 08:54:11AM +0200, John Paul Adrian Glaubitz wrote:
> Okay, thanks. I'll whip up a patch for Frank to test.

The one below should do it, but from looking at the ia64 zone
initialization I'm not sure this will be the culprit.

diff --git a/kernel/dma/direct.c b/kernel/dma/direct.c
index 2c2772e9702a..3e802f4580b3 100644
--- a/kernel/dma/direct.c
+++ b/kernel/dma/direct.c
@@ -82,9 +82,7 @@ static gfp_t __dma_direct_optimal_gfp_mask(struct device *dev, u64 dma_mask,
 	 */
 	if (*phys_mask <= DMA_BIT_MASK(ARCH_ZONE_DMA_BITS))
 		return GFP_DMA;
-	if (*phys_mask <= DMA_BIT_MASK(32))
-		return GFP_DMA32;
-	return 0;
+	return GFP_DMA32;
 }
 
 static bool dma_coherent_ok(struct device *dev, phys_addr_t phys, size_t size)

  parent reply	other threads:[~2019-06-25  6:59 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-25  6:40 Regression in 543cea9a - was: Re: Kernel problem on rx2800 i2 John Paul Adrian Glaubitz
2019-06-25  6:42 ` Christoph Hellwig
2019-06-25  6:46 ` John Paul Adrian Glaubitz
2019-06-25  6:50 ` Christoph Hellwig
2019-06-25  6:54 ` John Paul Adrian Glaubitz
2019-06-25  6:59 ` Christoph Hellwig [this message]
2019-06-25  7:26 ` Frank Scheiner
2019-06-25  8:16 ` Frank Scheiner
2019-06-25  8:18 ` Christoph Hellwig
2019-06-25  8:38 ` Frank Scheiner
2019-06-25  9:30 ` Frank Scheiner
2019-06-25 10:32 ` Christoph Hellwig
2019-06-25 10:46 ` Frank Scheiner
2019-06-25 10:47 ` Christoph Hellwig
2019-06-25 11:19 ` Frank Scheiner
2019-06-25 11:21 ` John Paul Adrian Glaubitz
2019-06-25 12:00 ` Christoph Hellwig
2019-06-25 12:08 ` Frank Scheiner
2019-06-25 14:40 ` Christoph Hellwig
2019-06-25 15:52 ` Frank Scheiner
2019-06-28  6:26 ` Christoph Hellwig
2019-06-28  7:35 ` Frank Scheiner
2019-08-05  7:10 ` Christoph Hellwig
2019-08-05  8:16 ` Frank Scheiner
2020-08-05 19:43 ` John Paul Adrian Glaubitz
2020-08-05 20:27 ` Jessica Clarke
2020-08-05 21:27 ` John Paul Adrian Glaubitz
2020-08-05 22:41 ` John Paul Adrian Glaubitz
2021-03-23 15:02 ` John Paul Adrian Glaubitz
2021-03-23 15:14 ` Frank Scheiner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190625065905.GA30073@lst.de \
    --to=hch@lst.de \
    --cc=linux-ia64@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.