All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH] fs: Move mark_inode_dirty out of __generic_write_end
Date: Tue, 25 Jun 2019 12:50:11 +0200	[thread overview]
Message-ID: <20190625105011.GA2602@lst.de> (raw)
In-Reply-To: <20190625095707.GA1462@lst.de>

> That seems way more complicated.  I'd much rather go with something
> like may patch plus maybe a big fat comment explaining that persisting
> the size update is the file systems job.  Note that a lot of the modern
> file systems don't use the VFS inode tracking for that, besides XFS
> that includes at least btrfs and ocfs2 as well.

I'd suggest something like this as the baseline:

http://git.infradead.org/users/hch/xfs.git/shortlog/refs/heads/iomap-i_size



WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Andreas Gruenbacher <agruenba@redhat.com>
Cc: Christoph Hellwig <hch@lst.de>,
	cluster-devel@redhat.com, linux-fsdevel@vger.kernel.org,
	Jan Kara <jack@suse.cz>
Subject: Re: [PATCH] fs: Move mark_inode_dirty out of __generic_write_end
Date: Tue, 25 Jun 2019 12:50:11 +0200	[thread overview]
Message-ID: <20190625105011.GA2602@lst.de> (raw)
In-Reply-To: <20190625095707.GA1462@lst.de>

> That seems way more complicated.  I'd much rather go with something
> like may patch plus maybe a big fat comment explaining that persisting
> the size update is the file systems job.  Note that a lot of the modern
> file systems don't use the VFS inode tracking for that, besides XFS
> that includes at least btrfs and ocfs2 as well.

I'd suggest something like this as the baseline:

http://git.infradead.org/users/hch/xfs.git/shortlog/refs/heads/iomap-i_size

  reply	other threads:[~2019-06-25 10:50 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-18 14:47 [Cluster-devel] [PATCH] fs: Move mark_inode_dirty out of __generic_write_end Andreas Gruenbacher
2019-06-18 14:47 ` Andreas Gruenbacher
2019-06-19 16:01 ` [Cluster-devel] " Jan Kara
2019-06-19 16:01   ` Jan Kara
2019-06-20  4:47 ` [Cluster-devel] " Dave Chinner
2019-06-20  4:47   ` Dave Chinner
2019-06-24  6:54 ` [Cluster-devel] " Christoph Hellwig
2019-06-24  6:54   ` Christoph Hellwig
2019-06-24 18:22   ` [Cluster-devel] " Andreas Gruenbacher
2019-06-24 18:22     ` Andreas Gruenbacher
2019-06-25  9:57     ` [Cluster-devel] " Christoph Hellwig
2019-06-25  9:57       ` Christoph Hellwig
2019-06-25 10:50       ` Christoph Hellwig [this message]
2019-06-25 10:50         ` Christoph Hellwig
2019-06-25 18:13         ` [Cluster-devel] " Andreas Gruenbacher
2019-06-25 18:13           ` Andreas Gruenbacher
2019-06-26  6:03           ` [Cluster-devel] " Christoph Hellwig
2019-06-26  6:03             ` Christoph Hellwig
2019-06-26 12:07             ` [Cluster-devel] " Andreas Gruenbacher
2019-06-26 12:07               ` Andreas Gruenbacher
2019-06-25 15:00       ` [Cluster-devel] " Andreas Gruenbacher
2019-06-25 15:00         ` Andreas Gruenbacher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190625105011.GA2602@lst.de \
    --to=hch@lst.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.