From: Stephen Boyd <sboyd@kernel.org>
To: Charles Keepax <ckeepax@opensource.cirrus.com>, mturquette@baylibre.com
Cc: linux-clk@vger.kernel.org, patches@opensource.cirrus.com
Subject: Re: [PATCH v3 RESEND] clk: lochnagar: Use new parent_data approach to register clock parents
Date: Tue, 25 Jun 2019 16:44:59 -0700 [thread overview]
Message-ID: <20190625234500.14A052086D@mail.kernel.org> (raw)
In-Reply-To: <20190625131053.25407-1-ckeepax@opensource.cirrus.com>
Quoting Charles Keepax (2019-06-25 06:10:53)
> -static const char * const lochnagar1_clk_parents[] = {
> - "ln-none",
> - "ln-spdif-mclk",
> - "ln-psia1-mclk",
> - "ln-psia2-mclk",
> - "ln-cdc-clkout",
> - "ln-dsp-clkout",
> - "ln-pmic-32k",
> - "ln-gf-mclk1",
> - "ln-gf-mclk3",
> - "ln-gf-mclk2",
> - "ln-gf-mclk4",
> +#define LN_PARENT(NAME) { .name = NAME, .fw_name = NAME }
> +
> +static const struct clk_parent_data lochnagar1_clk_parents[] = {
> + LN_PARENT("ln-none"),
> + LN_PARENT("ln-spdif-mclk"),
The above two aren't documented in the binding. Is it intentional? I'd
like to apply this patch, but I don't want it to use undocumented
bindings.
> + LN_PARENT("ln-psia1-mclk"),
> + LN_PARENT("ln-psia2-mclk"),
> + LN_PARENT("ln-cdc-clkout"),
> + LN_PARENT("ln-dsp-clkout"),
> + LN_PARENT("ln-pmic-32k"),
> + LN_PARENT("ln-gf-mclk1"),
> + LN_PARENT("ln-gf-mclk3"),
> + LN_PARENT("ln-gf-mclk2"),
> + LN_PARENT("ln-gf-mclk4"),
> };
>
next prev parent reply other threads:[~2019-06-25 23:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-25 13:10 [PATCH v3 RESEND] clk: lochnagar: Use new parent_data approach to register clock parents Charles Keepax
2019-06-25 23:44 ` Stephen Boyd [this message]
2019-06-26 13:18 ` Charles Keepax
2019-06-26 17:55 ` Stephen Boyd
-- strict thread matches above, loose matches on Subject: below --
2019-05-31 10:32 Charles Keepax
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190625234500.14A052086D@mail.kernel.org \
--to=sboyd@kernel.org \
--cc=ckeepax@opensource.cirrus.com \
--cc=linux-clk@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=patches@opensource.cirrus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.