Re: [PATCH v3 RESEND] clk: lochnagar: Use new parent_data approach to register clock parents

[Stephen Boyd <sboyd@kernel.org>]

Quoting Charles Keepax (2019-06-26 06:18:02)
> On Tue, Jun 25, 2019 at 04:44:59PM -0700, Stephen Boyd wrote:
> > Quoting Charles Keepax (2019-06-25 06:10:53)
> > > -static const char * const lochnagar1_clk_parents[] = {
> > > -       "ln-none",
> > > -       "ln-spdif-mclk",
> > > -       "ln-psia1-mclk",
> > > -       "ln-psia2-mclk",
> > > -       "ln-cdc-clkout",
> > > -       "ln-dsp-clkout",
> > > -       "ln-pmic-32k",
> > > -       "ln-gf-mclk1",
> > > -       "ln-gf-mclk3",
> > > -       "ln-gf-mclk2",
> > > -       "ln-gf-mclk4",
> > > +#define LN_PARENT(NAME) { .name = NAME, .fw_name = NAME }
> > > +
> > > +static const struct clk_parent_data lochnagar1_clk_parents[] = {
> > > +       LN_PARENT("ln-none"),
> > > +       LN_PARENT("ln-spdif-mclk"),
> > 
> > The above two aren't documented in the binding. Is it intentional? I'd
> > like to apply this patch, but I don't want it to use undocumented
> > bindings.
> > 
> 
> ln-none is intentionally missing from the binding, it isn't really
> used at the moment, it is really more of a place holder for when
> the clocks are not parented to anything as many will generate a
> clock in that case. Maybe in the future it might be used to allow
> clocks to be put back into that state after being parented but that
> probably requires more thought.

Hmm.. So basically it's a way to configure the clk to have no parent
anymore and not be orphaned but output a clk signal? I'll have to think
about this more but maybe this means we should let clks parent to
themselves to indicate that they're not using anything else to output a
clk signal, i.e. clk_set_parent(clk, clk) would make it a root clk if
it's possible.

> 
> ln-spdif-mclk should be in the binding though I will do a patch
> to add it. Do you want me to resend this patch as well? Feels
> like this stuff is orthogonal to what this patch is doing.
> 

A follow-up patch is fine for this. I'll stack it on top and merge it up
to clk-next.