* [PATCH] intel-ish-hid: Fix a use after free in load_fw_from_host()
@ 2019-06-26 10:10 Dan Carpenter
2019-06-26 11:30 ` Jiri Kosina
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2019-06-26 10:10 UTC (permalink / raw)
To: kernel-janitors
We have to print the filename first before we can kfree it.
Fixes: 91b228107da3 ("HID: intel-ish-hid: ISH firmware loader client driver")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/hid/intel-ish-hid/ishtp-fw-loader.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hid/intel-ish-hid/ishtp-fw-loader.c b/drivers/hid/intel-ish-hid/ishtp-fw-loader.c
index 22ba21457035..aa2dbed30fc3 100644
--- a/drivers/hid/intel-ish-hid/ishtp-fw-loader.c
+++ b/drivers/hid/intel-ish-hid/ishtp-fw-loader.c
@@ -816,9 +816,9 @@ static int load_fw_from_host(struct ishtp_cl_data *client_data)
goto end_err_fw_release;
release_firmware(fw);
- kfree(filename);
dev_info(cl_data_to_dev(client_data), "ISH firmware %s loaded\n",
filename);
+ kfree(filename);
return 0;
end_err_fw_release:
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] intel-ish-hid: Fix a use after free in load_fw_from_host()
2019-06-26 10:10 [PATCH] intel-ish-hid: Fix a use after free in load_fw_from_host() Dan Carpenter
@ 2019-06-26 11:30 ` Jiri Kosina
0 siblings, 0 replies; 2+ messages in thread
From: Jiri Kosina @ 2019-06-26 11:30 UTC (permalink / raw)
To: kernel-janitors
On Wed, 26 Jun 2019, Dan Carpenter wrote:
> We have to print the filename first before we can kfree it.
>
> Fixes: 91b228107da3 ("HID: intel-ish-hid: ISH firmware loader client driver")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> drivers/hid/intel-ish-hid/ishtp-fw-loader.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hid/intel-ish-hid/ishtp-fw-loader.c b/drivers/hid/intel-ish-hid/ishtp-fw-loader.c
> index 22ba21457035..aa2dbed30fc3 100644
> --- a/drivers/hid/intel-ish-hid/ishtp-fw-loader.c
> +++ b/drivers/hid/intel-ish-hid/ishtp-fw-loader.c
> @@ -816,9 +816,9 @@ static int load_fw_from_host(struct ishtp_cl_data *client_data)
> goto end_err_fw_release;
>
> release_firmware(fw);
> - kfree(filename);
> dev_info(cl_data_to_dev(client_data), "ISH firmware %s loaded\n",
> filename);
> + kfree(filename);
> return 0;
Applied, thanks Dan.
--
Jiri Kosina
SUSE Labs
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-06-26 11:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-06-26 10:10 [PATCH] intel-ish-hid: Fix a use after free in load_fw_from_host() Dan Carpenter
2019-06-26 11:30 ` Jiri Kosina
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.