From: Eric Biggers <ebiggers@kernel.org>
To: Chao Yu <yuchao0@huawei.com>
Cc: "Theodore Y . Ts'o" <tytso@mit.edu>,
"Darrick J . Wong" <darrick.wong@oracle.com>,
linux-api@vger.kernel.org, Dave Chinner <david@fromorbit.com>,
linux-f2fs-devel@lists.sourceforge.net,
linux-fscrypt@vger.kernel.org, linux-fsdevel@vger.kernel.org,
Jaegeuk Kim <jaegeuk@kernel.org>,
linux-integrity@vger.kernel.org, linux-ext4@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>,
Christoph Hellwig <hch@lst.de>,
Victor Hsieh <victorhsieh@google.com>
Subject: Re: [PATCH v5 16/16] f2fs: add fs-verity support
Date: Wed, 26 Jun 2019 11:21:39 -0700 [thread overview]
Message-ID: <20190626182138.GA30296@gmail.com> (raw)
In-Reply-To: <68c5a15f-f6a8-75e2-b485-0f1b51471995@huawei.com>
On Wed, Jun 26, 2019 at 03:34:35PM +0800, Chao Yu wrote:
> >>> + err = f2fs_convert_inline_inode(inode);
> >>> + if (err)
> >>> + return err;
> >>> +
> >>> + err = dquot_initialize(inode);
> >>> + if (err)
> >>> + return err;
> >>
> >> We can get rid of dquot_initialize() here, since f2fs_file_open() ->
> >> dquot_file_open() should has initialized quota entry previously, right?
> >
> > We still need it because dquot_file_open() only calls dquot_initialize() if the
> > file is being opened for writing. But here the file descriptor is readonly.
> > I'll add a comment explaining this here and in the ext4 equivalent.
>
> Ah, you're right.
>
> f2fs_convert_inline_inode() may grab one more block during conversion, so we
> need to call dquot_initialize() before inline conversion?
>
> Thanks,
>
Good point. I'll fix that here and in ext4.
- Eric
WARNING: multiple messages have this Message-ID (diff)
From: Eric Biggers <ebiggers@kernel.org>
To: Chao Yu <yuchao0@huawei.com>
Cc: linux-fscrypt@vger.kernel.org, linux-ext4@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
linux-fsdevel@vger.kernel.org, linux-api@vger.kernel.org,
linux-integrity@vger.kernel.org, Jaegeuk Kim <jaegeuk@kernel.org>,
"Theodore Y . Ts'o" <tytso@mit.edu>,
Victor Hsieh <victorhsieh@google.com>,
Chandan Rajendra <chandan@linux.vnet.ibm.com>,
Dave Chinner <david@fromorbit.com>,
Christoph Hellwig <hch@lst.de>,
"Darrick J . Wong" <darrick.wong@oracle.com>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH v5 16/16] f2fs: add fs-verity support
Date: Wed, 26 Jun 2019 11:21:39 -0700 [thread overview]
Message-ID: <20190626182138.GA30296@gmail.com> (raw)
In-Reply-To: <68c5a15f-f6a8-75e2-b485-0f1b51471995@huawei.com>
On Wed, Jun 26, 2019 at 03:34:35PM +0800, Chao Yu wrote:
> >>> + err = f2fs_convert_inline_inode(inode);
> >>> + if (err)
> >>> + return err;
> >>> +
> >>> + err = dquot_initialize(inode);
> >>> + if (err)
> >>> + return err;
> >>
> >> We can get rid of dquot_initialize() here, since f2fs_file_open() ->
> >> dquot_file_open() should has initialized quota entry previously, right?
> >
> > We still need it because dquot_file_open() only calls dquot_initialize() if the
> > file is being opened for writing. But here the file descriptor is readonly.
> > I'll add a comment explaining this here and in the ext4 equivalent.
>
> Ah, you're right.
>
> f2fs_convert_inline_inode() may grab one more block during conversion, so we
> need to call dquot_initialize() before inline conversion?
>
> Thanks,
>
Good point. I'll fix that here and in ext4.
- Eric
WARNING: multiple messages have this Message-ID (diff)
From: Eric Biggers <ebiggers@kernel.org>
To: Chao Yu <yuchao0@huawei.com>
Cc: "Theodore Y . Ts'o" <tytso@mit.edu>,
"Darrick J . Wong" <darrick.wong@oracle.com>,
linux-api@vger.kernel.org, Dave Chinner <david@fromorbit.com>,
linux-f2fs-devel@lists.sourceforge.net,
linux-fscrypt@vger.kernel.org, linux-fsdevel@vger.kernel.org,
Jaegeuk Kim <jaegeuk@kernel.org>,
linux-integrity@vger.kernel.org, linux-ext4@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>,
Christoph Hellwig <hch@lst.de>,
Victor Hsieh <victorhsieh@google.com>
Subject: Re: [f2fs-dev] [PATCH v5 16/16] f2fs: add fs-verity support
Date: Wed, 26 Jun 2019 11:21:39 -0700 [thread overview]
Message-ID: <20190626182138.GA30296@gmail.com> (raw)
In-Reply-To: <68c5a15f-f6a8-75e2-b485-0f1b51471995@huawei.com>
On Wed, Jun 26, 2019 at 03:34:35PM +0800, Chao Yu wrote:
> >>> + err = f2fs_convert_inline_inode(inode);
> >>> + if (err)
> >>> + return err;
> >>> +
> >>> + err = dquot_initialize(inode);
> >>> + if (err)
> >>> + return err;
> >>
> >> We can get rid of dquot_initialize() here, since f2fs_file_open() ->
> >> dquot_file_open() should has initialized quota entry previously, right?
> >
> > We still need it because dquot_file_open() only calls dquot_initialize() if the
> > file is being opened for writing. But here the file descriptor is readonly.
> > I'll add a comment explaining this here and in the ext4 equivalent.
>
> Ah, you're right.
>
> f2fs_convert_inline_inode() may grab one more block during conversion, so we
> need to call dquot_initialize() before inline conversion?
>
> Thanks,
>
Good point. I'll fix that here and in ext4.
- Eric
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2019-06-26 18:21 UTC|newest]
Thread overview: 110+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-20 20:50 [PATCH v5 00/16] fs-verity: read-only file-based authenticity protection Eric Biggers
2019-06-20 20:50 ` [f2fs-dev] " Eric Biggers
2019-06-20 20:50 ` Eric Biggers
2019-06-20 20:50 ` [PATCH v5 01/16] fs-verity: add a documentation file Eric Biggers
2019-06-20 20:50 ` [f2fs-dev] " Eric Biggers
2019-06-20 20:50 ` Eric Biggers
2019-06-22 22:10 ` Jaegeuk Kim
2019-06-22 22:10 ` [f2fs-dev] " Jaegeuk Kim
2019-06-22 22:10 ` Jaegeuk Kim
2019-06-20 20:50 ` [PATCH v5 02/16] fs-verity: add MAINTAINERS file entry Eric Biggers
2019-06-20 20:50 ` [f2fs-dev] " Eric Biggers
2019-06-20 20:50 ` Eric Biggers
2019-06-22 22:11 ` Jaegeuk Kim
2019-06-22 22:11 ` [f2fs-dev] " Jaegeuk Kim
2019-06-22 22:11 ` Jaegeuk Kim
2019-06-20 20:50 ` [PATCH v5 03/16] fs-verity: add UAPI header Eric Biggers
2019-06-20 20:50 ` [f2fs-dev] " Eric Biggers
2019-06-20 20:50 ` Eric Biggers
2019-06-22 22:11 ` Jaegeuk Kim
2019-06-22 22:11 ` [f2fs-dev] " Jaegeuk Kim
2019-06-22 22:11 ` Jaegeuk Kim
2019-06-20 20:50 ` [PATCH v5 04/16] fs: uapi: define verity bit for FS_IOC_GETFLAGS Eric Biggers
2019-06-20 20:50 ` [f2fs-dev] " Eric Biggers
2019-06-20 20:50 ` Eric Biggers
2019-06-22 22:11 ` Jaegeuk Kim
2019-06-22 22:11 ` [f2fs-dev] " Jaegeuk Kim
2019-06-22 22:11 ` Jaegeuk Kim
2019-06-20 20:50 ` [PATCH v5 05/16] fs-verity: add Kconfig and the helper functions for hashing Eric Biggers
2019-06-20 20:50 ` [f2fs-dev] " Eric Biggers
2019-06-20 20:50 ` Eric Biggers
2019-06-22 22:17 ` Jaegeuk Kim
2019-06-22 22:17 ` [f2fs-dev] " Jaegeuk Kim
2019-06-22 22:17 ` Jaegeuk Kim
2019-06-20 20:50 ` [PATCH v5 06/16] fs-verity: add inode and superblock fields Eric Biggers
2019-06-20 20:50 ` [f2fs-dev] " Eric Biggers
2019-06-20 20:50 ` Eric Biggers
2019-06-22 22:18 ` Jaegeuk Kim
2019-06-22 22:18 ` [f2fs-dev] " Jaegeuk Kim
2019-06-22 22:18 ` Jaegeuk Kim
2019-06-20 20:50 ` [PATCH v5 07/16] fs-verity: add the hook for file ->open() Eric Biggers
2019-06-20 20:50 ` [f2fs-dev] " Eric Biggers
2019-06-20 20:50 ` Eric Biggers
2019-06-22 22:28 ` Jaegeuk Kim
2019-06-22 22:28 ` [f2fs-dev] " Jaegeuk Kim
2019-06-22 22:28 ` Jaegeuk Kim
2019-06-20 20:50 ` [PATCH v5 08/16] fs-verity: add the hook for file ->setattr() Eric Biggers
2019-06-20 20:50 ` [f2fs-dev] " Eric Biggers
2019-06-20 20:50 ` Eric Biggers
2019-06-22 22:28 ` Jaegeuk Kim
2019-06-22 22:28 ` [f2fs-dev] " Jaegeuk Kim
2019-06-22 22:28 ` Jaegeuk Kim
2019-06-20 20:50 ` [PATCH v5 09/16] fs-verity: add data verification hooks for ->readpages() Eric Biggers
2019-06-20 20:50 ` [f2fs-dev] " Eric Biggers
2019-06-20 20:50 ` Eric Biggers
2019-06-22 22:32 ` Jaegeuk Kim
2019-06-22 22:32 ` [f2fs-dev] " Jaegeuk Kim
2019-06-22 22:32 ` Jaegeuk Kim
2019-06-20 20:50 ` [PATCH v5 10/16] fs-verity: implement FS_IOC_ENABLE_VERITY ioctl Eric Biggers
2019-06-20 20:50 ` [f2fs-dev] " Eric Biggers
2019-06-20 20:50 ` Eric Biggers
2019-06-22 22:43 ` Jaegeuk Kim
2019-06-22 22:43 ` [f2fs-dev] " Jaegeuk Kim
2019-06-22 22:43 ` Jaegeuk Kim
2019-06-20 20:50 ` [PATCH v5 11/16] fs-verity: implement FS_IOC_MEASURE_VERITY ioctl Eric Biggers
2019-06-20 20:50 ` [f2fs-dev] " Eric Biggers
2019-06-20 20:50 ` Eric Biggers
2019-06-22 22:43 ` Jaegeuk Kim
2019-06-22 22:43 ` [f2fs-dev] " Jaegeuk Kim
2019-06-22 22:43 ` Jaegeuk Kim
2019-06-20 20:50 ` [PATCH v5 12/16] fs-verity: add SHA-512 support Eric Biggers
2019-06-20 20:50 ` [f2fs-dev] " Eric Biggers
2019-06-20 20:50 ` Eric Biggers
2019-06-22 22:44 ` Jaegeuk Kim
2019-06-22 22:44 ` [f2fs-dev] " Jaegeuk Kim
2019-06-22 22:44 ` Jaegeuk Kim
2019-06-20 20:50 ` [PATCH v5 13/16] fs-verity: support builtin file signatures Eric Biggers
2019-06-20 20:50 ` [f2fs-dev] " Eric Biggers
2019-06-20 20:50 ` Eric Biggers
2019-06-20 20:50 ` [PATCH v5 14/16] ext4: add basic fs-verity support Eric Biggers
2019-06-20 20:50 ` [f2fs-dev] " Eric Biggers
2019-06-20 20:50 ` Eric Biggers
2019-06-20 23:59 ` Darrick J. Wong
2019-06-20 23:59 ` [f2fs-dev] " Darrick J. Wong
2019-06-20 23:59 ` Darrick J. Wong
2019-06-21 3:17 ` Eric Biggers
2019-06-21 3:17 ` [f2fs-dev] " Eric Biggers
2019-06-21 3:17 ` Eric Biggers
2019-06-20 20:50 ` [PATCH v5 15/16] ext4: add fs-verity read support Eric Biggers
2019-06-20 20:50 ` [f2fs-dev] " Eric Biggers
2019-06-20 20:50 ` Eric Biggers
2019-06-20 20:50 ` [PATCH v5 16/16] f2fs: add fs-verity support Eric Biggers
2019-06-20 20:50 ` [f2fs-dev] " Eric Biggers
2019-06-20 20:50 ` Eric Biggers
2019-06-22 23:12 ` Jaegeuk Kim
2019-06-22 23:12 ` [f2fs-dev] " Jaegeuk Kim
2019-06-22 23:12 ` Jaegeuk Kim
2019-06-25 7:55 ` Chao Yu
2019-06-25 7:55 ` Chao Yu
2019-06-25 7:55 ` [f2fs-dev] " Chao Yu
2019-06-25 7:55 ` Chao Yu
2019-06-25 17:52 ` Eric Biggers
2019-06-25 17:52 ` [f2fs-dev] " Eric Biggers
2019-06-25 17:52 ` Eric Biggers
2019-06-26 7:34 ` Chao Yu
2019-06-26 7:34 ` Chao Yu
2019-06-26 7:34 ` [f2fs-dev] " Chao Yu
2019-06-26 7:34 ` Chao Yu
2019-06-26 18:21 ` Eric Biggers [this message]
2019-06-26 18:21 ` [f2fs-dev] " Eric Biggers
2019-06-26 18:21 ` Eric Biggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190626182138.GA30296@gmail.com \
--to=ebiggers@kernel.org \
--cc=darrick.wong@oracle.com \
--cc=david@fromorbit.com \
--cc=hch@lst.de \
--cc=jaegeuk@kernel.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fscrypt@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=tytso@mit.edu \
--cc=victorhsieh@google.com \
--cc=yuchao0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.