From: Greg KH <gregkh@linuxfoundation.org>
To: Charles Keepax <ckeepax@opensource.cirrus.com>
Cc: alsa-devel@alsa-project.org, rafael@kernel.org,
patches@opensource.cirrus.com, lgirdwood@gmail.com,
linux-acpi@vger.kernel.org, broonie@kernel.org
Subject: Re: [PATCH 1/2] device property: Add new array helper
Date: Thu, 27 Jun 2019 08:15:30 +0800 [thread overview]
Message-ID: <20190627001530.GG527@kroah.com> (raw)
In-Reply-To: <20190626153611.10170-1-ckeepax@opensource.cirrus.com>
On Wed, Jun 26, 2019 at 04:36:10PM +0100, Charles Keepax wrote:
> It is fairly common to want to read an integer array property
> that is composed of an unknown number of fixed size integer
> groups. For example, say each group consists of three values
> which correspond to the settings for one input on the device
> and the driver supports several chips with different numbers
> of inputs.
>
> Add a new helper function to provide this functionality, it
> differs for the existing helpers in that it allows reading a
> smaller number of values than the full array size and checks
> that the number of values read is a multiple of the group size.
>
> Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
> ---
> drivers/base/property.c | 48 ++++++++++++++++++++++++++++++++++++++++++++++++
> include/linux/property.h | 2 ++
> 2 files changed, 50 insertions(+)
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@linuxfoundation.org>
To: Charles Keepax <ckeepax@opensource.cirrus.com>
Cc: broonie@kernel.org, rafael@kernel.org,
linux-acpi@vger.kernel.org, lgirdwood@gmail.com,
alsa-devel@alsa-project.org, patches@opensource.cirrus.com
Subject: Re: [PATCH 1/2] device property: Add new array helper
Date: Thu, 27 Jun 2019 08:15:30 +0800 [thread overview]
Message-ID: <20190627001530.GG527@kroah.com> (raw)
In-Reply-To: <20190626153611.10170-1-ckeepax@opensource.cirrus.com>
On Wed, Jun 26, 2019 at 04:36:10PM +0100, Charles Keepax wrote:
> It is fairly common to want to read an integer array property
> that is composed of an unknown number of fixed size integer
> groups. For example, say each group consists of three values
> which correspond to the settings for one input on the device
> and the driver supports several chips with different numbers
> of inputs.
>
> Add a new helper function to provide this functionality, it
> differs for the existing helpers in that it allows reading a
> smaller number of values than the full array size and checks
> that the number of values read is a multiple of the group size.
>
> Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
> ---
> drivers/base/property.c | 48 ++++++++++++++++++++++++++++++++++++++++++++++++
> include/linux/property.h | 2 ++
> 2 files changed, 50 insertions(+)
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
next prev parent reply other threads:[~2019-06-27 0:15 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-26 15:36 [PATCH 1/2] device property: Add new array helper Charles Keepax
2019-06-26 15:36 ` Charles Keepax
2019-06-26 15:36 ` [PATCH 2/2] ASoC: madera: Read device tree configuration Charles Keepax
2019-06-26 15:36 ` Charles Keepax
2019-06-27 0:15 ` Greg KH
2019-06-27 0:15 ` Greg KH
2019-06-27 0:15 ` Greg KH [this message]
2019-06-27 0:15 ` [PATCH 1/2] device property: Add new array helper Greg KH
2019-06-27 9:17 ` Rafael J. Wysocki
2019-06-27 9:17 ` Rafael J. Wysocki
2019-06-27 9:39 ` Rafael J. Wysocki
2019-06-27 9:39 ` Rafael J. Wysocki
2019-06-27 10:23 ` Charles Keepax
2019-06-27 10:23 ` Charles Keepax
2019-06-27 11:02 ` Rafael J. Wysocki
2019-06-27 11:02 ` Rafael J. Wysocki
2019-06-27 12:33 ` Charles Keepax
2019-06-27 12:33 ` Charles Keepax
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190627001530.GG527@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=ckeepax@opensource.cirrus.com \
--cc=lgirdwood@gmail.com \
--cc=linux-acpi@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.