From: Kevin Wolf <kwolf@redhat.com>
To: John Snow <jsnow@redhat.com>
Cc: qemu-block@nongnu.org, qemu-devel@nongnu.org,
Qemu-Trivial <qemu-trivial@nongnu.org>,
Max Reitz <mreitz@redhat.com>,
radmehrsaeed7@gmail.com
Subject: Re: [Qemu-trivial] [PATCH] block/qcow: Improve error when opening qcow2 files as qcow
Date: Thu, 27 Jun 2019 10:34:53 +0200 [thread overview]
Message-ID: <20190627083453.GC5618@localhost.localdomain> (raw)
In-Reply-To: <20190626215301.30733-1-jsnow@redhat.com>
Am 26.06.2019 um 23:53 hat John Snow geschrieben:
> Reported-by: radmehrsaeed7@gmail.com
> Fixes: https://bugs.launchpad.net/bugs/1832914
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
> block/qcow.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/block/qcow.c b/block/qcow.c
> index 6dee5bb792..a9cb6ae0bd 100644
> --- a/block/qcow.c
> +++ b/block/qcow.c
> @@ -156,7 +156,12 @@ static int qcow_open(BlockDriverState *bs, QDict *options, int flags,
> goto fail;
> }
> if (header.version != QCOW_VERSION) {
> - error_setg(errp, "Unsupported qcow version %" PRIu32, header.version);
> + error_setg(errp, "qcow (v%d) does not support qcow version %" PRIu32,
> + QCOW_VERSION, header.version);
> + if (header.version == 2 || header.version == 3) {
> + error_append_hint(errp, "Try the 'qcow2' driver instead.");
I think we want a \n at the end here.
Kevin
WARNING: multiple messages have this Message-ID (diff)
From: Kevin Wolf <kwolf@redhat.com>
To: John Snow <jsnow@redhat.com>
Cc: Qemu-Trivial <qemu-trivial@nongnu.org>,
radmehrsaeed7@gmail.com, qemu-devel@nongnu.org,
qemu-block@nongnu.org, Max Reitz <mreitz@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] block/qcow: Improve error when opening qcow2 files as qcow
Date: Thu, 27 Jun 2019 10:34:53 +0200 [thread overview]
Message-ID: <20190627083453.GC5618@localhost.localdomain> (raw)
In-Reply-To: <20190626215301.30733-1-jsnow@redhat.com>
Am 26.06.2019 um 23:53 hat John Snow geschrieben:
> Reported-by: radmehrsaeed7@gmail.com
> Fixes: https://bugs.launchpad.net/bugs/1832914
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
> block/qcow.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/block/qcow.c b/block/qcow.c
> index 6dee5bb792..a9cb6ae0bd 100644
> --- a/block/qcow.c
> +++ b/block/qcow.c
> @@ -156,7 +156,12 @@ static int qcow_open(BlockDriverState *bs, QDict *options, int flags,
> goto fail;
> }
> if (header.version != QCOW_VERSION) {
> - error_setg(errp, "Unsupported qcow version %" PRIu32, header.version);
> + error_setg(errp, "qcow (v%d) does not support qcow version %" PRIu32,
> + QCOW_VERSION, header.version);
> + if (header.version == 2 || header.version == 3) {
> + error_append_hint(errp, "Try the 'qcow2' driver instead.");
I think we want a \n at the end here.
Kevin
next prev parent reply other threads:[~2019-06-27 8:35 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-26 21:53 [Qemu-trivial] [PATCH] block/qcow: Improve error when opening qcow2 files as qcow John Snow
2019-06-26 21:53 ` [Qemu-devel] " John Snow
2019-06-26 23:25 ` [Qemu-trivial] " Eric Blake
2019-06-26 23:25 ` Eric Blake
2019-06-27 8:34 ` Kevin Wolf [this message]
2019-06-27 8:34 ` Kevin Wolf
2019-06-27 14:51 ` [Qemu-trivial] " Eric Blake
2019-06-27 14:51 ` Eric Blake
2019-06-27 17:17 ` [Qemu-trivial] " John Snow
2019-06-27 17:17 ` John Snow
2019-06-28 9:24 ` [Qemu-trivial] " Kevin Wolf
2019-06-28 9:24 ` Kevin Wolf
2019-06-28 16:50 ` [Qemu-trivial] " John Snow
2019-06-28 16:50 ` John Snow
2019-06-27 8:35 ` [Qemu-trivial] [Qemu-block] " Maxim Levitsky
2019-06-27 8:35 ` [Qemu-devel] " Maxim Levitsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190627083453.GC5618@localhost.localdomain \
--to=kwolf@redhat.com \
--cc=jsnow@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=radmehrsaeed7@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.