From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Make i945gm_vblank_work_func static
Date: Thu, 27 Jun 2019 15:43:21 +0300 [thread overview]
Message-ID: <20190627124321.GY5942@intel.com> (raw)
In-Reply-To: <20190626224212.10141-1-chris@chris-wilson.co.uk>
On Wed, Jun 26, 2019 at 11:42:12PM +0100, Chris Wilson wrote:
> drivers/gpu/drm/i915/i915_irq.c:3382:6: warning: symbol 'i945gm_vblank_work_func' was not declared. Should it be static?
> CC [M] drivers/gpu/drm/i915/i915_irq.o
> drivers/gpu/drm/i915/i915_irq.c:3382:6: error: no previous prototype for ‘i945gm_vblank_work_func’ [-Werror=missing-prototypes]
> void i945gm_vblank_work_func(struct work_struct *work)
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/i915_irq.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c
> index 1b83d6e2ae69..73f0338faf9f 100644
> --- a/drivers/gpu/drm/i915/i915_irq.c
> +++ b/drivers/gpu/drm/i915/i915_irq.c
> @@ -3379,7 +3379,7 @@ void bdw_disable_vblank(struct drm_crtc *crtc)
> spin_unlock_irqrestore(&dev_priv->irq_lock, irqflags);
> }
>
> -void i945gm_vblank_work_func(struct work_struct *work)
> +static void i945gm_vblank_work_func(struct work_struct *work)
Whoops. I was a bit too greedy when removing the statics.
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> {
> struct drm_i915_private *dev_priv =
> container_of(work, struct drm_i915_private, i945gm_vblank.work);
> --
> 2.20.1
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2019-06-27 12:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-26 22:42 [PATCH] drm/i915: Make i945gm_vblank_work_func static Chris Wilson
2019-06-26 23:11 ` ✗ Fi.CI.SPARSE: warning for " Patchwork
2019-06-26 23:41 ` ✗ Fi.CI.BAT: failure " Patchwork
2019-06-27 12:43 ` Ville Syrjälä [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190627124321.GY5942@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.