* [PATCH] drm/i915: Make i945gm_vblank_work_func static
@ 2019-06-26 22:42 Chris Wilson
2019-06-26 23:11 ` ✗ Fi.CI.SPARSE: warning for " Patchwork
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Chris Wilson @ 2019-06-26 22:42 UTC (permalink / raw)
To: intel-gfx
drivers/gpu/drm/i915/i915_irq.c:3382:6: warning: symbol 'i945gm_vblank_work_func' was not declared. Should it be static?
CC [M] drivers/gpu/drm/i915/i915_irq.o
drivers/gpu/drm/i915/i915_irq.c:3382:6: error: no previous prototype for ‘i945gm_vblank_work_func’ [-Werror=missing-prototypes]
void i945gm_vblank_work_func(struct work_struct *work)
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/i915/i915_irq.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c
index 1b83d6e2ae69..73f0338faf9f 100644
--- a/drivers/gpu/drm/i915/i915_irq.c
+++ b/drivers/gpu/drm/i915/i915_irq.c
@@ -3379,7 +3379,7 @@ void bdw_disable_vblank(struct drm_crtc *crtc)
spin_unlock_irqrestore(&dev_priv->irq_lock, irqflags);
}
-void i945gm_vblank_work_func(struct work_struct *work)
+static void i945gm_vblank_work_func(struct work_struct *work)
{
struct drm_i915_private *dev_priv =
container_of(work, struct drm_i915_private, i945gm_vblank.work);
--
2.20.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 4+ messages in thread* ✗ Fi.CI.SPARSE: warning for drm/i915: Make i945gm_vblank_work_func static
2019-06-26 22:42 [PATCH] drm/i915: Make i945gm_vblank_work_func static Chris Wilson
@ 2019-06-26 23:11 ` Patchwork
2019-06-26 23:41 ` ✗ Fi.CI.BAT: failure " Patchwork
2019-06-27 12:43 ` [PATCH] " Ville Syrjälä
2 siblings, 0 replies; 4+ messages in thread
From: Patchwork @ 2019-06-26 23:11 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Make i945gm_vblank_work_func static
URL : https://patchwork.freedesktop.org/series/62807/
State : warning
== Summary ==
$ dim sparse origin/drm-tip
Sparse version: v0.5.2
Commit: drm/i915: Make i945gm_vblank_work_func static
-O:drivers/gpu/drm/i915/i915_irq.c:3382:6: warning: symbol 'i945gm_vblank_work_func' was not declared. Should it be static?
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
* ✗ Fi.CI.BAT: failure for drm/i915: Make i945gm_vblank_work_func static
2019-06-26 22:42 [PATCH] drm/i915: Make i945gm_vblank_work_func static Chris Wilson
2019-06-26 23:11 ` ✗ Fi.CI.SPARSE: warning for " Patchwork
@ 2019-06-26 23:41 ` Patchwork
2019-06-27 12:43 ` [PATCH] " Ville Syrjälä
2 siblings, 0 replies; 4+ messages in thread
From: Patchwork @ 2019-06-26 23:41 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Make i945gm_vblank_work_func static
URL : https://patchwork.freedesktop.org/series/62807/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_6366 -> Patchwork_13446
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_13446 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_13446, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13446/
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_13446:
### IGT changes ###
#### Possible regressions ####
* igt@i915_pm_rpm@module-reload:
- fi-skl-6600u: [PASS][1] -> [DMESG-WARN][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6366/fi-skl-6600u/igt@i915_pm_rpm@module-reload.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13446/fi-skl-6600u/igt@i915_pm_rpm@module-reload.html
Known issues
------------
Here are the changes found in Patchwork_13446 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_create@basic-files:
- fi-icl-u2: [PASS][3] -> [INCOMPLETE][4] ([fdo#107713] / [fdo#109100])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6366/fi-icl-u2/igt@gem_ctx_create@basic-files.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13446/fi-icl-u2/igt@gem_ctx_create@basic-files.html
* igt@gem_exec_suspend@basic-s3:
- fi-cml-u: [PASS][5] -> [INCOMPLETE][6] ([fdo#110566])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6366/fi-cml-u/igt@gem_exec_suspend@basic-s3.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13446/fi-cml-u/igt@gem_exec_suspend@basic-s3.html
* igt@i915_module_load@reload:
- fi-blb-e6850: [PASS][7] -> [INCOMPLETE][8] ([fdo#107718])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6366/fi-blb-e6850/igt@i915_module_load@reload.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13446/fi-blb-e6850/igt@i915_module_load@reload.html
* igt@kms_chamelium@dp-edid-read:
- fi-kbl-7500u: [PASS][9] -> [WARN][10] ([fdo#109483])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6366/fi-kbl-7500u/igt@kms_chamelium@dp-edid-read.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13446/fi-kbl-7500u/igt@kms_chamelium@dp-edid-read.html
#### Possible fixes ####
* igt@gem_basic@create-fd-close:
- fi-icl-u3: [DMESG-WARN][11] ([fdo#107724]) -> [PASS][12] +1 similar issue
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6366/fi-icl-u3/igt@gem_basic@create-fd-close.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13446/fi-icl-u3/igt@gem_basic@create-fd-close.html
* igt@i915_pm_rpm@module-reload:
- fi-kbl-r: [DMESG-WARN][13] -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6366/fi-kbl-r/igt@i915_pm_rpm@module-reload.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13446/fi-kbl-r/igt@i915_pm_rpm@module-reload.html
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
[fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
[fdo#109100]: https://bugs.freedesktop.org/show_bug.cgi?id=109100
[fdo#109483]: https://bugs.freedesktop.org/show_bug.cgi?id=109483
[fdo#110566]: https://bugs.freedesktop.org/show_bug.cgi?id=110566
Participating hosts (52 -> 44)
------------------------------
Missing (8): fi-kbl-soraka fi-cml-u2 fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-byt-clapper fi-bdw-samus
Build changes
-------------
* Linux: CI_DRM_6366 -> Patchwork_13446
CI_DRM_6366: e15c8b4ceed84a06bef47e213d2277fdfc7df456 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5068: 15ad664534413628f06c0f172aac11598bfdb895 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_13446: fd751f61a7e012b154a64da95513473e7e42334e @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
fd751f61a7e0 drm/i915: Make i945gm_vblank_work_func static
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13446/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] drm/i915: Make i945gm_vblank_work_func static
2019-06-26 22:42 [PATCH] drm/i915: Make i945gm_vblank_work_func static Chris Wilson
2019-06-26 23:11 ` ✗ Fi.CI.SPARSE: warning for " Patchwork
2019-06-26 23:41 ` ✗ Fi.CI.BAT: failure " Patchwork
@ 2019-06-27 12:43 ` Ville Syrjälä
2 siblings, 0 replies; 4+ messages in thread
From: Ville Syrjälä @ 2019-06-27 12:43 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
On Wed, Jun 26, 2019 at 11:42:12PM +0100, Chris Wilson wrote:
> drivers/gpu/drm/i915/i915_irq.c:3382:6: warning: symbol 'i945gm_vblank_work_func' was not declared. Should it be static?
> CC [M] drivers/gpu/drm/i915/i915_irq.o
> drivers/gpu/drm/i915/i915_irq.c:3382:6: error: no previous prototype for ‘i945gm_vblank_work_func’ [-Werror=missing-prototypes]
> void i945gm_vblank_work_func(struct work_struct *work)
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/i915_irq.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c
> index 1b83d6e2ae69..73f0338faf9f 100644
> --- a/drivers/gpu/drm/i915/i915_irq.c
> +++ b/drivers/gpu/drm/i915/i915_irq.c
> @@ -3379,7 +3379,7 @@ void bdw_disable_vblank(struct drm_crtc *crtc)
> spin_unlock_irqrestore(&dev_priv->irq_lock, irqflags);
> }
>
> -void i945gm_vblank_work_func(struct work_struct *work)
> +static void i945gm_vblank_work_func(struct work_struct *work)
Whoops. I was a bit too greedy when removing the statics.
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> {
> struct drm_i915_private *dev_priv =
> container_of(work, struct drm_i915_private, i945gm_vblank.work);
> --
> 2.20.1
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-06-27 12:43 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-06-26 22:42 [PATCH] drm/i915: Make i945gm_vblank_work_func static Chris Wilson
2019-06-26 23:11 ` ✗ Fi.CI.SPARSE: warning for " Patchwork
2019-06-26 23:41 ` ✗ Fi.CI.BAT: failure " Patchwork
2019-06-27 12:43 ` [PATCH] " Ville Syrjälä
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.