From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: Eugen.Hristev@microchip.com, peda@axentia.se, robh+dt@kernel.org,
mark.rutland@arm.com, Nicolas.Ferre@microchip.com,
Ludovic.Desroches@microchip.com, linux-i2c@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
pierre-yves.mordret@st.com
Subject: Re: I2C filtering (was Re: [PATCH v2 6/9] dt-bindings: i2c: at91: add binding for enable-ana-filt)
Date: Thu, 27 Jun 2019 15:39:32 +0200 [thread overview]
Message-ID: <20190627133932.GL3692@piout.net> (raw)
In-Reply-To: <20190627133440.GA7158@ninjato>
On 27/06/2019 15:34:40+0200, Wolfram Sang wrote:
>
> > > Apart from enabling the filter there is indeed one configuration
> > > setting, the maximum pulse width of spikes to be suppressed by the input
> > > filter.
>
> Yup, this is what I anticipated.
>
> > This is a number 0 to 7 (3 bits) that represents the width of the spike
> > in periph clock cycles.
>
> For a generic binding, we would need some time-value as a parameter and
> convert it to clock cycles in the driver then, I'd think.
>
Yes, that is what I was going to suggest.
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
WARNING: multiple messages have this Message-ID (diff)
From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
pierre-yves.mordret@st.com, linux-kernel@vger.kernel.org,
Ludovic.Desroches@microchip.com, robh+dt@kernel.org,
linux-i2c@vger.kernel.org, Eugen.Hristev@microchip.com,
peda@axentia.se, linux-arm-kernel@lists.infradead.org
Subject: Re: I2C filtering (was Re: [PATCH v2 6/9] dt-bindings: i2c: at91: add binding for enable-ana-filt)
Date: Thu, 27 Jun 2019 15:39:32 +0200 [thread overview]
Message-ID: <20190627133932.GL3692@piout.net> (raw)
In-Reply-To: <20190627133440.GA7158@ninjato>
On 27/06/2019 15:34:40+0200, Wolfram Sang wrote:
>
> > > Apart from enabling the filter there is indeed one configuration
> > > setting, the maximum pulse width of spikes to be suppressed by the input
> > > filter.
>
> Yup, this is what I anticipated.
>
> > This is a number 0 to 7 (3 bits) that represents the width of the spike
> > in periph clock cycles.
>
> For a generic binding, we would need some time-value as a parameter and
> convert it to clock cycles in the driver then, I'd think.
>
Yes, that is what I was going to suggest.
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-06-27 13:39 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-25 8:04 [PATCH v2 0/9] i2c: at91: filters support for at91 SoCs Eugen.Hristev
2019-06-25 8:04 ` Eugen.Hristev
2019-06-25 8:04 ` Eugen.Hristev
2019-06-25 8:04 ` [PATCH v2 1/9] dt-bindings: i2c: at91: add new compatible Eugen.Hristev
2019-06-25 8:04 ` Eugen.Hristev
2019-06-25 8:04 ` Eugen.Hristev
2019-06-25 8:04 ` [PATCH v2 2/9] i2c: at91: add new platform support for sam9x60 Eugen.Hristev
2019-06-25 8:04 ` Eugen.Hristev
2019-06-25 8:04 ` Eugen.Hristev
2019-06-25 8:04 ` [PATCH v2 3/9] dt-bindings: i2c: at91: add binding for enable-dig-filtr Eugen.Hristev
2019-06-25 8:04 ` Eugen.Hristev
2019-06-25 8:04 ` Eugen.Hristev
2019-06-25 8:57 ` Peter Rosin
2019-06-25 8:57 ` Peter Rosin
2019-06-25 8:04 ` [PATCH v2 4/9] i2c: at91: add support for digital filtering Eugen.Hristev
2019-06-25 8:04 ` Eugen.Hristev
2019-06-25 8:04 ` Eugen.Hristev
2019-06-25 8:04 ` [PATCH v2 5/9] i2c: at91: add support for advanced " Eugen.Hristev
2019-06-25 8:04 ` Eugen.Hristev
2019-06-25 8:04 ` Eugen.Hristev
2019-06-25 8:05 ` [PATCH v2 6/9] dt-bindings: i2c: at91: add binding for enable-ana-filt Eugen.Hristev
2019-06-25 8:05 ` Eugen.Hristev
2019-06-25 8:05 ` Eugen.Hristev
2019-06-25 8:55 ` Peter Rosin
2019-06-25 8:55 ` Peter Rosin
2019-06-25 9:14 ` Eugen.Hristev
2019-06-25 9:14 ` Eugen.Hristev
2019-06-25 9:14 ` Eugen.Hristev
2019-06-25 9:31 ` Alexandre Belloni
2019-06-25 9:31 ` Alexandre Belloni
2019-06-25 9:55 ` I2C filtering (was Re: [PATCH v2 6/9] dt-bindings: i2c: at91: add binding for enable-ana-filt) Wolfram Sang
2019-06-25 9:55 ` Wolfram Sang
2019-06-27 13:22 ` Alexandre Belloni
2019-06-27 13:22 ` Alexandre Belloni
2019-06-27 13:31 ` Eugen.Hristev
2019-06-27 13:31 ` Eugen.Hristev
2019-06-27 13:31 ` Eugen.Hristev
2019-06-27 13:34 ` Wolfram Sang
2019-06-27 13:34 ` Wolfram Sang
2019-06-27 13:39 ` Alexandre Belloni [this message]
2019-06-27 13:39 ` Alexandre Belloni
2019-06-25 8:05 ` [PATCH v2 7/9] i2c: at91: add support for analog filtering Eugen.Hristev
2019-06-25 8:05 ` Eugen.Hristev
2019-06-25 8:05 ` Eugen.Hristev
2019-06-25 8:05 ` [PATCH v2 8/9] ARM: dts: at91: sama5d2_xplained: add analogic and digital filter for i2c Eugen.Hristev
2019-06-25 8:05 ` Eugen.Hristev
2019-06-25 8:05 ` Eugen.Hristev
2019-06-25 8:05 ` [PATCH v2 9/9] ARM: dts: at91: sama5d4_xplained: add analogic " Eugen.Hristev
2019-06-25 8:05 ` Eugen.Hristev
2019-06-25 8:05 ` Eugen.Hristev
2019-06-25 8:51 ` Peter Rosin
2019-06-25 8:51 ` Peter Rosin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190627133932.GL3692@piout.net \
--to=alexandre.belloni@bootlin.com \
--cc=Eugen.Hristev@microchip.com \
--cc=Ludovic.Desroches@microchip.com \
--cc=Nicolas.Ferre@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mark.rutland@arm.com \
--cc=peda@axentia.se \
--cc=pierre-yves.mordret@st.com \
--cc=robh+dt@kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.