From: Eric Biggers <ebiggers@kernel.org>
To: Keerthy <j-keerthy@ti.com>
Cc: herbert@gondor.apana.org.au, davem@davemloft.net,
robh+dt@kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
t-kristo@ti.com, linux-crypto@vger.kernel.org, nm@ti.com
Subject: Re: [RESEND PATCH 07/10] crypto: sa2ul: Add hmac(sha1) HMAC algorithm support
Date: Thu, 27 Jun 2019 22:14:12 -0700 [thread overview]
Message-ID: <20190628051412.GG673@sol.localdomain> (raw)
In-Reply-To: <20190628042745.28455-8-j-keerthy@ti.com>
On Fri, Jun 28, 2019 at 09:57:42AM +0530, Keerthy wrote:
> +static int sa_sham_update(struct ahash_request *req)
> +{
> + return -ENOTSUPP;
> +}
> +
> +static int sa_sham_final(struct ahash_request *req)
> +{
> + return sa_sham_digest(req);
> +}
> +
> +static int sa_sham_finup(struct ahash_request *req)
> +{
> + return sa_sham_digest(req);
> +}
You can't just not support update(). You need to support update().
- Eric
WARNING: multiple messages have this Message-ID (diff)
From: Eric Biggers <ebiggers@kernel.org>
To: Keerthy <j-keerthy@ti.com>
Cc: nm@ti.com, devicetree@vger.kernel.org,
herbert@gondor.apana.org.au, linux-kernel@vger.kernel.org,
t-kristo@ti.com, robh+dt@kernel.org,
linux-crypto@vger.kernel.org, davem@davemloft.net,
linux-arm-kernel@lists.infradead.org
Subject: Re: [RESEND PATCH 07/10] crypto: sa2ul: Add hmac(sha1) HMAC algorithm support
Date: Thu, 27 Jun 2019 22:14:12 -0700 [thread overview]
Message-ID: <20190628051412.GG673@sol.localdomain> (raw)
In-Reply-To: <20190628042745.28455-8-j-keerthy@ti.com>
On Fri, Jun 28, 2019 at 09:57:42AM +0530, Keerthy wrote:
> +static int sa_sham_update(struct ahash_request *req)
> +{
> + return -ENOTSUPP;
> +}
> +
> +static int sa_sham_final(struct ahash_request *req)
> +{
> + return sa_sham_digest(req);
> +}
> +
> +static int sa_sham_finup(struct ahash_request *req)
> +{
> + return sa_sham_digest(req);
> +}
You can't just not support update(). You need to support update().
- Eric
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-06-28 5:14 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-28 4:27 [RESEND PATCH 00/10] crypto: k3: Add sa2ul driver Keerthy
2019-06-28 4:27 ` Keerthy
2019-06-28 4:27 ` Keerthy
2019-06-28 4:27 ` [RESEND PATCH 01/10] dt-bindings: crypto: k3: Add sa2ul bindings documentation Keerthy
2019-06-28 4:27 ` Keerthy
2019-06-28 4:27 ` Keerthy
2019-07-22 18:29 ` Rob Herring
2019-07-22 18:29 ` Rob Herring
2019-07-23 4:11 ` Keerthy
2019-07-23 4:11 ` Keerthy
2019-07-23 4:11 ` Keerthy
2019-07-23 14:29 ` Rob Herring
2019-06-28 4:27 ` [RESEND PATCH 02/10] crypto: sa2ul: Add crypto driver Keerthy
2019-06-28 4:27 ` Keerthy
2019-06-28 4:27 ` Keerthy
2019-06-28 5:07 ` Eric Biggers
2019-06-28 5:07 ` Eric Biggers
2019-06-28 5:24 ` Keerthy
2019-06-28 5:24 ` Keerthy
2019-06-28 5:24 ` Keerthy
2019-06-28 4:27 ` [RESEND PATCH 03/10] crypto: sa2ul: Add AES ECB Mode support Keerthy
2019-06-28 4:27 ` Keerthy
2019-06-28 4:27 ` Keerthy
2019-06-28 4:27 ` [RESEND PATCH 04/10] crypto: sa2ul: Add aead support for hmac(sha1)cbc(aes) algorithm Keerthy
2019-06-28 4:27 ` Keerthy
2019-06-28 4:27 ` Keerthy
2019-06-28 4:27 ` [RESEND PATCH 05/10] crypto: sha256_generic: Export the Transform function Keerthy
2019-06-28 4:27 ` Keerthy
2019-06-28 4:27 ` Keerthy
2019-06-28 5:09 ` Eric Biggers
2019-06-28 5:09 ` Eric Biggers
2019-06-28 5:09 ` Eric Biggers
2019-06-28 5:27 ` Keerthy
2019-06-28 5:27 ` Keerthy
2019-06-28 5:27 ` Keerthy
2019-06-28 4:27 ` [RESEND PATCH 06/10] crypto: sa2ul: Add hmac(sha256)cbc(aes) AEAD Algo support Keerthy
2019-06-28 4:27 ` Keerthy
2019-06-28 4:27 ` Keerthy
2019-06-28 5:12 ` Eric Biggers
2019-06-28 5:12 ` Eric Biggers
2019-06-28 4:27 ` [RESEND PATCH 07/10] crypto: sa2ul: Add hmac(sha1) HMAC algorithm support Keerthy
2019-06-28 4:27 ` Keerthy
2019-06-28 4:27 ` Keerthy
2019-06-28 5:14 ` Eric Biggers [this message]
2019-06-28 5:14 ` Eric Biggers
2019-06-28 5:32 ` Keerthy
2019-06-28 5:32 ` Keerthy
2019-06-28 5:32 ` Keerthy
2019-06-28 4:27 ` [RESEND PATCH 08/10] crypto: sa2ul: Add hmac(sha256) " Keerthy
2019-06-28 4:27 ` Keerthy
2019-06-28 4:27 ` Keerthy
2019-06-28 4:27 ` [RESEND PATCH 09/10] sa2ul: Add 3DES ECB & CBC Mode support Keerthy
2019-06-28 4:27 ` Keerthy
2019-06-28 4:27 ` Keerthy
2019-06-28 4:27 ` [RESEND PATCH 10/10] arm64: dts: k3-am6: Add crypto accelarator node Keerthy
2019-06-28 4:27 ` Keerthy
2019-06-28 4:27 ` Keerthy
2019-06-28 4:53 ` [RESEND PATCH 00/10] crypto: k3: Add sa2ul driver Eric Biggers
2019-06-28 4:53 ` Eric Biggers
2019-06-28 5:14 ` keerthy
2019-06-28 5:14 ` keerthy
2019-06-28 5:14 ` keerthy
2019-06-28 5:25 ` Eric Biggers
2019-06-28 5:25 ` Eric Biggers
2019-06-28 5:31 ` Keerthy
2019-06-28 5:31 ` Keerthy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190628051412.GG673@sol.localdomain \
--to=ebiggers@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=j-keerthy@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nm@ti.com \
--cc=robh+dt@kernel.org \
--cc=t-kristo@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.