* [PATCH -next] nvme-pci: Make nvme_dev_pm_ops static
@ 2019-06-26 2:09 ` YueHaibing
0 siblings, 0 replies; 8+ messages in thread
From: YueHaibing @ 2019-06-26 2:09 UTC (permalink / raw)
Fix sparse warning:
drivers/nvme/host/pci.c:2926:25: warning:
symbol 'nvme_dev_pm_ops' was not declared. Should it be static?
Reported-by: Hulk Robot <hulkci at huawei.com>
Signed-off-by: YueHaibing <yuehaibing at huawei.com>
---
drivers/nvme/host/pci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
index 1893520..f500133 100644
--- a/drivers/nvme/host/pci.c
+++ b/drivers/nvme/host/pci.c
@@ -2923,7 +2923,7 @@ static int nvme_simple_resume(struct device *dev)
return 0;
}
-const struct dev_pm_ops nvme_dev_pm_ops = {
+static const struct dev_pm_ops nvme_dev_pm_ops = {
.suspend = nvme_suspend,
.resume = nvme_resume,
.freeze = nvme_simple_suspend,
--
2.7.4
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH -next] nvme-pci: Make nvme_dev_pm_ops static
@ 2019-06-26 2:09 ` YueHaibing
0 siblings, 0 replies; 8+ messages in thread
From: YueHaibing @ 2019-06-26 2:09 UTC (permalink / raw)
To: kbusch, axboe, hch, sagi, keith.busch
Cc: linux-kernel, linux-nvme, YueHaibing
Fix sparse warning:
drivers/nvme/host/pci.c:2926:25: warning:
symbol 'nvme_dev_pm_ops' was not declared. Should it be static?
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/nvme/host/pci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
index 1893520..f500133 100644
--- a/drivers/nvme/host/pci.c
+++ b/drivers/nvme/host/pci.c
@@ -2923,7 +2923,7 @@ static int nvme_simple_resume(struct device *dev)
return 0;
}
-const struct dev_pm_ops nvme_dev_pm_ops = {
+static const struct dev_pm_ops nvme_dev_pm_ops = {
.suspend = nvme_suspend,
.resume = nvme_resume,
.freeze = nvme_simple_suspend,
--
2.7.4
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH -next] nvme-pci: Make nvme_dev_pm_ops static
2019-06-26 2:09 ` YueHaibing
@ 2019-06-26 20:23 ` Minwoo Im
-1 siblings, 0 replies; 8+ messages in thread
From: Minwoo Im @ 2019-06-26 20:23 UTC (permalink / raw)
On 19-06-26 10:09:02, YueHaibing wrote:
> Fix sparse warning:
>
> drivers/nvme/host/pci.c:2926:25: warning:
> symbol 'nvme_dev_pm_ops' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <hulkci at huawei.com>
> Signed-off-by: YueHaibing <yuehaibing at huawei.com>
> ---
> drivers/nvme/host/pci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
> index 1893520..f500133 100644
> --- a/drivers/nvme/host/pci.c
> +++ b/drivers/nvme/host/pci.c
> @@ -2923,7 +2923,7 @@ static int nvme_simple_resume(struct device *dev)
> return 0;
> }
>
> -const struct dev_pm_ops nvme_dev_pm_ops = {
> +static const struct dev_pm_ops nvme_dev_pm_ops = {
> .suspend = nvme_suspend,
> .resume = nvme_resume,
> .freeze = nvme_simple_suspend,
IMHO, it should be in static.
Reviewed-by: Minwoo Im <minwoo.im.dev at gmail.com>
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH -next] nvme-pci: Make nvme_dev_pm_ops static
@ 2019-06-26 20:23 ` Minwoo Im
0 siblings, 0 replies; 8+ messages in thread
From: Minwoo Im @ 2019-06-26 20:23 UTC (permalink / raw)
To: YueHaibing
Cc: kbusch, axboe, hch, sagi, keith.busch, linux-kernel, linux-nvme,
Minwoo Im
On 19-06-26 10:09:02, YueHaibing wrote:
> Fix sparse warning:
>
> drivers/nvme/host/pci.c:2926:25: warning:
> symbol 'nvme_dev_pm_ops' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/nvme/host/pci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
> index 1893520..f500133 100644
> --- a/drivers/nvme/host/pci.c
> +++ b/drivers/nvme/host/pci.c
> @@ -2923,7 +2923,7 @@ static int nvme_simple_resume(struct device *dev)
> return 0;
> }
>
> -const struct dev_pm_ops nvme_dev_pm_ops = {
> +static const struct dev_pm_ops nvme_dev_pm_ops = {
> .suspend = nvme_suspend,
> .resume = nvme_resume,
> .freeze = nvme_simple_suspend,
IMHO, it should be in static.
Reviewed-by: Minwoo Im <minwoo.im.dev@gmail.com>
^ permalink raw reply [flat|nested] 8+ messages in thread* [PATCH -next] nvme-pci: Make nvme_dev_pm_ops static
2019-06-26 20:23 ` Minwoo Im
@ 2019-06-27 0:02 ` Chaitanya Kulkarni
-1 siblings, 0 replies; 8+ messages in thread
From: Chaitanya Kulkarni @ 2019-06-27 0:02 UTC (permalink / raw)
Looks good.
Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni at wdc.com>
?On 6/26/19, 1:23 PM, "Linux-nvme on behalf of Minwoo Im" <linux-nvme-bounces@lists.infradead.org on behalf of minwoo.im.dev@gmail.com> wrote:
On 19-06-26 10:09:02, YueHaibing wrote:
> Fix sparse warning:
>
> drivers/nvme/host/pci.c:2926:25: warning:
> symbol 'nvme_dev_pm_ops' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <hulkci at huawei.com>
> Signed-off-by: YueHaibing <yuehaibing at huawei.com>
> ---
> drivers/nvme/host/pci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
> index 1893520..f500133 100644
> --- a/drivers/nvme/host/pci.c
> +++ b/drivers/nvme/host/pci.c
> @@ -2923,7 +2923,7 @@ static int nvme_simple_resume(struct device *dev)
> return 0;
> }
>
> -const struct dev_pm_ops nvme_dev_pm_ops = {
> +static const struct dev_pm_ops nvme_dev_pm_ops = {
> .suspend = nvme_suspend,
> .resume = nvme_resume,
> .freeze = nvme_simple_suspend,
IMHO, it should be in static.
Reviewed-by: Minwoo Im <minwoo.im.dev at gmail.com>
_______________________________________________
Linux-nvme mailing list
Linux-nvme at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH -next] nvme-pci: Make nvme_dev_pm_ops static
@ 2019-06-27 0:02 ` Chaitanya Kulkarni
0 siblings, 0 replies; 8+ messages in thread
From: Chaitanya Kulkarni @ 2019-06-27 0:02 UTC (permalink / raw)
To: Minwoo Im, YueHaibing
Cc: keith.busch@intel.com, sagi@grimberg.me,
linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org,
axboe@fb.com, kbusch@kernel.org, hch@lst.de
Looks good.
Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
On 6/26/19, 1:23 PM, "Linux-nvme on behalf of Minwoo Im" <linux-nvme-bounces@lists.infradead.org on behalf of minwoo.im.dev@gmail.com> wrote:
On 19-06-26 10:09:02, YueHaibing wrote:
> Fix sparse warning:
>
> drivers/nvme/host/pci.c:2926:25: warning:
> symbol 'nvme_dev_pm_ops' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/nvme/host/pci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
> index 1893520..f500133 100644
> --- a/drivers/nvme/host/pci.c
> +++ b/drivers/nvme/host/pci.c
> @@ -2923,7 +2923,7 @@ static int nvme_simple_resume(struct device *dev)
> return 0;
> }
>
> -const struct dev_pm_ops nvme_dev_pm_ops = {
> +static const struct dev_pm_ops nvme_dev_pm_ops = {
> .suspend = nvme_suspend,
> .resume = nvme_resume,
> .freeze = nvme_simple_suspend,
IMHO, it should be in static.
Reviewed-by: Minwoo Im <minwoo.im.dev@gmail.com>
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH -next] nvme-pci: Make nvme_dev_pm_ops static
2019-06-26 2:09 ` YueHaibing
@ 2019-06-28 7:09 ` Christoph Hellwig
-1 siblings, 0 replies; 8+ messages in thread
From: Christoph Hellwig @ 2019-06-28 7:09 UTC (permalink / raw)
Thanks,
applied to nvme-5.3.
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2019-06-28 7:09 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-06-26 2:09 [PATCH -next] nvme-pci: Make nvme_dev_pm_ops static YueHaibing
2019-06-26 2:09 ` YueHaibing
2019-06-26 20:23 ` Minwoo Im
2019-06-26 20:23 ` Minwoo Im
2019-06-27 0:02 ` Chaitanya Kulkarni
2019-06-27 0:02 ` Chaitanya Kulkarni
2019-06-28 7:09 ` Christoph Hellwig
2019-06-28 7:09 ` Christoph Hellwig
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.