From: Jonathan Corbet <corbet@lwn.net>
To: Jiunn Chang <c0d1n61at3@gmail.com>
Cc: skhan@linuxfoundation.org,
linux-kernel-mentees@lists.linuxfoundation.org,
paulmck@linux.ibm.com, josh@joshtriplett.org,
rostedt@goodmis.org, mathieu.desnoyers@efficios.com,
jiangshanlai@gmail.com, joel@joelfernandes.org,
rcu@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [Linux-kernel-mentees][PATCH] doc: RCU callback locks need only _bh, not necessarily _irq
Date: Fri, 28 Jun 2019 09:11:01 -0600 [thread overview]
Message-ID: <20190628091101.5f4d35e3@lwn.net> (raw)
In-Reply-To: <20190627210147.19510-1-c0d1n61at3@gmail.com>
On Thu, 27 Jun 2019 16:01:47 -0500
Jiunn Chang <c0d1n61at3@gmail.com> wrote:
> The UP.rst file calls for locks acquired within RCU callback functions
> to use _irq variants (spin_lock_irqsave() or similar), which does work,
> but can be overkill. This commit therefore instead calls for _bh variants
> (spin_lock_bh() or similar), while noting that _irq does work.
>
> Signed-off-by: Paul E. McKenney <paulmck@linux.ibm.com>
> Signed-off-by: Jiunn Chang <c0d1n61at3@gmail.com>
> ---
> Documentation/RCU/UP.rst | 13 +++++++------
> 1 file changed, 7 insertions(+), 6 deletions(-)
Applied, thanks.
jon
WARNING: multiple messages have this Message-ID (diff)
From: corbet at lwn.net (Jonathan Corbet)
Subject: [Linux-kernel-mentees] [PATCH] doc: RCU callback locks need only _bh, not necessarily _irq
Date: Fri, 28 Jun 2019 09:11:01 -0600 [thread overview]
Message-ID: <20190628091101.5f4d35e3@lwn.net> (raw)
In-Reply-To: <20190627210147.19510-1-c0d1n61at3@gmail.com>
On Thu, 27 Jun 2019 16:01:47 -0500
Jiunn Chang <c0d1n61at3 at gmail.com> wrote:
> The UP.rst file calls for locks acquired within RCU callback functions
> to use _irq variants (spin_lock_irqsave() or similar), which does work,
> but can be overkill. This commit therefore instead calls for _bh variants
> (spin_lock_bh() or similar), while noting that _irq does work.
>
> Signed-off-by: Paul E. McKenney <paulmck at linux.ibm.com>
> Signed-off-by: Jiunn Chang <c0d1n61at3 at gmail.com>
> ---
> Documentation/RCU/UP.rst | 13 +++++++------
> 1 file changed, 7 insertions(+), 6 deletions(-)
Applied, thanks.
jon
WARNING: multiple messages have this Message-ID (diff)
From: corbet@lwn.net (Jonathan Corbet)
Subject: [Linux-kernel-mentees] [PATCH] doc: RCU callback locks need only _bh, not necessarily _irq
Date: Fri, 28 Jun 2019 09:11:01 -0600 [thread overview]
Message-ID: <20190628091101.5f4d35e3@lwn.net> (raw)
Message-ID: <20190628151101.v27xfxNHe4lCZ5P8vGRy73UUdS6ZNMLXLWubrOcryE4@z> (raw)
In-Reply-To: <20190627210147.19510-1-c0d1n61at3@gmail.com>
On Thu, 27 Jun 2019 16:01:47 -0500
Jiunn Chang <c0d1n61at3 at gmail.com> wrote:
> The UP.rst file calls for locks acquired within RCU callback functions
> to use _irq variants (spin_lock_irqsave() or similar), which does work,
> but can be overkill. This commit therefore instead calls for _bh variants
> (spin_lock_bh() or similar), while noting that _irq does work.
>
> Signed-off-by: Paul E. McKenney <paulmck at linux.ibm.com>
> Signed-off-by: Jiunn Chang <c0d1n61at3 at gmail.com>
> ---
> Documentation/RCU/UP.rst | 13 +++++++------
> 1 file changed, 7 insertions(+), 6 deletions(-)
Applied, thanks.
jon
next prev parent reply other threads:[~2019-06-28 15:11 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-27 21:01 [Linux-kernel-mentees][PATCH] doc: RCU callback locks need only _bh, not necessarily _irq Jiunn Chang
2019-06-27 21:01 ` [Linux-kernel-mentees] [PATCH] " Jiunn Chang
2019-06-27 21:01 ` c0d1n61at3
2019-06-27 22:01 ` [Linux-kernel-mentees][PATCH] " Shuah Khan
2019-06-27 22:01 ` [Linux-kernel-mentees] [PATCH] " Shuah Khan
2019-06-27 22:01 ` skhan
2019-06-27 22:10 ` [Linux-kernel-mentees][PATCH] " Paul E. McKenney
2019-06-27 22:10 ` [Linux-kernel-mentees] [PATCH] " Paul E. McKenney
2019-06-27 22:10 ` paulmck
2019-06-27 22:11 ` [Linux-kernel-mentees][PATCH] " Shuah Khan
2019-06-27 22:11 ` [Linux-kernel-mentees] [PATCH] " Shuah Khan
2019-06-27 22:11 ` skhan
2019-06-27 22:29 ` [Linux-kernel-mentees][PATCH] " Steven Rostedt
2019-06-27 22:29 ` [Linux-kernel-mentees] [PATCH] " Steven Rostedt
2019-06-27 22:29 ` rostedt
2019-06-27 22:42 ` [Linux-kernel-mentees][PATCH] " Paul E. McKenney
2019-06-27 22:42 ` [Linux-kernel-mentees] [PATCH] " Paul E. McKenney
2019-06-27 22:42 ` paulmck
2019-06-28 15:11 ` Jonathan Corbet [this message]
2019-06-28 15:11 ` Jonathan Corbet
2019-06-28 15:11 ` corbet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190628091101.5f4d35e3@lwn.net \
--to=corbet@lwn.net \
--cc=c0d1n61at3@gmail.com \
--cc=jiangshanlai@gmail.com \
--cc=joel@joelfernandes.org \
--cc=josh@joshtriplett.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=paulmck@linux.ibm.com \
--cc=rcu@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.