All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jiri Olsa <jolsa@redhat.com>
To: John Garry <john.garry@huawei.com>
Cc: mark.rutland@arm.com, brueckner@linux.ibm.com,
	mathieu.poirier@linaro.org, peterz@infradead.org,
	tmricht@linux.ibm.com, will.deacon@arm.com,
	linux-kernel@vger.kernel.org, acme@kernel.org,
	linuxarm@huawei.com, zhangshaokun@hisilicon.com,
	alexander.shishkin@linux.intel.com, mingo@redhat.com,
	namhyung@kernel.org, ben@decadent.org.uk,
	linux-arm-kernel@lists.infradead.org, kan.liang@linux.intel.com
Subject: Re: [PATCH v2 2/5] perf pmu: Support more complex PMU event aliasing
Date: Fri, 28 Jun 2019 12:40:40 +0200	[thread overview]
Message-ID: <20190628104040.GA15960@krava> (raw)
In-Reply-To: <cafed7d6-13c7-3a92-a826-024698bc6cc8@huawei.com>

On Thu, Jun 27, 2019 at 05:27:32PM +0100, John Garry wrote:

SNIP

> > > 
> > > heya,
> > > sry for late reply
> > > 
> > > > 
> > > > > if tok is NULL in here we crash
> > > > > 
> > > > 
> > > > As I see, tok could not be NULL. If str contains no delimiters, then
> > > > we just
> > > > return same as str in tok.
> > > > 
> > > > Can you see tok being NULL?
> > > 
> > > well, if there's no ',' in the str it returns NULL, right?
> > 
> > No, it would return str in tok.

ok

> > 
> > > and IIUC this function is still called for standard uncore
> > > pmu names
> > > 
> > > > 
> > > > > > +        res = false;
> > > > > > +        goto out;
> > > > > > +    }
> > > > > > +
> > > > > > +    for (; tok; name += strlen(tok), tok = strtok_r(NULL, ",",
> > > > > > &tmp)) {
> > > > > 
> > > > > why is name shifted in here?
> > > > 
> > > > I want to ensure that we match the tokens in order and also guard
> > > > against
> > > > possible repeated token matches in 'name'.
> > > 
> > > i might not understand this correctly.. so
> > > 
> > > str is the alias name that can contain ',' now, like:
> > >   hisi_sccl,ddrc
> > 
> > For example of pmu_nmame=hisi_sccl,ddrc and pmu=hisi_sccl1_ddrc0, we
> > match in this sequence:
> > 
> > loop 1. tok=hisi_sccl name=hisi_sccl1_ddrc0
> > loop 2. tok=ddrc name=ddrc0
> > loop 3. tok=NULL -> breakout and return true

ok, plz put something like above into comment

thanks,
jirka

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Jiri Olsa <jolsa@redhat.com>
To: John Garry <john.garry@huawei.com>
Cc: peterz@infradead.org, mingo@redhat.com, acme@kernel.org,
	alexander.shishkin@linux.intel.com, namhyung@kernel.org,
	tmricht@linux.ibm.com, brueckner@linux.ibm.com,
	kan.liang@linux.intel.com, ben@decadent.org.uk,
	mathieu.poirier@linaro.org, mark.rutland@arm.com,
	will.deacon@arm.com, linux-kernel@vger.kernel.org,
	linuxarm@huawei.com, linux-arm-kernel@lists.infradead.org,
	zhangshaokun@hisilicon.com
Subject: Re: [PATCH v2 2/5] perf pmu: Support more complex PMU event aliasing
Date: Fri, 28 Jun 2019 12:40:40 +0200	[thread overview]
Message-ID: <20190628104040.GA15960@krava> (raw)
In-Reply-To: <cafed7d6-13c7-3a92-a826-024698bc6cc8@huawei.com>

On Thu, Jun 27, 2019 at 05:27:32PM +0100, John Garry wrote:

SNIP

> > > 
> > > heya,
> > > sry for late reply
> > > 
> > > > 
> > > > > if tok is NULL in here we crash
> > > > > 
> > > > 
> > > > As I see, tok could not be NULL. If str contains no delimiters, then
> > > > we just
> > > > return same as str in tok.
> > > > 
> > > > Can you see tok being NULL?
> > > 
> > > well, if there's no ',' in the str it returns NULL, right?
> > 
> > No, it would return str in tok.

ok

> > 
> > > and IIUC this function is still called for standard uncore
> > > pmu names
> > > 
> > > > 
> > > > > > +        res = false;
> > > > > > +        goto out;
> > > > > > +    }
> > > > > > +
> > > > > > +    for (; tok; name += strlen(tok), tok = strtok_r(NULL, ",",
> > > > > > &tmp)) {
> > > > > 
> > > > > why is name shifted in here?
> > > > 
> > > > I want to ensure that we match the tokens in order and also guard
> > > > against
> > > > possible repeated token matches in 'name'.
> > > 
> > > i might not understand this correctly.. so
> > > 
> > > str is the alias name that can contain ',' now, like:
> > >   hisi_sccl,ddrc
> > 
> > For example of pmu_nmame=hisi_sccl,ddrc and pmu=hisi_sccl1_ddrc0, we
> > match in this sequence:
> > 
> > loop 1. tok=hisi_sccl name=hisi_sccl1_ddrc0
> > loop 2. tok=ddrc name=ddrc0
> > loop 3. tok=NULL -> breakout and return true

ok, plz put something like above into comment

thanks,
jirka

  parent reply	other threads:[~2019-06-28 10:41 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-14 14:07 [PATCH v2 0/5] Perf uncore PMU event alias support for Hisi hip08 ARM64 platform John Garry
2019-06-14 14:07 ` John Garry
2019-06-14 14:07 ` [PATCH v2 1/5] perf pmu: Fix uncore PMU alias list for ARM64 John Garry
2019-06-14 14:07   ` John Garry
2019-06-14 14:46   ` Arnaldo Carvalho de Melo
2019-06-14 14:46     ` Arnaldo Carvalho de Melo
2019-06-14 15:04     ` John Garry
2019-06-14 15:04       ` John Garry
2019-06-14 15:47       ` Arnaldo Carvalho de Melo
2019-06-14 15:47         ` Arnaldo Carvalho de Melo
2019-06-22  6:47   ` [tip:perf/core] " tip-bot for John Garry
2019-06-14 14:08 ` [PATCH v2 2/5] perf pmu: Support more complex PMU event aliasing John Garry
2019-06-14 14:08   ` John Garry
2019-06-14 14:50   ` Arnaldo Carvalho de Melo
2019-06-14 14:50     ` Arnaldo Carvalho de Melo
2019-06-16  9:58   ` Jiri Olsa
2019-06-16  9:58     ` Jiri Olsa
2019-06-17  9:06     ` John Garry
2019-06-17  9:06       ` John Garry
2019-06-20 18:25       ` Jiri Olsa
2019-06-20 18:25         ` Jiri Olsa
2019-06-21 10:42         ` John Garry
2019-06-21 10:42           ` John Garry
2019-06-27 16:27           ` John Garry
2019-06-27 16:27             ` John Garry
2019-06-27 16:33             ` Jiri Olsa
2019-06-27 16:33               ` Jiri Olsa
2019-06-28 10:40             ` Jiri Olsa [this message]
2019-06-28 10:40               ` Jiri Olsa
2019-06-28 10:45               ` John Garry
2019-06-28 10:45                 ` John Garry
2019-06-14 14:08 ` [PATCH v2 3/5] perf jevents: Add support for Hisi hip08 DDRC PMU aliasing John Garry
2019-06-14 14:08   ` John Garry
2019-06-14 14:08 ` [PATCH v2 4/5] perf jevents: Add support for Hisi hip08 HHA " John Garry
2019-06-14 14:08   ` John Garry
2019-06-14 14:08 ` [PATCH v2 5/5] perf jevents: Add support for Hisi hip08 L3C " John Garry
2019-06-14 14:08   ` John Garry

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190628104040.GA15960@krava \
    --to=jolsa@redhat.com \
    --cc=acme@kernel.org \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=ben@decadent.org.uk \
    --cc=brueckner@linux.ibm.com \
    --cc=john.garry@huawei.com \
    --cc=kan.liang@linux.intel.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxarm@huawei.com \
    --cc=mark.rutland@arm.com \
    --cc=mathieu.poirier@linaro.org \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    --cc=tmricht@linux.ibm.com \
    --cc=will.deacon@arm.com \
    --cc=zhangshaokun@hisilicon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.