From: Luis Chamberlain <mcgrof@kernel.org>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: Christoph Hellwig <hch@lst.de>,
linux-xfs@vger.kernel.org,
syzbot+b75afdbe271a0d7ac4f6@syzkaller.appspotmail.com
Subject: Re: [PATCH] xfs: fix iclog allocation size
Date: Fri, 28 Jun 2019 22:32:00 +0000 [thread overview]
Message-ID: <20190628223200.GO19023@42.do-not-panic.com> (raw)
In-Reply-To: <20190628222548.GE1404256@magnolia>
On Fri, Jun 28, 2019 at 03:25:48PM -0700, Darrick J. Wong wrote:
> On Fri, Jun 28, 2019 at 10:23:10PM +0000, Luis Chamberlain wrote:
> > On Fri, Jun 28, 2019 at 03:19:14PM -0700, Darrick J. Wong wrote:
> > > On Fri, Jun 28, 2019 at 10:02:53PM +0000, Luis Chamberlain wrote:
> > > > On Thu, Jun 27, 2019 at 04:39:50PM +0200, Christoph Hellwig wrote:
> > > > > Properly allocate the space for the bio_vecs instead of just one byte
> > > > > per bio_vec.
> > > > >
> > > > > Fixes: 991fc1d2e65e ("xfs: use bios directly to write log buffers")
> > > >
> > > > I cannot find 991fc1d2e65e on Linus' tree, nor can I find the subject
> > > > name patch on Linus' tree. I'm probably missing some context here?
> > >
> > > This patch fixes a bug in for-next. :)
> >
> > I figured as much but the commit in question is not even on linux-next
> > for today, so I take it that line would be removed from the commit log?
>
> It looks like it is to me...
>
> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?h=next-20190628&id=991fc1d2e65e381fe8db9038d9a139d45c948f4f
Yes but commits on linux-next make no sense for Linus' tree, as they change
day to day, is my point. So if merged eventually as-is on Linus' tree,
someone looking at the git history would not find 991fc1d2e65e, and
could also throw errors on scripts which scrape for these tags. Yes,
they exist, and distros do use them to evaluate possible fixes.
In this case I think just referring to the subject would do it.
Unless it just so happens to be that what is on for-next *does* always
maintain the same commit IDs one it goes to Linus' tree? Does that
actually happen?
Luis
prev parent reply other threads:[~2019-06-28 22:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-27 14:39 [PATCH] xfs: fix iclog allocation size Christoph Hellwig
2019-06-27 15:13 ` Darrick J. Wong
2019-06-28 22:02 ` Luis Chamberlain
2019-06-28 22:19 ` Darrick J. Wong
2019-06-28 22:23 ` Luis Chamberlain
2019-06-28 22:25 ` Darrick J. Wong
2019-06-28 22:32 ` Luis Chamberlain [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190628223200.GO19023@42.do-not-panic.com \
--to=mcgrof@kernel.org \
--cc=darrick.wong@oracle.com \
--cc=hch@lst.de \
--cc=linux-xfs@vger.kernel.org \
--cc=syzbot+b75afdbe271a0d7ac4f6@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.