All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Clark <robdclark@gmail.com>
To: dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org
Cc: freedreno@lists.freedesktop.org,
	aarch64-laptops@lists.linaro.org,
	Rob Clark <robdclark@chromium.org>,
	Andrzej Hajda <a.hajda@samsung.com>,
	Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
	David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
	linux-kernel@vger.kernel.org
Subject: [PATCH 4/4] drm/bridge: ti-sn65dsi86: use helper to lookup panel-id
Date: Sun, 30 Jun 2019 13:36:08 -0700	[thread overview]
Message-ID: <20190630203614.5290-5-robdclark@gmail.com> (raw)
In-Reply-To: <20190630203614.5290-1-robdclark@gmail.com>

From: Rob Clark <robdclark@chromium.org>

Use the drm_of_find_panel_id() helper to decide which endpoint to use
when looking up panel.  This way we can support devices that have
multiple possible panels, such as the aarch64 laptops.

Signed-off-by: Rob Clark <robdclark@chromium.org>
---
 drivers/gpu/drm/bridge/ti-sn65dsi86.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi86.c b/drivers/gpu/drm/bridge/ti-sn65dsi86.c
index 2719d9c0864b..56c66a43f1a6 100644
--- a/drivers/gpu/drm/bridge/ti-sn65dsi86.c
+++ b/drivers/gpu/drm/bridge/ti-sn65dsi86.c
@@ -790,7 +790,7 @@ static int ti_sn_bridge_probe(struct i2c_client *client,
 			      const struct i2c_device_id *id)
 {
 	struct ti_sn_bridge *pdata;
-	int ret;
+	int ret, panel_id;
 
 	if (!i2c_check_functionality(client->adapter, I2C_FUNC_I2C)) {
 		DRM_ERROR("device doesn't support I2C\n");
@@ -811,7 +811,8 @@ static int ti_sn_bridge_probe(struct i2c_client *client,
 
 	pdata->dev = &client->dev;
 
-	ret = drm_of_find_panel_or_bridge(pdata->dev->of_node, 1, 0,
+	panel_id = drm_of_find_panel_id();
+	ret = drm_of_find_panel_or_bridge(pdata->dev->of_node, 1, panel_id,
 					  &pdata->panel, NULL);
 	if (ret) {
 		DRM_ERROR("could not find any panel node\n");
-- 
2.20.1


WARNING: multiple messages have this Message-ID (diff)
From: Rob Clark <robdclark-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
	linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: Rob Clark <robdclark-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>,
	aarch64-laptops-cunTk1MwBs8s++Sfvej+rw@public.gmane.org,
	David Airlie <airlied-cv59FeDIM0c@public.gmane.org>,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Andrzej Hajda <a.hajda-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
	Laurent Pinchart
	<Laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org>,
	Daniel Vetter <daniel-/w4YWyX8dFk@public.gmane.org>,
	freedreno-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Subject: [PATCH 4/4] drm/bridge: ti-sn65dsi86: use helper to lookup panel-id
Date: Sun, 30 Jun 2019 13:36:08 -0700	[thread overview]
Message-ID: <20190630203614.5290-5-robdclark@gmail.com> (raw)
In-Reply-To: <20190630203614.5290-1-robdclark-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

From: Rob Clark <robdclark@chromium.org>

Use the drm_of_find_panel_id() helper to decide which endpoint to use
when looking up panel.  This way we can support devices that have
multiple possible panels, such as the aarch64 laptops.

Signed-off-by: Rob Clark <robdclark@chromium.org>
---
 drivers/gpu/drm/bridge/ti-sn65dsi86.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi86.c b/drivers/gpu/drm/bridge/ti-sn65dsi86.c
index 2719d9c0864b..56c66a43f1a6 100644
--- a/drivers/gpu/drm/bridge/ti-sn65dsi86.c
+++ b/drivers/gpu/drm/bridge/ti-sn65dsi86.c
@@ -790,7 +790,7 @@ static int ti_sn_bridge_probe(struct i2c_client *client,
 			      const struct i2c_device_id *id)
 {
 	struct ti_sn_bridge *pdata;
-	int ret;
+	int ret, panel_id;
 
 	if (!i2c_check_functionality(client->adapter, I2C_FUNC_I2C)) {
 		DRM_ERROR("device doesn't support I2C\n");
@@ -811,7 +811,8 @@ static int ti_sn_bridge_probe(struct i2c_client *client,
 
 	pdata->dev = &client->dev;
 
-	ret = drm_of_find_panel_or_bridge(pdata->dev->of_node, 1, 0,
+	panel_id = drm_of_find_panel_id();
+	ret = drm_of_find_panel_or_bridge(pdata->dev->of_node, 1, panel_id,
 					  &pdata->panel, NULL);
 	if (ret) {
 		DRM_ERROR("could not find any panel node\n");
-- 
2.20.1

_______________________________________________
Freedreno mailing list
Freedreno@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/freedreno

  parent reply	other threads:[~2019-06-30 20:37 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-30 20:36 [PATCH 0/4] drm+dt+efi: support devices with multiple possible panels Rob Clark
2019-06-30 20:36 ` Rob Clark
2019-06-30 20:36 ` [PATCH 1/4] dt-bindings: chosen: document panel-id binding Rob Clark
2019-06-30 20:36   ` Rob Clark
2019-07-01 14:03   ` Rob Herring
2019-07-01 14:03     ` Rob Herring
2019-07-01 14:28     ` Jeffrey Hugo
2019-07-01 14:28       ` Jeffrey Hugo
2019-07-01 14:41     ` Rob Clark
2019-07-01 15:11       ` Rob Herring
2019-11-30 18:37     ` Rob Clark
2019-11-30 18:37       ` Rob Clark
2019-11-30 18:39       ` Rob Clark
2019-11-30 18:39         ` Rob Clark
2019-11-30 18:39         ` Rob Clark
2019-06-30 20:36 ` [PATCH 2/4] efi/libstub: detect panel-id Rob Clark
2019-06-30 20:36   ` Rob Clark
2019-07-02 20:26   ` Ard Biesheuvel
2019-07-02 20:26     ` Ard Biesheuvel
2019-07-02 20:35     ` Ard Biesheuvel
2019-07-02 20:35       ` Ard Biesheuvel
2019-07-02 21:01       ` Rob Clark
2019-07-02 21:01         ` Rob Clark
2019-07-02 21:53         ` Ard Biesheuvel
2019-07-02 21:53           ` Ard Biesheuvel
2019-07-02 22:36           ` Rob Clark
2019-07-02 22:36             ` Rob Clark
2019-07-02 21:59         ` Leif Lindholm
2019-07-02 21:59           ` Leif Lindholm
2019-07-02 22:48           ` Rob Clark
2019-07-02 22:48             ` Rob Clark
2019-07-03 16:33             ` Leif Lindholm
2019-07-03 17:41               ` Rob Clark
2019-07-03 17:54                 ` Ard Biesheuvel
2019-06-30 20:36 ` [PATCH 3/4] drm: add helper to lookup panel-id Rob Clark
2019-06-30 20:36   ` Rob Clark
2019-06-30 20:36 ` Rob Clark [this message]
2019-06-30 20:36   ` [PATCH 4/4] drm/bridge: ti-sn65dsi86: use " Rob Clark
2019-06-30 21:17   ` Laurent Pinchart
2019-06-30 21:17     ` Laurent Pinchart
2019-06-30 21:50     ` Rob Clark
2019-06-30 21:57       ` Laurent Pinchart
2019-06-30 22:04         ` Rob Clark
2019-06-30 22:04           ` Rob Clark
2019-06-30 20:47 ` [PATCH 0/4] drm+dt+efi: support devices with multiple possible panels Laurent Pinchart
2019-06-30 20:47   ` Laurent Pinchart
2019-06-30 21:05   ` Rob Clark
2019-06-30 21:15     ` Laurent Pinchart
2019-06-30 21:15       ` Laurent Pinchart
2019-06-30 21:35       ` Rob Clark
2019-06-30 21:35         ` Rob Clark
2019-07-02 12:50 ` Rob Clark
2019-07-02 12:50   ` Rob Clark

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190630203614.5290-5-robdclark@gmail.com \
    --to=robdclark@gmail.com \
    --cc=Laurent.pinchart@ideasonboard.com \
    --cc=a.hajda@samsung.com \
    --cc=aarch64-laptops@lists.linaro.org \
    --cc=airlied@linux.ie \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=freedreno@lists.freedesktop.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robdclark@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.