From: Oscar Salvador <osalvador@suse.de>
To: Michal Hocko <mhocko@kernel.org>
Cc: linux-s390@vger.kernel.org,
Alex Deucher <alexander.deucher@amd.com>,
linux-ia64@vger.kernel.org, David Hildenbrand <david@redhat.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Mark Brown <broonie@kernel.org>,
linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org,
Wei Yang <richard.weiyang@gmail.com>,
linux-mm@kvack.org, "David S. Miller" <davem@davemloft.net>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Igor Mammedov <imammedo@redhat.com>,
akpm@linux-foundation.org,
Chris Wilson <chris@chris-wilson.co.uk>,
linuxppc-dev@lists.ozlabs.org,
Dan Williams <dan.j.williams@intel.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 10/11] mm/memory_hotplug: Make unregister_memory_block_under_nodes() never fail
Date: Mon, 01 Jul 2019 09:36:44 +0000 [thread overview]
Message-ID: <20190701093640.GA17349@linux> (raw)
In-Reply-To: <20190701085144.GJ6376@dhcp22.suse.cz>
On Mon, Jul 01, 2019 at 10:51:44AM +0200, Michal Hocko wrote:
> Yeah, we do not allow to offline multi zone (node) ranges so the current
> code seems to be over engineered.
>
> Anyway, I am wondering why do we have to strictly check for already
> removed nodes links. Is the sysfs code going to complain we we try to
> remove again?
No, sysfs will silently "fail" if the symlink has already been removed.
At least that is what I saw last time I played with it.
I guess the question is what if sysfs handling changes in the future
and starts dropping warnings when trying to remove a symlink is not there.
Maybe that is unlikely to happen?
--
Oscar Salvador
SUSE L3
WARNING: multiple messages have this Message-ID (diff)
From: Oscar Salvador <osalvador@suse.de>
To: Michal Hocko <mhocko@kernel.org>
Cc: David Hildenbrand <david@redhat.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
linux-ia64@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
linux-s390@vger.kernel.org, linux-sh@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, akpm@linux-foundation.org,
Dan Williams <dan.j.williams@intel.com>,
Wei Yang <richard.weiyang@gmail.com>,
Igor Mammedov <imammedo@redhat.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Alex Deucher <alexander.deucher@amd.com>,
"David S. Miller" <davem@davemloft.net>,
Mark Brown <broonie@kernel.org>,
Chris Wilson <chris@chris-wilson.co.uk>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>
Subject: Re: [PATCH v3 10/11] mm/memory_hotplug: Make unregister_memory_block_under_nodes() never fail
Date: Mon, 1 Jul 2019 11:36:44 +0200 [thread overview]
Message-ID: <20190701093640.GA17349@linux> (raw)
In-Reply-To: <20190701085144.GJ6376@dhcp22.suse.cz>
On Mon, Jul 01, 2019 at 10:51:44AM +0200, Michal Hocko wrote:
> Yeah, we do not allow to offline multi zone (node) ranges so the current
> code seems to be over engineered.
>
> Anyway, I am wondering why do we have to strictly check for already
> removed nodes links. Is the sysfs code going to complain we we try to
> remove again?
No, sysfs will silently "fail" if the symlink has already been removed.
At least that is what I saw last time I played with it.
I guess the question is what if sysfs handling changes in the future
and starts dropping warnings when trying to remove a symlink is not there.
Maybe that is unlikely to happen?
--
Oscar Salvador
SUSE L3
WARNING: multiple messages have this Message-ID (diff)
From: Oscar Salvador <osalvador@suse.de>
To: Michal Hocko <mhocko@kernel.org>
Cc: linux-s390@vger.kernel.org,
Alex Deucher <alexander.deucher@amd.com>,
linux-ia64@vger.kernel.org, David Hildenbrand <david@redhat.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Mark Brown <broonie@kernel.org>,
linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org,
Wei Yang <richard.weiyang@gmail.com>,
linux-mm@kvack.org, "David S. Miller" <davem@davemloft.net>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Igor Mammedov <imammedo@redhat.com>,
akpm@linux-foundation.org,
Chris Wilson <chris@chris-wilson.co.uk>,
linuxppc-dev@lists.ozlabs.org,
Dan Williams <dan.j.williams@intel.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 10/11] mm/memory_hotplug: Make unregister_memory_block_under_nodes() never fail
Date: Mon, 1 Jul 2019 11:36:44 +0200 [thread overview]
Message-ID: <20190701093640.GA17349@linux> (raw)
In-Reply-To: <20190701085144.GJ6376@dhcp22.suse.cz>
On Mon, Jul 01, 2019 at 10:51:44AM +0200, Michal Hocko wrote:
> Yeah, we do not allow to offline multi zone (node) ranges so the current
> code seems to be over engineered.
>
> Anyway, I am wondering why do we have to strictly check for already
> removed nodes links. Is the sysfs code going to complain we we try to
> remove again?
No, sysfs will silently "fail" if the symlink has already been removed.
At least that is what I saw last time I played with it.
I guess the question is what if sysfs handling changes in the future
and starts dropping warnings when trying to remove a symlink is not there.
Maybe that is unlikely to happen?
--
Oscar Salvador
SUSE L3
WARNING: multiple messages have this Message-ID (diff)
From: Oscar Salvador <osalvador@suse.de>
To: Michal Hocko <mhocko@kernel.org>
Cc: linux-s390@vger.kernel.org,
Alex Deucher <alexander.deucher@amd.com>,
linux-ia64@vger.kernel.org, David Hildenbrand <david@redhat.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Mark Brown <broonie@kernel.org>,
linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org,
Wei Yang <richard.weiyang@gmail.com>,
linux-mm@kvack.org, "David S. Miller" <davem@davemloft.net>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Igor Mammedov <imammedo@redhat.com>,
akpm@linux-foundation.org,
Chris Wilson <chris@chris-wilson.co.uk>,
linuxppc-dev@lists.ozlabs.org,
Dan Williams <dan.j.williams@intel.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 10/11] mm/memory_hotplug: Make unregister_memory_block_under_nodes() never fail
Date: Mon, 1 Jul 2019 11:36:44 +0200 [thread overview]
Message-ID: <20190701093640.GA17349@linux> (raw)
In-Reply-To: <20190701085144.GJ6376@dhcp22.suse.cz>
On Mon, Jul 01, 2019 at 10:51:44AM +0200, Michal Hocko wrote:
> Yeah, we do not allow to offline multi zone (node) ranges so the current
> code seems to be over engineered.
>
> Anyway, I am wondering why do we have to strictly check for already
> removed nodes links. Is the sysfs code going to complain we we try to
> remove again?
No, sysfs will silently "fail" if the symlink has already been removed.
At least that is what I saw last time I played with it.
I guess the question is what if sysfs handling changes in the future
and starts dropping warnings when trying to remove a symlink is not there.
Maybe that is unlikely to happen?
--
Oscar Salvador
SUSE L3
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-07-01 9:36 UTC|newest]
Thread overview: 246+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-27 11:11 [PATCH v3 00/11] mm/memory_hotplug: Factor out memory block devicehandling David Hildenbrand
2019-05-27 11:11 ` David Hildenbrand
2019-05-27 11:11 ` [PATCH v3 01/11] mm/memory_hotplug: Simplify and fix check_hotplug_memory_range() David Hildenbrand
2019-05-27 11:11 ` David Hildenbrand
2019-05-27 11:11 ` David Hildenbrand
2019-05-27 11:11 ` David Hildenbrand
2019-05-30 17:53 ` Pavel Tatashin
2019-05-30 17:53 ` Pavel Tatashin
2019-05-30 17:53 ` Pavel Tatashin
2019-05-30 17:53 ` Pavel Tatashin
2019-06-10 16:46 ` Oscar Salvador
2019-06-10 16:46 ` Oscar Salvador
2019-06-10 16:46 ` Oscar Salvador
2019-06-10 16:46 ` Oscar Salvador
2019-07-01 7:42 ` Michal Hocko
2019-07-01 7:42 ` Michal Hocko
2019-07-01 7:42 ` Michal Hocko
2019-07-01 7:42 ` Michal Hocko
2019-05-27 11:11 ` [PATCH v3 02/11] s390x/mm: Fail when an altmap is used for arch_add_memory() David Hildenbrand
2019-05-27 11:11 ` David Hildenbrand
2019-05-27 11:11 ` David Hildenbrand
2019-05-27 11:11 ` David Hildenbrand
2019-06-10 17:07 ` Oscar Salvador
2019-06-10 17:07 ` Oscar Salvador
2019-06-10 17:07 ` Oscar Salvador
2019-06-10 17:07 ` Oscar Salvador
2019-07-01 7:43 ` Michal Hocko
2019-07-01 7:43 ` Michal Hocko
2019-07-01 7:43 ` Michal Hocko
2019-07-01 7:43 ` Michal Hocko
2019-07-01 12:46 ` Michal Hocko
2019-07-01 12:46 ` Michal Hocko
2019-07-01 12:46 ` Michal Hocko
2019-07-01 12:46 ` Michal Hocko
2019-07-15 10:51 ` David Hildenbrand
2019-07-15 10:51 ` David Hildenbrand
2019-07-15 10:51 ` David Hildenbrand
2019-07-15 10:51 ` David Hildenbrand
2019-07-19 6:45 ` Michal Hocko
2019-07-19 6:45 ` Michal Hocko
2019-07-19 6:45 ` Michal Hocko
2019-07-19 6:45 ` Michal Hocko
2019-05-27 11:11 ` [PATCH v3 03/11] s390x/mm: Implement arch_remove_memory() David Hildenbrand
2019-05-27 11:11 ` David Hildenbrand
2019-05-27 11:11 ` David Hildenbrand
2019-05-27 11:11 ` David Hildenbrand
2019-07-01 7:45 ` Michal Hocko
2019-07-01 7:45 ` Michal Hocko
2019-07-01 7:45 ` Michal Hocko
2019-07-01 7:45 ` Michal Hocko
2019-07-01 12:47 ` Michal Hocko
2019-07-01 12:47 ` Michal Hocko
2019-07-01 12:47 ` Michal Hocko
2019-07-01 12:47 ` Michal Hocko
2019-07-15 10:45 ` David Hildenbrand
2019-07-15 10:45 ` David Hildenbrand
2019-07-15 10:45 ` David Hildenbrand
2019-07-15 10:45 ` David Hildenbrand
2019-05-27 11:11 ` [PATCH v3 04/11] arm64/mm: Add temporary arch_remove_memory() implementation David Hildenbrand
2019-05-27 11:11 ` David Hildenbrand
2019-05-27 11:11 ` David Hildenbrand
2019-05-27 11:11 ` David Hildenbrand
2019-06-03 21:41 ` Wei Yang
2019-06-03 21:41 ` Wei Yang
2019-06-03 21:41 ` Wei Yang
2019-06-03 21:41 ` Wei Yang
2019-06-04 6:56 ` David Hildenbrand
2019-06-04 6:56 ` David Hildenbrand
2019-06-04 6:56 ` David Hildenbrand
2019-06-04 6:56 ` David Hildenbrand
2019-06-04 17:36 ` Robin Murphy
2019-06-04 17:36 ` Robin Murphy
2019-06-04 17:36 ` Robin Murphy
2019-06-04 17:36 ` Robin Murphy
2019-06-04 17:51 ` David Hildenbrand
2019-06-04 17:51 ` David Hildenbrand
2019-06-04 17:51 ` David Hildenbrand
2019-06-04 17:51 ` David Hildenbrand
2019-07-01 12:48 ` Michal Hocko
2019-07-01 12:48 ` Michal Hocko
2019-07-01 12:48 ` Michal Hocko
2019-07-01 12:48 ` Michal Hocko
2019-05-27 11:11 ` [PATCH v3 05/11] drivers/base/memory: Pass a block_id to init_memory_block() David Hildenbrand
2019-05-27 11:11 ` David Hildenbrand
2019-05-27 11:11 ` David Hildenbrand
2019-05-27 11:11 ` David Hildenbrand
2019-06-03 21:49 ` Wei Yang
2019-06-03 21:49 ` Wei Yang
2019-06-03 21:49 ` Wei Yang
2019-06-03 21:49 ` Wei Yang
2019-06-04 6:56 ` David Hildenbrand
2019-06-04 6:56 ` David Hildenbrand
2019-06-04 6:56 ` David Hildenbrand
2019-06-04 6:56 ` David Hildenbrand
2019-07-01 7:56 ` Michal Hocko
2019-07-01 7:56 ` Michal Hocko
2019-07-01 7:56 ` Michal Hocko
2019-07-01 7:56 ` Michal Hocko
2019-05-27 11:11 ` [PATCH v3 06/11] mm/memory_hotplug: Allow arch_remove_pages() without CONFIG_MEMORY_HOTREMOVE David Hildenbrand
2019-05-27 11:11 ` David Hildenbrand
2019-05-30 17:56 ` Pavel Tatashin
2019-05-30 17:56 ` Pavel Tatashin
2019-06-03 22:15 ` Wei Yang
2019-06-03 22:15 ` Wei Yang
2019-06-04 6:59 ` David Hildenbrand
2019-06-04 6:59 ` David Hildenbrand
2019-06-04 8:31 ` Wei Yang
2019-06-04 8:31 ` Wei Yang
2019-06-04 9:00 ` David Hildenbrand
2019-06-04 9:00 ` David Hildenbrand
2019-07-01 8:01 ` Michal Hocko
2019-07-01 8:01 ` Michal Hocko
2019-07-01 12:51 ` Michal Hocko
2019-07-01 12:51 ` Michal Hocko
2019-07-15 10:54 ` David Hildenbrand
2019-07-15 10:54 ` David Hildenbrand
2019-07-19 6:06 ` Michal Hocko
2019-07-19 6:06 ` Michal Hocko
2019-05-27 11:11 ` [PATCH v3 07/11] mm/memory_hotplug: Create memory block devices after arch_add_memory() David Hildenbrand
2019-05-27 11:11 ` David Hildenbrand
2019-05-27 11:11 ` David Hildenbrand
2019-05-27 11:11 ` David Hildenbrand
2019-05-30 21:07 ` Pavel Tatashin
2019-05-30 21:07 ` Pavel Tatashin
2019-05-30 21:07 ` Pavel Tatashin
2019-05-30 21:07 ` Pavel Tatashin
2019-06-04 21:42 ` Wei Yang
2019-06-04 21:42 ` Wei Yang
2019-06-04 21:42 ` Wei Yang
2019-06-04 21:42 ` Wei Yang
2019-06-05 8:58 ` David Hildenbrand
2019-06-05 8:58 ` David Hildenbrand
2019-06-05 8:58 ` David Hildenbrand
2019-06-05 8:58 ` David Hildenbrand
2019-06-05 10:58 ` David Hildenbrand
2019-06-05 10:58 ` David Hildenbrand
2019-06-05 10:58 ` David Hildenbrand
2019-06-05 10:58 ` David Hildenbrand
2019-06-05 21:22 ` Wei Yang
2019-06-05 21:22 ` Wei Yang
2019-06-05 21:22 ` Wei Yang
2019-06-05 21:22 ` Wei Yang
2019-06-05 21:50 ` David Hildenbrand
2019-06-05 21:50 ` David Hildenbrand
2019-06-05 21:50 ` David Hildenbrand
2019-06-05 21:50 ` David Hildenbrand
2019-07-01 8:14 ` Michal Hocko
2019-07-01 8:14 ` Michal Hocko
2019-07-01 8:14 ` Michal Hocko
2019-07-01 8:14 ` Michal Hocko
2019-05-27 11:11 ` [PATCH v3 08/11] mm/memory_hotplug: Drop MHP_MEMBLOCK_API David Hildenbrand
2019-05-27 11:11 ` David Hildenbrand
2019-05-27 11:11 ` David Hildenbrand
2019-05-27 11:11 ` David Hildenbrand
2019-06-04 21:47 ` Wei Yang
2019-06-04 21:47 ` Wei Yang
2019-06-04 21:47 ` Wei Yang
2019-06-04 21:47 ` Wei Yang
2019-07-01 8:15 ` Michal Hocko
2019-07-01 8:15 ` Michal Hocko
2019-07-01 8:15 ` Michal Hocko
2019-07-01 8:15 ` Michal Hocko
2019-05-27 11:11 ` [PATCH v3 09/11] mm/memory_hotplug: Remove memory block devices before arch_remove_memory() David Hildenbrand
2019-05-27 11:11 ` David Hildenbrand
2019-05-27 11:11 ` David Hildenbrand
2019-05-27 11:11 ` David Hildenbrand
2019-06-04 22:07 ` Wei Yang
2019-06-04 22:07 ` Wei Yang
2019-06-04 22:07 ` Wei Yang
2019-06-04 22:07 ` Wei Yang
2019-06-05 9:00 ` David Hildenbrand
2019-06-05 9:00 ` David Hildenbrand
2019-06-05 9:00 ` David Hildenbrand
2019-06-05 9:00 ` David Hildenbrand
2019-07-01 8:41 ` Michal Hocko
2019-07-01 8:41 ` Michal Hocko
2019-07-01 8:41 ` Michal Hocko
2019-07-01 8:41 ` Michal Hocko
2019-07-15 10:58 ` David Hildenbrand
2019-07-15 10:58 ` David Hildenbrand
2019-07-15 10:58 ` David Hildenbrand
2019-07-15 10:58 ` David Hildenbrand
2019-05-27 11:11 ` [PATCH v3 10/11] mm/memory_hotplug: Make unregister_memory_block_under_nodes() never fail David Hildenbrand
2019-05-27 11:11 ` David Hildenbrand
2019-05-27 11:11 ` David Hildenbrand
2019-05-27 11:11 ` David Hildenbrand
2019-06-05 21:21 ` Wei Yang
2019-06-05 21:21 ` Wei Yang
2019-06-05 21:21 ` Wei Yang
2019-06-05 21:21 ` Wei Yang
2019-06-10 16:56 ` Oscar Salvador
2019-06-10 16:56 ` Oscar Salvador
2019-06-10 16:56 ` Oscar Salvador
2019-06-10 16:56 ` Oscar Salvador
2019-07-01 8:51 ` Michal Hocko
2019-07-01 8:51 ` Michal Hocko
2019-07-01 8:51 ` Michal Hocko
2019-07-01 8:51 ` Michal Hocko
2019-07-01 9:36 ` Oscar Salvador [this message]
2019-07-01 9:36 ` Oscar Salvador
2019-07-01 9:36 ` Oscar Salvador
2019-07-01 9:36 ` Oscar Salvador
2019-07-01 10:27 ` Michal Hocko
2019-07-01 10:27 ` Michal Hocko
2019-07-01 10:27 ` Michal Hocko
2019-07-01 10:27 ` Michal Hocko
2019-07-15 11:10 ` David Hildenbrand
2019-07-15 11:10 ` David Hildenbrand
2019-07-15 11:10 ` David Hildenbrand
2019-07-15 11:10 ` David Hildenbrand
2019-07-16 8:46 ` Oscar Salvador
2019-07-16 8:46 ` Oscar Salvador
2019-07-16 8:46 ` Oscar Salvador
2019-07-16 8:46 ` Oscar Salvador
2019-07-16 11:08 ` David Hildenbrand
2019-07-16 11:08 ` David Hildenbrand
2019-07-16 11:08 ` David Hildenbrand
2019-07-16 11:08 ` David Hildenbrand
2019-07-16 11:09 ` David Hildenbrand
2019-07-16 11:09 ` David Hildenbrand
2019-07-16 11:09 ` David Hildenbrand
2019-07-16 11:09 ` David Hildenbrand
2019-07-19 6:05 ` Michal Hocko
2019-07-19 6:05 ` Michal Hocko
2019-07-19 6:05 ` Michal Hocko
2019-07-19 6:05 ` Michal Hocko
2019-05-27 11:11 ` [PATCH v3 11/11] mm/memory_hotplug: Remove "zone" parameter from sparse_remove_one_section David Hildenbrand
2019-05-27 11:11 ` David Hildenbrand
2019-05-27 11:11 ` David Hildenbrand
2019-05-27 11:11 ` David Hildenbrand
2019-06-05 21:21 ` Wei Yang
2019-06-05 21:21 ` Wei Yang
2019-06-05 21:21 ` Wei Yang
2019-06-05 21:21 ` Wei Yang
2019-06-10 16:58 ` Oscar Salvador
2019-06-10 16:58 ` Oscar Salvador
2019-06-10 16:58 ` Oscar Salvador
2019-06-10 16:58 ` Oscar Salvador
2019-07-01 8:52 ` Michal Hocko
2019-07-01 8:52 ` Michal Hocko
2019-07-01 8:52 ` Michal Hocko
2019-07-01 8:52 ` Michal Hocko
2019-06-03 21:21 ` [PATCH v3 00/11] mm/memory_hotplug: Factor out memory block devicehandling Wei Yang
2019-06-03 21:21 ` Wei Yang
2019-06-03 21:40 ` David Hildenbrand
2019-06-03 21:40 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190701093640.GA17349@linux \
--to=osalvador@suse.de \
--cc=Jonathan.Cameron@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=alexander.deucher@amd.com \
--cc=broonie@kernel.org \
--cc=chris@chris-wilson.co.uk \
--cc=dan.j.williams@intel.com \
--cc=davem@davemloft.net \
--cc=david@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=imammedo@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mhocko@kernel.org \
--cc=rafael@kernel.org \
--cc=richard.weiyang@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.