RFC: Add DISTRO_FEATURES(xfce) to control meta-xfce

RFC: Add DISTRO_FEATURES(xfce) to control meta-xfce

[Hongxu Jia]

Hi all,

Currently, I am improving OE to follow Yocto Project Compatible,
One rule of Yocto Project Compatible is when a new layer is added,
it should not affect other layer, but unfortunately, bbappend in
meta-xfce broke the rule.

So I suggest to add DISTRO_FEATURES(xfce) as a switch to control,
in short term, we could use it to control bbappend in meta-xfce,
in long term, we could use it to control more xfce specific features

(As a alternative way, I also tried to remove bbappend directly,
but I found the existence of bbappend is indeed necessary)

Here is result of
yocto-check-layer-wrapper <build_path>/meta-openembedded/meta-xfce 
--dependency <layer_dep>
[snip]
INFO: test_signatures (common.CommonCheckLayer)
INFO:  ... FAIL

Stdout:
Loading cache...done.
Loaded 3455 entries from dependency cache.
INFO: Traceback (most recent call last):
   File 
"/buildarea1/hjia/community/poky/scripts/lib/checklayer/cases/common.py", 
line 55, in test_signatures
     self.fail('Adding layer %s changed signatures.\n%s' % 
(self.tc.layer['name'], msg))
AssertionError: Adding layer meta-xfce changed signatures.
26 signatures changed, initial differences (first hash before, second 
after):
    blueman:do_configure: 
8c2ddf90c8938d87279b65da1aa61f09c320772043065cfd715fdf17e3c438fe -> 
2494f27a9f561303f6bcffdcfc648518d0061ec25c0ef818c74a387a7c796392
       bitbake-diffsigs --task blueman do_configure --signature 
8c2ddf90c8938d87279b65da1aa61f09c320772043065cfd715fdf17e3c438fe 
2494f27a9f561303f6bcffdcfc648518d0061ec25c0ef818c74a387a7c796392
       NOTE: Starting bitbake server...
       basehash changed from 
cc10b6d09fc23a6932bc549ed1d5989c2bdd822de05aefbbeb1137d4b7cb2479 to 
757a8b62860f22c9620fcc20937c9291e1bee24434db57f37332529cc418dca9
       Variable PACKAGECONFIG_CONFARGS value changed:
       " [---disable-thunar-sendto-] {+--enable-thunar-sendto+}"
       Variable PACKAGECONFIG value changed from '' to ' thunar'

    lxdm:do_fetch: 
becb6b35029e6fe78cd71230062d064f5eb6e2812c04db1e2dd32c3a005a20de -> 
70ef73642eca8825964901efe753d882fc564697f2adf6171b21121a8721dd45
       bitbake-diffsigs --task lxdm do_fetch --signature 
becb6b35029e6fe78cd71230062d064f5eb6e2812c04db1e2dd32c3a005a20de 
70ef73642eca8825964901efe753d882fc564697f2adf6171b21121a8721dd45
       NOTE: Starting bitbake server...
       basehash changed from 
e07ec051ed015a41d2ee46cd0babe75445ebd66c9c0cb12180a3ce57b4247a39 to 
8889a6defcb5a285bbce0dbe6cc9458b4a4483287275390bedf6c5fb07d33641
       Variable SRC_URI value changed:
       @@ -1,3 +1,3 @@
-${SOURCEFORGE_MIRROR}/project/${BPN}/${BPN}%20${PV}/${BPN}-${PV}.tar.xz 
file://lxdm.conf ${@bb.utils.contains('DISTRO_FEATURES', 'pam', 
'file://lxdm-pam file://lxdm-pam-debug', '', d)} 
${@bb.utils.contains("DISTRO_TYPE", "debug", "", 
"file://0001-lxdm.conf.in-blacklist-root-for-release-images.patch",d)} 
file://0002-let-autotools-create-lxdm.conf.patch 
file://0003-check-for-libexecinfo-providing-backtrace-APIs.patch 
file://0004-fix-css-under-gtk-3.20.patch
+${SOURCEFORGE_MIRROR}/project/${BPN}/${BPN}%20${PV}/${BPN}-${PV}.tar.xz 
file://lxdm.conf ${@bb.utils.contains('DISTRO_FEATURES', 'pam', 
'file://lxdm-pam file://lxdm-pam-debug', '', d)} 
${@bb.utils.contains("DISTRO_TYPE", "debug", "", 
"file://0001-lxdm.conf.in-blacklist-root-for-release-images.patch",d)} 
file://0002-let-autotools-create-lxdm.conf.patch 
file://0003-check-for-libexecinfo-providing-backtrace-APIs.patch 
file://0004-fix-css-under-gtk-3.20.patch file://gdmflexiserver
        DISTRO_FEATURES{pam} = Unset
        DISTRO_TYPE{debug} = Set
       Dependency on checksum of file gdmflexiserver was added
[snip]

If add DISTRO_FEATURES(xfce) is OK, I will start to work on it
and update meta-xfce/README; if you have other better idea to
the improvement, any suggestion is welcome

//Hongxu

Re: RFC: Add DISTRO_FEATURES(xfce) to control meta-xfce

[Adrian Bunk]

On Fri, Jun 28, 2019 at 10:20:36AM +0800, Hongxu Jia wrote:
> Hi all,
> 
> Currently, I am improving OE to follow Yocto Project Compatible,
> One rule of Yocto Project Compatible is when a new layer is added,
> it should not affect other layer, but unfortunately, bbappend in
> meta-xfce broke the rule.
> 
> So I suggest to add DISTRO_FEATURES(xfce) as a switch to control,
> in short term, we could use it to control bbappend in meta-xfce,
> in long term, we could use it to control more xfce specific features
> 
> (As a alternative way, I also tried to remove bbappend directly,
> but I found the existence of bbappend is indeed necessary)

blueman upstream defaults to installing the files for thunar-sendto.
Andreas, was there any specific reason why you made this conditional
instead of keeping it enabled unconditional with only an RSUGGESTS
on thunar?

gdmflexiserver looks like a workaround for something that should be
fixed properly instead to me.
But short-term adding it to the normal lxdm recipe in meta-oe might
be an options?

> //Hongxu

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

Re: RFC: Add DISTRO_FEATURES(xfce) to control meta-xfce

[Hongxu Jia]

On 6/28/19 8:58 PM, Adrian Bunk wrote:
> On Fri, Jun 28, 2019 at 10:20:36AM +0800, Hongxu Jia wrote:
>> Hi all,
>>
>> Currently, I am improving OE to follow Yocto Project Compatible,
>> One rule of Yocto Project Compatible is when a new layer is added,
>> it should not affect other layer, but unfortunately, bbappend in
>> meta-xfce broke the rule.
>>
>> So I suggest to add DISTRO_FEATURES(xfce) as a switch to control,
>> in short term, we could use it to control bbappend in meta-xfce,
>> in long term, we could use it to control more xfce specific features
>>
>> (As a alternative way, I also tried to remove bbappend directly,
>> but I found the existence of bbappend is indeed necessary)
> blueman upstream defaults to installing the files for thunar-sendto.
> Andreas, was there any specific reason why you made this conditional
> instead of keeping it enabled unconditional with only an RSUGGESTS
> on thunar?

Currently DISTRO_FEATURES(xfce) is used to control this bbappend,

if we could merge the bbappend to recipe thunar, I think it is not

necessary to add DISTRO_FEATURES(xfce) in short term

> gdmflexiserver looks like a workaround for something that should be
> fixed properly instead to me.
> But short-term adding it to the normal lxdm recipe in meta-oe might
> be an options?

No need to add extra lxdm, I am working to remove this bbappend,

and modify xfce4-panel to use lxdm to instead of lightdm directly,

we do not need this bbappend to provide a fake gdmflexiserver

//Hongxu

>> //Hongxu
> cu
> Adrian
>

Re: RFC: Add DISTRO_FEATURES(xfce) to control meta-xfce

[Adrian Bunk]

On Fri, Jun 28, 2019 at 10:23:51PM +0800, Hongxu Jia wrote:
> On 6/28/19 8:58 PM, Adrian Bunk wrote:
> > On Fri, Jun 28, 2019 at 10:20:36AM +0800, Hongxu Jia wrote:
> > > Hi all,
> > > 
> > > Currently, I am improving OE to follow Yocto Project Compatible,
> > > One rule of Yocto Project Compatible is when a new layer is added,
> > > it should not affect other layer, but unfortunately, bbappend in
> > > meta-xfce broke the rule.
> > > 
> > > So I suggest to add DISTRO_FEATURES(xfce) as a switch to control,
> > > in short term, we could use it to control bbappend in meta-xfce,
> > > in long term, we could use it to control more xfce specific features
> > > 
> > > (As a alternative way, I also tried to remove bbappend directly,
> > > but I found the existence of bbappend is indeed necessary)
> > blueman upstream defaults to installing the files for thunar-sendto.
> > Andreas, was there any specific reason why you made this conditional
> > instead of keeping it enabled unconditional with only an RSUGGESTS
> > on thunar?
> 
> Currently DISTRO_FEATURES(xfce) is used to control this bbappend,
> 
> if we could merge the bbappend to recipe thunar, I think it is not
> 
> necessary to add DISTRO_FEATURES(xfce) in short term

I just sent
  blueman: Enable thunar support by default but don't rdepend on it
that should also fix this problem.

> > gdmflexiserver looks like a workaround for something that should be
> > fixed properly instead to me.
> > But short-term adding it to the normal lxdm recipe in meta-oe might
> > be an options?
> 
> No need to add extra lxdm, I am working to remove this bbappend,
> 
> and modify xfce4-panel to use lxdm to instead of lightdm directly,
> 
> we do not need this bbappend to provide a fake gdmflexiserver

Thanks, that looks a lot better than what I had in mind.

> //Hongxu

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

Re: RFC: Add DISTRO_FEATURES(xfce) to control meta-xfce

[Hongxu Jia]

On 7/1/19 8:48 PM, Adrian Bunk wrote:
> I just sent
>    blueman: Enable thunar support by default but don't rdepend on it
> that should also fix this problem.

Thanks, it is exactly what we expect, then we do not need to do extra 
configure for xfce

//Hongxu