From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
"Samuel Ortiz" <sameo@linux.intel.com>,
kvm@vger.kernel.org, "Yang Zhong" <yang.zhong@intel.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Rob Bradford" <robert.bradford@intel.com>,
"Eduardo Habkost" <ehabkost@redhat.com>,
"Marcelo Tosatti" <mtosatti@redhat.com>,
"Richard Henderson" <rth@twiddle.net>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Li Qiang" <liq3ea@gmail.com>
Subject: [PATCH v3 01/15] hw/i386/pc: Use e820_get_num_entries() to access e820_entries
Date: Mon, 1 Jul 2019 15:35:22 +0200 [thread overview]
Message-ID: <20190701133536.28946-2-philmd@redhat.com> (raw)
In-Reply-To: <20190701133536.28946-1-philmd@redhat.com>
To be able to extract the e820* code out of this file (in the next
patch), access e820_entries with its correct helper.
Reviewed-by: Li Qiang <liq3ea@gmail.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
hw/i386/pc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/i386/pc.c b/hw/i386/pc.c
index e96360b47a..691726b85b 100644
--- a/hw/i386/pc.c
+++ b/hw/i386/pc.c
@@ -1020,7 +1020,7 @@ static FWCfgState *bochs_bios_init(AddressSpace *as, PCMachineState *pcms)
fw_cfg_add_bytes(fw_cfg, FW_CFG_E820_TABLE,
&e820_reserve, sizeof(e820_reserve));
fw_cfg_add_file(fw_cfg, "etc/e820", e820_table,
- sizeof(struct e820_entry) * e820_entries);
+ sizeof(struct e820_entry) * e820_get_num_entries());
fw_cfg_add_bytes(fw_cfg, FW_CFG_HPET, &hpet_cfg, sizeof(hpet_cfg));
/* allocate memory for the NUMA channel: one (64bit) word for the number
--
2.20.1
WARNING: multiple messages have this Message-ID (diff)
From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Yang Zhong" <yang.zhong@intel.com>,
"Samuel Ortiz" <sameo@linux.intel.com>,
kvm@vger.kernel.org, "Michael S. Tsirkin" <mst@redhat.com>,
"Marcelo Tosatti" <mtosatti@redhat.com>,
"Li Qiang" <liq3ea@gmail.com>,
"Rob Bradford" <robert.bradford@intel.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Richard Henderson" <rth@twiddle.net>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Eduardo Habkost" <ehabkost@redhat.com>
Subject: [Qemu-devel] [PATCH v3 01/15] hw/i386/pc: Use e820_get_num_entries() to access e820_entries
Date: Mon, 1 Jul 2019 15:35:22 +0200 [thread overview]
Message-ID: <20190701133536.28946-2-philmd@redhat.com> (raw)
In-Reply-To: <20190701133536.28946-1-philmd@redhat.com>
To be able to extract the e820* code out of this file (in the next
patch), access e820_entries with its correct helper.
Reviewed-by: Li Qiang <liq3ea@gmail.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
hw/i386/pc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/i386/pc.c b/hw/i386/pc.c
index e96360b47a..691726b85b 100644
--- a/hw/i386/pc.c
+++ b/hw/i386/pc.c
@@ -1020,7 +1020,7 @@ static FWCfgState *bochs_bios_init(AddressSpace *as, PCMachineState *pcms)
fw_cfg_add_bytes(fw_cfg, FW_CFG_E820_TABLE,
&e820_reserve, sizeof(e820_reserve));
fw_cfg_add_file(fw_cfg, "etc/e820", e820_table,
- sizeof(struct e820_entry) * e820_entries);
+ sizeof(struct e820_entry) * e820_get_num_entries());
fw_cfg_add_bytes(fw_cfg, FW_CFG_HPET, &hpet_cfg, sizeof(hpet_cfg));
/* allocate memory for the NUMA channel: one (64bit) word for the number
--
2.20.1
next prev parent reply other threads:[~2019-07-01 13:35 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-01 13:35 [PATCH v3 00/15] hw/i386/pc: Do not restrict the fw_cfg functions to the PC machine Philippe Mathieu-Daudé
2019-07-01 13:35 ` [Qemu-devel] " Philippe Mathieu-Daudé
2019-07-01 13:35 ` Philippe Mathieu-Daudé [this message]
2019-07-01 13:35 ` [Qemu-devel] [PATCH v3 01/15] hw/i386/pc: Use e820_get_num_entries() to access e820_entries Philippe Mathieu-Daudé
2019-07-01 13:35 ` [PATCH v3 02/15] hw/i386/pc: Extract e820 memory layout code Philippe Mathieu-Daudé
2019-07-01 13:35 ` [Qemu-devel] " Philippe Mathieu-Daudé
2019-07-01 13:35 ` [PATCH v3 03/15] hw/i386/pc: Use address_space_memory in place Philippe Mathieu-Daudé
2019-07-01 13:35 ` [Qemu-devel] " Philippe Mathieu-Daudé
2019-07-01 13:35 ` [PATCH v3 04/15] hw/i386/pc: Rename bochs_bios_init as more generic fw_cfg_arch_create Philippe Mathieu-Daudé
2019-07-01 13:35 ` [Qemu-devel] " Philippe Mathieu-Daudé
2019-07-01 13:35 ` [PATCH v3 05/15] hw/i386/pc: Pass the boot_cpus value by argument Philippe Mathieu-Daudé
2019-07-01 13:35 ` [Qemu-devel] " Philippe Mathieu-Daudé
2019-07-01 13:35 ` [PATCH v3 06/15] hw/i386/pc: Pass the apic_id_limit " Philippe Mathieu-Daudé
2019-07-01 13:35 ` [Qemu-devel] " Philippe Mathieu-Daudé
2019-07-01 13:35 ` [PATCH v3 07/15] hw/i386/pc: Pass the CPUArchIdList array " Philippe Mathieu-Daudé
2019-07-01 13:35 ` [Qemu-devel] " Philippe Mathieu-Daudé
2019-07-01 13:35 ` [PATCH v3 08/15] hw/i386/pc: Let fw_cfg_init() use the generic MachineState Philippe Mathieu-Daudé
2019-07-01 13:35 ` [Qemu-devel] " Philippe Mathieu-Daudé
2019-07-01 16:01 ` Christophe de Dinechin
2019-07-01 16:01 ` Christophe de Dinechin
2019-07-01 19:56 ` Philippe Mathieu-Daudé
2019-07-01 19:56 ` Philippe Mathieu-Daudé
2019-07-01 13:35 ` [PATCH v3 09/15] hw/i386/pc: Let pc_build_smbios() take a FWCfgState argument Philippe Mathieu-Daudé
2019-07-01 13:35 ` [Qemu-devel] " Philippe Mathieu-Daudé
2019-07-01 13:35 ` [PATCH v3 10/15] hw/i386/pc: Let pc_build_smbios() take a generic MachineState argument Philippe Mathieu-Daudé
2019-07-01 13:35 ` [Qemu-devel] " Philippe Mathieu-Daudé
2019-07-01 13:35 ` [PATCH v3 11/15] hw/i386/pc: Rename pc_build_smbios() as generic fw_cfg_build_smbios() Philippe Mathieu-Daudé
2019-07-01 13:35 ` [Qemu-devel] " Philippe Mathieu-Daudé
2019-07-01 13:35 ` [PATCH v3 12/15] hw/i386/pc: Let pc_build_feature_control() take a FWCfgState argument Philippe Mathieu-Daudé
2019-07-01 13:35 ` [Qemu-devel] " Philippe Mathieu-Daudé
2019-07-01 13:35 ` [PATCH v3 13/15] hw/i386/pc: Let pc_build_feature_control() take a MachineState argument Philippe Mathieu-Daudé
2019-07-01 13:35 ` [Qemu-devel] " Philippe Mathieu-Daudé
2019-07-01 13:35 ` [PATCH v3 14/15] hw/i386/pc: Rename pc_build_feature_control() as generic fw_cfg_build_* Philippe Mathieu-Daudé
2019-07-01 13:35 ` [Qemu-devel] " Philippe Mathieu-Daudé
2019-07-01 13:35 ` [PATCH v3 15/15] hw/i386/pc: Extract the x86 generic fw_cfg code Philippe Mathieu-Daudé
2019-07-01 13:35 ` [Qemu-devel] " Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190701133536.28946-2-philmd@redhat.com \
--to=philmd@redhat.com \
--cc=ehabkost@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=liq3ea@gmail.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=mst@redhat.com \
--cc=mtosatti@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=robert.bradford@intel.com \
--cc=rth@twiddle.net \
--cc=sameo@linux.intel.com \
--cc=yang.zhong@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.